Attachment 150247 Details for Bug 231910 – A test patch to try and narrow down the cause of this bug

[patch] A test patch to try and narrow down the cause of this bug

glock-test-patch.diff (text/plain), 2.70 KB, created by Steve Whitehouse on 2007-03-16 16:08:05 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Steve Whitehouse

Created: 2007-03-16 16:08:05 UTC

Size: 2.70 KB

patch

obsolete

>diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c
>index e707594..6c7e409 100644
>--- a/fs/gfs2/glock.c
>+++ b/fs/gfs2/glock.c
>@@ -113,6 +113,16 @@ static inline rwlock_t *gl_lock_addr(unsigned int x)
> }
> #endif
> 
>+static int dump_glock(struct glock_iter *gi, struct gfs2_glock *gl);
>+
>+void glock_in_wrong_state(struct gfs2_glock *gl, const char *msg)
>+{
>+	print_symbol(KERN_INFO "tried to demote glock in transaction from %s\n", gl->gl_demoter);
>+	printk(KERN_INFO "%s: pid %d\n", msg, gl->gl_demote_task->pid);
>+	dump_glock(NULL, gl);
>+	BUG();
>+}
>+
> /**
>  * relaxed_state_ok - is a requested lock compatible with the current lock mode?
>  * @actual: the current state of the lock
>@@ -668,6 +678,8 @@ static void handle_callback(struct gfs2_glock *gl, unsigned int state)
> 	if (test_and_set_bit(GLF_DEMOTE, &gl->gl_flags) == 0) {
> 		gl->gl_demote_state = state;
> 		gl->gl_demote_time = jiffies;
>+		gl->gl_demoter = (unsigned long)__builtin_return_address(0);
>+		gl->gl_demote_task = current;
> 	} else if (gl->gl_demote_state != LM_ST_UNLOCKED) {
> 		gl->gl_demote_state = state;
> 	}
>@@ -863,6 +875,9 @@ static void drop_bh(struct gfs2_glock *gl, unsigned int ret)
> 	run_queue(gl);
> 	spin_unlock(&gl->gl_spin);
> 
>+	if (!list_empty(&gl->gl_le.le_list)) {
>+		glock_in_wrong_state(gl, "drop_bh");
>+	}
> 	gfs2_glock_put(gl);
> 
> 	if (gh)
>diff --git a/fs/gfs2/glock.h b/fs/gfs2/glock.h
>index 5e662ea..a73f78b 100644
>--- a/fs/gfs2/glock.h
>+++ b/fs/gfs2/glock.h
>@@ -139,5 +139,6 @@ int gfs2_create_debugfs_file(struct gfs2_sbd *sdp);
> void gfs2_delete_debugfs_file(struct gfs2_sbd *sdp);
> int gfs2_register_debugfs(void);
> void gfs2_unregister_debugfs(void);
>+void glock_in_wrong_state(struct gfs2_glock *gl, const char *msg);
> 
> #endif /* __GLOCK_DOT_H__ */
>diff --git a/fs/gfs2/incore.h b/fs/gfs2/incore.h
>index 9c12582..ee15532 100644
>--- a/fs/gfs2/incore.h
>+++ b/fs/gfs2/incore.h
>@@ -155,6 +155,8 @@ struct gfs2_glock {
> 	unsigned int gl_hash;
> 	unsigned int gl_demote_state; /* state requested by remote node */
> 	unsigned long gl_demote_time; /* time of first demote request */
>+	unsigned long gl_demoter; /* caller of demote */
>+	struct task_struct *gl_demote_task; /* ditto */
> 	struct task_struct *gl_owner;
> 	unsigned long gl_ip;
> 	struct list_head gl_holders;
>diff --git a/fs/gfs2/lops.c b/fs/gfs2/lops.c
>index 16bb4b4..de79f1f 100644
>--- a/fs/gfs2/lops.c
>+++ b/fs/gfs2/lops.c
>@@ -58,7 +58,9 @@ static void glock_lo_after_commit(struct gfs2_sbd *sdp, struct gfs2_ail *ai)
> 		list_del_init(&gl->gl_le.le_list);
> 		sdp->sd_log_num_gl--;
> 
>-		gfs2_assert_withdraw(sdp, gfs2_glock_is_held_excl(gl));
>+		if (!gfs2_glock_is_held_excl(gl)) {
>+			glock_in_wrong_state(gl, "glock_lo_after_commit");
>+		}
> 		gfs2_glock_put(gl);
> 	}
> 	gfs2_assert_warn(sdp, !sdp->sd_log_num_gl);

Actions: View | Diff

Attachments on bug 231910: 150247 | 151413 | 153557 | 154134