Attachment 150590 Details for Bug 205610 – jbd patch

[patch] jbd patch

jbd.patch (text/plain), 1.77 KB, created by Eric Sandeen on 2007-03-21 15:08:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Eric Sandeen

Created: 2007-03-21 15:08:59 UTC

Size: 1.77 KB

patch

obsolete

>For
>Bug 224638: jbd __cleanup_transaction skips last buffer on checkpoint list
>
>This is a straight simple backport from upstream... there have been
>some jbd assertions tripping, this may not fix them all but it
>looks like one pretty obvious, safe fix that's been upstream for a while.
>
>Thanks,
>-Eric
>
>================================
>
>From: Jan Kara <jack@suse.cz>
>Date: Thu, 2 Jun 2005 21:02:01 +0000 (-0700)
>Subject: [PATCH] ext3: fix list scanning in __cleanup_transaction
>X-Git-Tag: v2.6.12-rc60~28
>X-Git-Url: http://www.kernel.org/git/?p=linux%2Fkernel%2Fgit%2Ftorvalds%2Flinux-2.6.git;a=commitdiff_plain;h=7e3b11a9be6ac94bf4af81757b6a10e7e65b846f
>
>[PATCH] ext3: fix list scanning in __cleanup_transaction
>
>Fix a bug in list scanning that can cause us to skip the last buffer on the
>checkpoint list (and hence fail to do any progress under some rather
>unfavorable conditions).
>
>The problem is we first do jh=next_jh and then test
>
>	} while (jh!=last_jh);
>
>Hence we skip the last buffer on the list (if it was not the only buffer on
>the list).  As we already do jh=next_jh; in the beginning of the loop we
>are safe to just remove the assignment in the end.  It can happen that 'jh'
>will be freed at the point we test jh != last_jh but that does not matter
>as we never *dereference* the pointer.
>
>Signed-off-by: Jan Kara <jack@suse.cz>
>Signed-off-by: Andrew Morton <akpm@osdl.org>
>Signed-off-by: Linus Torvalds <torvalds@osdl.org>
>---
>
>Index: linux-2.6.9-43.EL/fs/jbd/checkpoint.c
>===================================================================
>--- linux-2.6.9-43.EL.orig/fs/jbd/checkpoint.c
>+++ linux-2.6.9-43.EL/fs/jbd/checkpoint.c
>@@ -188,7 +188,6 @@ static int __cleanup_transaction(journal
> 		} else {
> 			jbd_unlock_bh_state(bh);
> 		}
>-		jh = next_jh;
> 	} while (jh != last_jh);
> 
> 	return ret;
>

Actions: View | Diff

Attachments on bug 205610: 150590