Attachment 151154 Details for Bug 172648 – fix use of device nodes to probe for raid sb

[patch] fix use of device nodes to probe for raid sb

raid.patch (text/plain), 2.16 KB, created by Chris Lumens on 2007-03-28 19:36:05 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Lumens

Created: 2007-03-28 19:36:05 UTC

Size: 2.16 KB

patch

obsolete

>? .ChangeLog.swp
>? isys/.isys.py.swp
>Index: ChangeLog
>===================================================================
>RCS file: /usr/local/CVS/anaconda/ChangeLog,v
>retrieving revision 1.2551
>diff -u -r1.2551 ChangeLog
>--- ChangeLog	28 Mar 2007 15:06:10 -0000	1.2551
>+++ ChangeLog	28 Mar 2007 19:24:47 -0000
>@@ -10,6 +10,9 @@
> 	between the device description and the stripe for tall languages
> 	(#217294).
> 
>+	* isys/isys.py:  Use /dev/ devices nodes for probing RAID superblocks,
>+	instead of recycling the same node in /tmp (#172648, #208970, #215231).
>+
> 2007-03-27  Jeremy Katz  <katzj@redhat.com>
> 
> 	* liveinst/liveinst.sh: Support using hal locking by running
>Index: isys/isys.py
>===================================================================
>RCS file: /usr/local/CVS/anaconda/isys/isys.py,v
>retrieving revision 1.198
>diff -u -r1.198 isys.py
>--- isys/isys.py	7 Feb 2007 18:11:46 -0000	1.198
>+++ isys/isys.py	28 Mar 2007 19:24:47 -0000
>@@ -60,9 +60,11 @@
>             return
>         del raidCount[mdDevice]
> 
>-    makeDevInode(mdDevice, "/tmp/md")
>-    fd = os.open("/tmp/md", os.O_RDONLY)
>-    os.remove("/tmp/md")
>+    devInode = "/dev/%s" % mdDevice
>+
>+    makeDevInode(mdDevice, devInode)
>+    fd = os.open(devInode, os.O_RDONLY)
>+
>     try:
>         _isys.raidstop(fd)
>     except:
>@@ -76,16 +78,18 @@
> 
>     raidCount[mdDevice] = 1
> 
>-    makeDevInode(mdDevice, "/tmp/md")
>-    makeDevInode(aMember, "/tmp/member")
>-    fd = os.open("/tmp/md", os.O_RDONLY)
>-    os.remove("/tmp/md")
>+    mdInode = "/dev/%s" % mdDevice
>+    mbrInode = "/dev/%s" % aMember
>+
>+    makeDevInode(mdDevice, mdInode)
>+    makeDevInode(aMember, mbrInode)
>+    fd = os.open(mdInode, os.O_RDONLY)
>+
>     try:
>-        _isys.raidstart(fd, "/tmp/member")
>+        _isys.raidstart(fd, mbrInode)
>     except:
>         pass
>     os.close(fd)
>-    os.remove("/tmp/member")
> 
> def wipeRaidSB(device):
>     try:
>@@ -101,8 +105,8 @@
>     return
> 
> def raidsb(mdDevice):
>-    makeDevInode(mdDevice, "/tmp/md")
>-    return raidsbFromDevice("/tmp/md")
>+    makeDevInode(mdDevice, "/dev/%s" % mdDevice)
>+    return raidsbFromDevice("/dev/%s" % mdDevice)
> 
> def raidsbFromDevice(device):
>     fd = os.open(device, os.O_RDONLY)

Actions: View | Diff

Attachments on bug 172648: 151154 | 313522