Attachment 151708 Details for Bug 235279 – fix removal of invalid partition requests

[patch] fix removal of invalid partition requests

235279.patch (text/plain), 1.54 KB, created by Chris Lumens on 2007-04-04 19:53:44 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Lumens

Created: 2007-04-04 19:53:44 UTC

Size: 1.54 KB

patch

obsolete

>Index: autopart.py
>===================================================================
>RCS file: /usr/local/CVS/anaconda/autopart.py,v
>retrieving revision 1.185.4.4
>diff -u -r1.185.4.4 autopart.py
>--- autopart.py	15 Jan 2007 18:56:46 -0000	1.185.4.4
>+++ autopart.py	4 Apr 2007 19:49:12 -0000
>@@ -1443,6 +1443,8 @@
>     # requests.  These VGs should only be present on installs where we're
>     # using preexisting partitions that already have LVM information.  We
>     # need to do the same thing for preexisting RAID requests, as well.
>+    removeReqs = []
>+
>     for req in partitions.requests:
>         if isinstance(req, partRequests.VolumeGroupRequestSpec):
>             lst = req.physicalVolumes
>@@ -1452,13 +1454,21 @@
>             continue
> 
>         if len(filter (lambda id: partitions.getRequestByID(id) != None, lst)) == 0:
>-            partitions.removeRequest (req)
>+            removeReqs.append(req)
>+
>+    for req in removeReqs:
>+        partitions.removeRequest(req)
>+
>+    removeReqs = []
> 
>     # Now that we've removed bad VGs, remove all LVs that would have
>     # resided on those VGs.
>     for req in filter (lambda r: isinstance(r, partRequests.LogicalVolumeRequestSpec), partitions.requests):
>         if partitions.getRequestByID(req.volumeGroup) == None:
>-            partitions.removeRequest (req)
>+            removeReqs.append(req)
>+
>+    for req in removeReqs:
>+        partitions.removeRequest(req)
> 
>     # sanity checks for the auto partitioning requests; mostly only useful
>     # for kickstart as our installclass defaults SHOULD be sane

Actions: View | Diff

Attachments on bug 235279: 151708