Attachment 153039 Details for Bug 234338 – patch posted to rhkernel on 04/19

patch posted to rhkernel on 04/19

gfs2-printk-before-error.patch (text/plain), 1.20 KB, created by David Teigland on 2007-04-19 17:39:49 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Teigland

Created: 2007-04-19 17:39:49 UTC

Size: 1.20 KB

patch

obsolete

>[PATCH] gfs2: use log_error before LM_OUT_ERROR
>
>bz 234338
>
>We always want to see the details of the error returned to gfs, but
>log_debug is often turned off, so use log_error (printk).
>
>Index: linux-2.6.21-rc5-quilt/fs/gfs2/locking/dlm/lock.c
>===================================================================
>--- linux-2.6.21-rc5-quilt.orig/fs/gfs2/locking/dlm/lock.c	2007-02-04 12:44:54.000000000 -0600
>+++ linux-2.6.21-rc5-quilt/fs/gfs2/locking/dlm/lock.c	2007-03-28 12:46:53.000000000 -0500
>@@ -268,7 +268,7 @@
> 	}
> 
> 	if (error) {
>-		log_debug("%s: gdlm_lock %x,%llx err=%d cur=%d req=%d lkf=%x "
>+		log_error("%s: gdlm_lock %x,%llx err=%d cur=%d req=%d lkf=%x "
> 			  "flags=%lx", ls->fsname, lp->lockname.ln_type,
> 			  (unsigned long long)lp->lockname.ln_number, error,
> 			  lp->cur, lp->req, lp->lkf, lp->flags);
>@@ -296,7 +296,7 @@
> 	error = dlm_unlock(ls->dlm_lockspace, lp->lksb.sb_lkid, lkf, NULL, lp);
> 
> 	if (error) {
>-		log_debug("%s: gdlm_unlock %x,%llx err=%d cur=%d req=%d lkf=%x "
>+		log_error("%s: gdlm_unlock %x,%llx err=%d cur=%d req=%d lkf=%x "
> 			  "flags=%lx", ls->fsname, lp->lockname.ln_type,
> 			  (unsigned long long)lp->lockname.ln_number, error,
> 			  lp->cur, lp->req, lp->lkf, lp->flags);

Actions: View

Attachments on bug 234338: 153039