Attachment 153265 Details for Bug 187565 – Bad patch

[patch] Bad patch

draw-expander.patch (text/plain), 1.46 KB, created by Matthew Barnes on 2007-04-23 05:29:41 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Matthew Barnes

Created: 2007-04-23 05:29:41 UTC

Size: 1.46 KB

patch

obsolete

>Index: widgets/table/e-cell-tree.c
>===================================================================
>--- widgets/table/e-cell-tree.c	(revision 33440)
>+++ widgets/table/e-cell-tree.c	(working copy)
>@@ -229,13 +229,30 @@ draw_retro_expander (ECellTreeView *ectv
> }
> 
> static void
>-draw_expander (ECellTreeView *ectv, GdkDrawable *drawable, GtkExpanderStyle expander_style, GtkStateType state, GdkRectangle *rect)
>+draw_expander (ECellTreeView *ectv, GdkDrawable *drawable,
>+               GtkExpanderStyle expander_style, GtkStateType state,
>+               GdkRectangle *rect)
> {
> 	GtkWidget *tree = GTK_WIDGET (ectv->canvas)->parent;
>-	gint exp_size;
>-	gtk_widget_style_get (tree, "expander_size", &exp_size, NULL);
>+	gint exp_size, x, y;
> 
>-	gtk_paint_expander (tree->style, drawable, state, rect, tree, "treeview", rect->x + rect->width - exp_size / 2, rect->y + rect->height / 2, expander_style);
>+	gtk_widget_style_get (tree, "expander-size", &exp_size, NULL);
>+
>+	/* Calculate the center of the right-justified expander. */
>+	x = rect->x + rect->width - exp_size / 2;
>+	y = rect->y + rect->height / 2;
>+
>+	/* XXX Drawable is actually a GdkPixbuf, not a GdkWindow.
>+	 *     But the begin_paint / end_paint functions still seem to
>+	 *     improve the situation.  I don't understand why. */
>+
>+	gdk_window_begin_paint_rect (drawable, rect);
>+
>+	gtk_paint_expander (
>+		tree->style, drawable, state, rect, tree,
>+		"treeview", x, y, expander_style);
>+
>+	gdk_window_end_paint (drawable);
> }
> 
> /*

Actions: View | Diff

Attachments on bug 187565: 137833 | 153265