Attachment 153445 Details for Bug 234717 – Complete review report.

Complete review report.

python-spambayes review.html (text/html), 4.91 KB, created by Trond Danielsen on 2007-04-25 19:42:05 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Trond Danielsen

Created: 2007-04-25 19:42:05 UTC

Size: 4.91 KB

patch

obsolete

><html xmlns:tomboy="http://beatniksoftware.com/tomboy" xmlns:link="http://beatniksoftware.com/tomboy/link" xmlns:size="http://beatniksoftware.com/tomboy/size"><head><META http-equiv="Content-Type" content="text/html; charset=utf-8"><title>python-spambayes review</title><style type="text/css">
>        
>	body {  }
>	h1 { font-size: xx-large;
>     	     font-weight: bold;
>     	     color: red;
>     	     text-decoration: underline; }
>	div.note { overflow: auto;
>		   position: relative;
>		   border: 1px solid black;
>		   display: block;
>		   padding: 5pt;
>		   margin: 5pt; 
>		   white-space: -moz-pre-wrap; /* Mozilla */
> 	      	   white-space: -pre-wrap;     /* Opera 4 - 6 */
> 	      	   white-space: -o-pre-wrap;   /* Opera 7 */
> 	      	   white-space: pre-wrap;      /* CSS3 */
> 	      	   word-wrap: break-word;      /* IE 5.5+ */ }
>	</style></head><body><div class="note" id="python-spambayes review" style="width:712;"><a name="#python-spambayes review"></a><h1>python-spambayes review</h1>
>MUST Items:
>
>    *
>
>      - MUST: rpmlint must be run on every package. The output should be posted in the review.
>OK
>
>      - MUST: The package must be named according to the Package Naming Guidelines.
>OK
>
>      - MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption on Package Naming Guidelines.
>OK
>
>      - MUST: The package must meet the Packaging Guidelines.
>
>
>      - MUST: The package must be licensed with an open-source compatible license and meet other legal requirements as defined in the legal section of Packaging Guidelines.
>OK
>
>      - MUST: The License field in the package spec file must match the actual license.
>OK
>
>      - MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc.
>OK
>
>      - MUST: The spec file must be written in American English.
>OK
>
>      - MUST: The spec file for the package MUST be legible. If the reviewer is unable to read the spec file, it will be impossible to perform a review. Fedora is not the place for entries into the Obfuscated Code Contest (<a href="http://www.ioccc.org/">http://www.ioccc.org/</a>).
>OK
>
>      - MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use md5sum for this task. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this.
>OK
>
>      - MUST: The package must successfully compile and build into binary rpms on at least one supported architecture.
>OK. Tested on i386 and x86_64
>
>
>
>      - MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines; inclusion of those as BuildRequires is optional. Apply common sense.
>OK
>
>
>      - MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review, along with the rationalization for relocation of that specific package. Without this, use of Prefix: /usr is considered a blocker.
>OK
>
>      - MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. The exception to this are directories listed explicitly in the Filesystem Hierarchy Standard (<a href="http://www.pathname.com/fhs/pub/fhs-2.3.html">http://www.pathname.com/fhs/pub/fhs-2.3.html</a>), as it is safe to assume that those directories exist.
>OK
>
>      - MUST: A package must not contain any duplicate files in the %files listing.
>OK
>
>      - MUST: Permissions on files must be set properly. Executables should be set with executable permissions, for example. Every %files section must include a %defattr(...) line.
>OK
>
>      - MUST: Each package must have a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT).
>OK
>
>      - MUST: Each package must consistently use macros, as described in the macros section of Packaging Guidelines.
>OK
>
>      - MUST: The package must contain code, or permissable content. This is described in detail in the code vs. content section of Packaging Guidelines.
>OK
>
>      - MUST: If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present.
>OK
>
>      - MUST: Packages must not own files or directories already owned by other packages. The rule of thumb here is that the first package to be installed should own the files or directories that other packages may rely upon. This means, for example, that no package in Fedora should ever share ownership with any of the files or directories owned by the filesystem or man package. If you feel that you have a good reason to own a file or directory that another package owns, then please present that at package review time.
>OK
>
></div></body></html>

<html xmlns:tomboy="http://beatniksoftware.com/tomboy" xmlns:link="http://beatniksoftware.com/tomboy/link" xmlns:size="http://beatniksoftware.com/tomboy/size"><head><META http-equiv="Content-Type" content="text/html; charset=utf-8"><title>python-spambayes review</title><style type="text/css">
        
	body {  }
	h1 { font-size: xx-large;
     	     font-weight: bold;
     	     color: red;
     	     text-decoration: underline; }
	div.note { overflow: auto;
		   position: relative;
		   border: 1px solid black;
		   display: block;
		   padding: 5pt;
		   margin: 5pt; 
		   white-space: -moz-pre-wrap; /* Mozilla */
 	      	   white-space: -pre-wrap;     /* Opera 4 - 6 */
 	      	   white-space: -o-pre-wrap;   /* Opera 7 */
 	      	   white-space: pre-wrap;      /* CSS3 */
 	      	   word-wrap: break-word;      /* IE 5.5+ */ }
	</style></head><body><div class="note" id="python-spambayes review" style="width:712;"><a name="#python-spambayes review"></a><h1>python-spambayes review</h1>
MUST Items:

    *

      - MUST: rpmlint must be run on every package. The output should be posted in the review.
OK

      - MUST: The package must be named according to the Package Naming Guidelines.
OK

      - MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption on Package Naming Guidelines.
OK

      - MUST: The package must meet the Packaging Guidelines.


      - MUST: The package must be licensed with an open-source compatible license and meet other legal requirements as defined in the legal section of Packaging Guidelines.
OK

      - MUST: The License field in the package spec file must match the actual license.
OK

      - MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc.
OK

      - MUST: The spec file must be written in American English.
OK

      - MUST: The spec file for the package MUST be legible. If the reviewer is unable to read the spec file, it will be impossible to perform a review. Fedora is not the place for entries into the Obfuscated Code Contest (<a href="http://www.ioccc.org/">http://www.ioccc.org/</a>).
OK

      - MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use md5sum for this task. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this.
OK

      - MUST: The package must successfully compile and build into binary rpms on at least one supported architecture.
OK. Tested on i386 and x86_64



      - MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines; inclusion of those as BuildRequires is optional. Apply common sense.
OK


      - MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review, along with the rationalization for relocation of that specific package. Without this, use of Prefix: /usr is considered a blocker.
OK

      - MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. The exception to this are directories listed explicitly in the Filesystem Hierarchy Standard (<a href="http://www.pathname.com/fhs/pub/fhs-2.3.html">http://www.pathname.com/fhs/pub/fhs-2.3.html</a>), as it is safe to assume that those directories exist.
OK

      - MUST: A package must not contain any duplicate files in the %files listing.
OK

      - MUST: Permissions on files must be set properly. Executables should be set with executable permissions, for example. Every %files section must include a %defattr(...) line.
OK

      - MUST: Each package must have a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT).
OK

      - MUST: Each package must consistently use macros, as described in the macros section of Packaging Guidelines.
OK

      - MUST: The package must contain code, or permissable content. This is described in detail in the code vs. content section of Packaging Guidelines.
OK

      - MUST: If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present.
OK

      - MUST: Packages must not own files or directories already owned by other packages. The rule of thumb here is that the first package to be installed should own the files or directories that other packages may rely upon. This means, for example, that no package in Fedora should ever share ownership with any of the files or directories owned by the filesystem or man package. If you feel that you have a good reason to own a file or directory that another package owns, then please present that at package review time.
OK

</div></body></html>

Actions: View

Attachments on bug 234717: 153445