Attachment 153918 Details for Bug 238664 – patch to allow faxing with low supplies

patch to allow faxing with low supplies

faxing-with-low-supplies.patch (text/plain), 1.57 KB, created by Bernard Johnson on 2007-05-02 05:59:43 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Bernard Johnson

Created: 2007-05-02 05:59:43 UTC

Size: 1.57 KB

patch

obsolete

>When sending a fax using hplip, having low paper or low toner should not really
>be considered an error since they are not used when faxing.
>
>Unfortunately, because of the organization of error codes, there is no non-
>'hackish' way to fix this with the current codebase.
>
>--- /usr/share/hplip/sendfax.orig	2007-04-16 03:35:19.000000000 -0600
>+++ /usr/share/hplip/sendfax	2007-05-01 23:34:28.000000000 -0600
>@@ -654,7 +654,7 @@
>             log.error("Query device error (%s)." % e.msg)
>             dev.error_state = ERROR_STATE_ERROR
> 
>-        if dev.error_state > ERROR_STATE_MAX_OK:
>+        if dev.error_state > ERROR_STATE_MAX_OK and dev.error_state != ERROR_STATE_LOW_SUPPLIES and dev.error_state != ERROR_STATE_LOW_PAPER:
>             log.error("Device is busy or in an error state (code=%d). Please wait for the device to become idle or clear the error and try again." % dev.error_state)
>             sys.exit(1)
>             
>--- /usr/share/hplip/ui/faxsendjobform.py.orig	2007-04-16 03:35:21.000000000 -0600
>+++ /usr/share/hplip/ui/faxsendjobform.py	2007-05-01 23:46:20.000000000 -0600
>@@ -544,7 +544,7 @@
>             QApplication.restoreOverrideCursor()
> 
> 
>-        if self.dev.error_state > ERROR_STATE_MAX_OK:
>+        if self.dev.error_state > ERROR_STATE_MAX_OK and self.dev.error_state != ERROR_STATE_LOW_SUPPLIES and self.dev.error_state != ERROR_STATE_LOW_PAPER:
>             self.FailureUI(self.__tr("<b>Device is busy or in an error state (code=%1)</b><p>Please wait for the device to become idle or clear the error and try again.").arg(self.dev.status_code))
>             return
>

Actions: View

Attachments on bug 238664: 153918