Login
[x]
Log in using an account from:
Fedora Account System
Red Hat Associate
Red Hat Customer
Or login using a Red Hat Bugzilla account
Forgot Password
Login:
Hide Forgot
Create an Account
Red Hat Bugzilla – Attachment 154141 Details for
Bug 239050
DRM module compile fails with vm_insert_pfn names conflict
[?]
New
Simple Search
Advanced Search
My Links
Browse
Requests
Reports
Current State
Search
Tabular reports
Graphical reports
Duplicates
Other Reports
User Changes
Plotly Reports
Bug Status
Bug Severity
Non-Defaults
|
Product Dashboard
Help
Page Help!
Bug Writing Guidelines
What's new
Browser Support Policy
5.0.4.rh83 Release notes
FAQ
Guides index
User guide
Web Services
Contact
Legal
This site requires JavaScript to be enabled to function correctly, please enable it.
freedesktop.org DRM won't compile bug report
drm_bug.cgi.html (text/html), 30.04 KB, created by
Calin Brabandt
on 2007-05-04 17:04:09 UTC
(
hide
)
Description:
freedesktop.org DRM won't compile bug report
Filename:
MIME Type:
Creator:
Calin Brabandt
Created:
2007-05-04 17:04:09 UTC
Size:
30.04 KB
patch
obsolete
><!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd"> ><html><head><title>Bug 10576 - drm modules won't compile with 2.6.21-rc6 (vm_insert_pfn names clash)</title> > > > > > ><link rel="Top" href="http://bugs.freedesktop.org/"> > > > > > > <link rel="Show" title="Dependency Tree" href="http://bugs.freedesktop.org/showdependencytree.cgi?id=10576"> > <link rel="Show" title="Dependency Graph" href="http://bugs.freedesktop.org/showdependencygraph.cgi?id=10576"> > > > <link rel="Show" title="Bug Activity" href="http://bugs.freedesktop.org/show_activity.cgi?id=10576"> > <link rel="Show" title="Printer-Friendly Version" href="http://bugs.freedesktop.org/show_bug.cgi?format=multiple&id=10576"> > > > > <script type="text/javascript"> > <!-- > > function initHelp() {} > // --> > </script> > > <link href="drm_bug_files/global.css" rel="stylesheet" type="text/css"> > <link href="drm_bug_files/global_002.css" rel="stylesheet" type="text/css"></head><body onload="" class="bugs-freedesktop-org bz_bug bz_status_RESOLVED bz_component_DRM_modules bz_bug_10576"> > > ><div id="banner"> > <div class="intro"></div> > <p id="banner-name"> > <span>This is Bugzilla</span> > </p> > <p id="banner-version"> > <a href="http://www.bugzilla.org/"><span>Bugzilla</span></a> > <span>Version 2.22.1</span> > </p> > <div class="outro"></div> > </div> > ><div id="header"> > <h1>Bugzilla Bug 10576</h1> > > <h2>drm modules won't compile with 2.6.21-rc6 (vm_insert_pfn names clash)</h2> > > <h3>Last modified: 2007-04-28 18:00:13 PST</h3> ></div> > ><i><font color="#777777">First</font></i> > <i><font color="#777777">Last</font></i> > <i><font color="#777777">Prev</font></i> > <i><font color="#777777">Next</font></i> > > <i><font color="#777777">No search results available</font></i> > > <a href="http://bugs.freedesktop.org/query.cgi">Search page</a> > <a href="http://bugs.freedesktop.org/enter_bug.cgi">Enter new bug</a> > ><hr> ><script type="text/javascript"> > <!-- > > /* Outputs a link to call replyToComment(); used to reduce HTML output */ > function addReplyLink(id) { > /* XXX this should really be updated to use the DOM Core's > * createElement, but finding a container isn't trivial. > */ > document.write('[<a href="#add_comment" onclick="replyToComment(' + > id + ');">reply<' + '/a>]'); > } > > /* Adds the reply text to the `comment' textarea */ > function replyToComment(id) { > /* pre id="comment_name_N" */ > var text_elem = document.getElementById('comment_text_'+id); > var text = getText(text_elem); > > /* make sure we split on all newlines -- IE or Moz use \r and \n > * respectively. > */ > text = text.split(/\r|\n/); > > var replytext = ""; > for (var i=0; i < text.length; i++) { > replytext += "> " + text[i] + "\n"; > } > > replytext = "(In reply to comment #" + id + ")\n" + replytext + "\n"; > > > /* <textarea id="comment"> */ > var textarea = document.getElementById('comment'); > textarea.value += replytext; > > textarea.focus(); > } > > if (typeof Node == 'undefined') { > /* MSIE doesn't define Node, so provide a compatibility object */ > window.Node = { > TEXT_NODE: 3, > ENTITY_REFERENCE_NODE: 5 > }; > } > > /* Concatenates all text from element's childNodes. This is used > * instead of innerHTML because we want the actual text (and > * innerText is non-standard). > */ > function getText(element) { > var child, text = ""; > for (var i=0; i < element.childNodes.length; i++) { > child = element.childNodes[i]; > var type = child.nodeType; > if (type == Node.TEXT_NODE || type == Node.ENTITY_REFERENCE_NODE) { > text += child.nodeValue; > } else { > /* recurse into nodes of other types */ > text += getText(child); > } > } > return text; > } > > > function updateCommentTagControl(checkbox, form) { > if (checkbox.checked) { > form.comment.className='bz_private'; > } else { > form.comment.className=''; > } > } > > //--> > </script> > ><form name="changeform" method="post" action="process_bug.cgi"> > > <input name="delta_ts" value="2007-04-28 18:00:13" type="hidden"> > <input name="longdesclength" value="6" type="hidden"> > <input name="id" value="10576" type="hidden"> > > > > <table> > > <tbody><tr> > <td valign="top"> > <table cellpadding="1" cellspacing="1"> > <tbody><tr> > <td align="right"> > <b>Bug#:</b> > </td> > <td> > <a href="http://bugs.freedesktop.org/show_bug.cgi?id=10576">10576</a> > </td> > </tr> > > <tr> > <td align="right"> > <b>Alias:</b> > </td> > <td> > <label for="alias" title="a name for the bug that can be used in place of its ID number, f.e. when adding it to a list of dependencies"> > <input id="alias" name="alias" value="" size="20" maxlength="20"> > </label> > </td> > </tr> > > <tr> > <td align="right"> > <b><u>P</u>roduct:</b> > </td><td> > <label for="product" accesskey="p"> > <select name="product" id="product"> > <option value="burn">burn > </option> > <option value="cairo">cairo > </option> > <option value="cairo-java">cairo-java > </option> > <option value="cairomm">cairomm > </option> > <option value="create">create > </option> > <option value="dbus">dbus > </option> > <option value="DejaVu">DejaVu > </option> > <option value="desktop-file-utils">desktop-file-utils > </option> > <option value="DRI" selected="selected">DRI > </option> > <option value="Farsight">Farsight > </option> > <option value="fontconfig">fontconfig > </option> > <option value="freedesktop.org">freedesktop.org > </option> > <option value="freedrtools">freedrtools > </option> > <option value="FriBidi">FriBidi > </option> > <option value="Galago">Galago > </option> > <option value="ghns">ghns > </option> > <option value="GTK-Qt Engine">GTK-Qt Engine > </option> > <option value="hal">hal > </option> > <option value="HarfBuzz">HarfBuzz > </option> > <option value="Hieroglyph">Hieroglyph > </option> > <option value="LDTP">LDTP > </option> > <option value="liboil">liboil > </option> > <option value="libopenraw">libopenraw > </option> > <option value="libpixman">libpixman > </option> > <option value="LTSP">LTSP > </option> > <option value="Mesa">Mesa > </option> > <option value="nice">nice > </option> > <option value="nickle">nickle > </option> > <option value="openclipart.org">openclipart.org > </option> > <option value="openfontlibrary">openfontlibrary > </option> > <option value="pkg-config">pkg-config > </option> > <option value="pm-utils">pm-utils > </option> > <option value="PolicyKit">PolicyKit > </option> > <option value="poppler">poppler > </option> > <option value="Portland">Portland > </option> > <option value="pycairo">pycairo > </option> > <option value="PyXDG">PyXDG > </option> > <option value="scim">scim > </option> > <option value="shared-mime-info">shared-mime-info > </option> > <option value="Spam">Spam > </option> > <option value="Specifications">Specifications > </option> > <option value="STSF">STSF > </option> > <option value="swfdec">swfdec > </option> > <option value="tango">tango > </option> > <option value="Telepathy">Telepathy > </option> > <option value="tinderbox">tinderbox > </option> > <option value="UIM">UIM > </option> > <option value="XCB">XCB > </option> > <option value="xdgmime">xdgmime > </option> > <option value="xkeyboard-config">xkeyboard-config > </option> > <option value="xorg">xorg > </option> > <option value="xprint">xprint > </option> > <option value="XStandards">XStandards > </option> > <option value="Xtests">Xtests > </option> > </select> > </label> > </td> > </tr> > > > > <tr> > <td align="right"> > <b> > <a href="http://bugs.freedesktop.org/describecomponents.cgi?product=DRI"> > Co<u>m</u>ponent</a>: > </b> > </td><td> > <label for="component" accesskey="m"> > <select name="component" id="component"> > <option value="DRM modules" selected="selected">DRM modules > </option> > <option value="General">General > </option> > <option value="libdrm">libdrm > </option> > <option value="libGL">libGL > </option> > <option value="libglx">libglx > </option> > </select> > </label> > </td> > </tr> > > <tr> > <td align="right"> > <b> > <a href="http://bugs.freedesktop.org/page.cgi?id=fields.html#status">Status</a>: > </b> > </td> > <td>RESOLVED</td> > </tr> > > <tr> > <td align="right"> > <b> > <a href="http://bugs.freedesktop.org/page.cgi?id=fields.html#resolution">Resolution</a>: > </b> > </td> > <td>NOTABUG > </td> > </tr> > > <tr> > <td align="right"> > <b> > <a href="http://bugs.freedesktop.org/page.cgi?id=fields.html#assigned_to">Assigned To</a>: > </b> > </td> > <td>Default DRI bug account <dri-devel@lists.sourceforge.net></td> > </tr> > > </tbody></table> > > </td> > <td valign="top"> > > <table cellpadding="1" cellspacing="1"> > > <tbody><tr> > <td align="right"> > <b><u>H</u>ardware:</b> > </td><td> > <label for="rep_platform" accesskey="h"> > <select name="rep_platform" id="rep_platform"> > <option value="All" selected="selected">All > </option> > <option value="x86 (IA32)">x86 (IA32) > </option> > <option value="x86-64 (AMD64)">x86-64 (AMD64) > </option> > <option value="PowerPC">PowerPC > </option> > <option value="IA64 (Itanium)">IA64 (Itanium) > </option> > <option value="SPARC">SPARC > </option> > <option value="ARM">ARM > </option> > <option value="Alpha">Alpha > </option> > <option value="PA-RISC (HP)">PA-RISC (HP) > </option> > <option value="SGI">SGI > </option> > <option value="Other">Other > </option> > </select> > </label> > </td> > </tr> > > <tr> > <td align="right"> > <b><u>O</u>S:</b> > </td><td> > <label for="op_sys" accesskey="o"> > <select name="op_sys" id="op_sys"> > <option value="All" selected="selected">All > </option> > <option value="Linux (All)">Linux (All) > </option> > <option value="FreeBSD">FreeBSD > </option> > <option value="NetBSD">NetBSD > </option> > <option value="OpenBSD">OpenBSD > </option> > <option value="BSD (Others)">BSD (Others) > </option> > <option value="Mac OS X (All)">Mac OS X (All) > </option> > <option value="Solaris">Solaris > </option> > <option value="Windows (All)">Windows (All) > </option> > <option value="Cygwin">Cygwin > </option> > <option value="AIX">AIX > </option> > <option value="HP-UX">HP-UX > </option> > <option value="IRIX">IRIX > </option> > <option value="other">other > </option> > </select> > </label> > </td> > </tr> > > <tr> > <td align="right"> > <b>Version:</b> > </td><td> > <label for="version" accesskey="o"> > <select name="version" id="version"> > <option value="DRI CVS" selected="selected">DRI CVS > </option> > <option value="unspecified">unspecified > </option> > <option value="XFree86 4.4.0">XFree86 4.4.0 > </option> > <option value="XFree86 CVS">XFree86 CVS > </option> > <option value="XOrg 6.7.0">XOrg 6.7.0 > </option> > <option value="XOrg CVS">XOrg CVS > </option> > </select> > </label> > </td> > </tr> > > <tr> > <td align="right"> > <b><a href="http://bugs.freedesktop.org/page.cgi?id=fields.html#priority">Pr<u>i</u>ority</a>:</b> > </td><td> > <label for="priority" accesskey="i"> > <select name="priority" id="priority"> > <option value="highest" selected="selected">highest > </option> > <option value="high">high > </option> > <option value="medium">medium > </option> > <option value="low">low > </option> > <option value="lowest">lowest > </option> > </select> > </label> > </td> > </tr> > > <tr> > <td align="right"> > <b><a href="http://bugs.freedesktop.org/page.cgi?id=fields.html#bug_severity">Severity</a>:</b> > </td><td> > <label for="bug_severity" accesskey="i"> > <select name="bug_severity" id="bug_severity"> > <option value="blocker">blocker > </option> > <option value="critical">critical > </option> > <option value="major">major > </option> > <option value="normal" selected="selected">normal > </option> > <option value="minor">minor > </option> > <option value="trivial">trivial > </option> > <option value="enhancement">enhancement > </option> > </select> > </label> > </td> > </tr> > > > </tbody></table> > </td> > > <td valign="top"> > > <table cellpadding="1" cellspacing="1"> > > <tbody><tr> > <td align="right"> > <b>Reporter:</b> > </td> > <td> > <a href="mailto:michalsznajder@gmail.com">MichaÅ Sznajder <michalsznajder@gmail.com></a> > </td> > </tr> > > <tr> > <td align="right" valign="top"> > <b><u>A</u>dd CC:</b> > </td> > <td><input name="newcc" value="" accesskey="a" size="30"> > </td> > </tr> > > <tr> > <td align="right" valign="top"> > <b>CC:</b> > </td> > <td valign="top"> > <select name="cc" multiple="multiple" size="5"> > <option value="chris-fdbugs@printf.net">chris-fdbugs@printf.net</option> > <option value="michalsznajder@gmail.com">michalsznajder@gmail.com</option> > </select> > <br> > <input name="removecc" type="checkbox">Remove selected CCs > <br> > </td> > </tr> > > </tbody></table> > > </td> > </tr> > > <tr> > <td colspan="2"> > <table cellpadding="1" cellspacing="1"> > > > > <tbody><tr> > <td align="right"> > <b><u>Q</u>A Contact:</b> > </td> > <td colspan="7"><input name="qa_contact" value="" accesskey="q" size="60"> > </td> > </tr> > > <tr> > <td align="right"> > <b> > <u>U</u>RL: > </b> > </td> > <td colspan="5"> > <input name="bug_file_loc" accesskey="u" value="" size="60"> > </td> > </tr> > > <tr> > <td align="right"> > <b><u>S</u>ummary:</b> > </td> > <td colspan="5"> > <input name="short_desc" accesskey="s" value="drm modules won't compile with 2.6.21-rc6 (vm_insert_pfn names clash)" size="60"> > </td> > </tr> > > <tr> > <td align="right"> > <b>Status <u>W</u>hiteboard:</b> > </td> > <td colspan="5"> > <input name="status_whiteboard" accesskey="w" value="" size="60"> > </td> > </tr> > > <tr> > <td align="right"> > <b> > <a href="http://bugs.freedesktop.org/describekeywords.cgi"><u>K</u>eywords</a>: > </b> > </td><td colspan="5"> > <input name="keywords" accesskey="k" value="" size="60"> > </td> > </tr> > > </tbody></table> > </td> > > <td valign="top"> > <table cellpadding="1" cellspacing="1"> > <tbody><tr> > <td colspan="2" valign="top"> > </td> > </tr> > </tbody></table> > </td> > </tr> > </tbody></table> > > > ><br> ><table border="1" cellpadding="4" cellspacing="0"> > <tbody><tr> > <th align="left" bgcolor="#cccccc">Attachment</th> > <th align="left" bgcolor="#cccccc">Type</th> > <th align="left" bgcolor="#cccccc">Creator</th> > <th align="left" bgcolor="#cccccc">Created</th> > <th align="left" bgcolor="#cccccc">Size</th> > <th align="left" bgcolor="#cccccc">Flags</th> > <th align="left" bgcolor="#cccccc">Actions</th> > </tr> > > <tr> > <td colspan="6"> > <a href="http://bugs.freedesktop.org/attachment.cgi?bugid=10576&action=enter">Create a New Attachment</a> (proposed patch, testcase, etc.) > </td> > <td class="bz_disabled"> > View All > </td> > </tr> ></tbody></table> ><br> > > > > <table> > <tbody><tr><th align="right">Bug 10576 depends on:</th> > <td> > </td> > <td> > <input name="dependson" accesskey="i" value=""> > </td> > <td rowspan="2"> > <a href="http://bugs.freedesktop.org/showdependencytree.cgi?id=10576">Show > dependency tree</a> > > <br> > <a href="http://bugs.freedesktop.org/showdependencygraph.cgi?id=10576">Show > dependency graph</a> > </td> > </tr> > > <tr><th align="right">Bug 10576 <u>b</u>locks:</th> > <td> > </td> > <td> > <input name="blocked" accesskey="b" value=""> > </td> > </tr> > </tbody></table> > > > > > <br> > <b>Additional <u>C</u>omments:</b> > <br> > <a name="add_comment"></a> > <textarea name="comment" id="comment" rows="10" cols="80" accesskey="c"></textarea> > > <br> > <label for="addselfcc"> > <input id="addselfcc" name="addselfcc" type="checkbox"> > Add to CC list > </label> > <br> > ><br> > <input id="knob-leave" name="knob" value="none" checked="checked" type="radio"> > <label for="knob-leave"> > Leave as <b>RESOLVED NOTABUG</b> > </label> > <br> > > > > > > <input id="knob-reopen" name="knob" value="reopen" type="radio"> > <label for="knob-reopen"> > Reopen bug > </label> > <br> > <input id="knob-verify" name="knob" value="verify" type="radio"> > <label for="knob-verify"> > Mark bug as <b>VERIFIED</b> > </label> > <br> > <input id="knob-close" name="knob" value="close" type="radio"> > <label for="knob-close"> > Mark bug as <b>CLOSED</b> > </label> > <br> > > <input value="Commit" type="submit"> > <input name="form_name" value="process_bug" type="hidden"> > <p> > <font size="+1"> > <b> > <a href="http://bugs.freedesktop.org/show_activity.cgi?id=10576">View Bug Activity</a> > | > <a href="http://bugs.freedesktop.org/show_bug.cgi?format=multiple&id=10576">Format For Printing</a> > | > <a href="http://bugs.freedesktop.org/show_bug.cgi?ctype=xml&id=10576">XML</a> > | > <a href="http://bugs.freedesktop.org/enter_bug.cgi?cloned_bug_id=10576">Clone This Bug</a> > > > </b> > </font> > > </p> > > > ><hr> ><script type="text/javascript"> > <!-- > function updateCommentPrivacy(checkbox, id) { > var text_elem = document.getElementById('comment_text_'+id); > if (checkbox.checked) { > text_elem.parentNode.className='bz_private'; > } else { > text_elem.parentNode.className=''; > } > } > //--> > </script> > > > > > > > > ><div> > <table> > <tbody><tr> > <td align="left"> > <b><a name="c0" href="http://bugs.freedesktop.org/show_bug.cgi?id=10576#c0"> > Description</a>:</b> <script type="text/javascript"><!-- > addReplyLink(0); > //--></script>[<a href="#add_comment" onclick="replyToComment(0);">reply</a>] > </td> > <td align="left" width="30%"> > <b>Opened:</b> 2007-04-09 10:18 PST > </td> > </tr> > </tbody></table> > > > ><pre id="comment_text_0">It looks like that latest (as of writing <a href="mailto:2.6.21-rc6@kernel.org">2.6.21-rc6@kernel.org</a>) kernel contains >function named vm_insert_pfn in /mm/memory.c and /mm/mm.h (see ><a href="http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=e0dc0d8f4a327d033bfb63d43f113d5f31d11b3c">http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=e0dc0d8f4a327d033bfb63d43f113d5f31d11b3c</a> > for specific check-in). Unfortunately vm_insert_pfn is also used in >drm_compat.c thus resulting in naming clash. At a first glance they both differ >in code very much. > >The result of make is >/home/michal/nouveau/drm/linux-core/drm_compat.c:190: error: static declaration >of âvm_insert_pfnâ follows non-static declaration >include/linux/mm.h:1126: error: previous declaration of âvm_insert_pfnâ was >here > >The bug was found on Ubuntu Feisty with latest kernel packages installed (which >apparently is 2.6.20. uname -r gives 2.6.20-14-generic) 2.6.20 from gentoo does >not have this problem. ></pre> > </div> > <div> > <br> > <span class="bz_comment"> > ------- <i>Comment > <a name="c1" href="http://bugs.freedesktop.org/show_bug.cgi?id=10576#c1"> > #1</a> From > <a href="mailto:michalsznajder@gmail.com">MichaÅ Sznajder</a> > 2007-04-09 11:09:36 PST > </i> > <script type="text/javascript"><!-- > addReplyLink(1); //--></script>[<a href="#add_comment" onclick="replyToComment(1);">reply</a>] > ------- > </span> > > > ><pre id="comment_text_1">Links to drm and kernels git's that have introduced incompatibility: > ><a href="http://gitweb.freedesktop.org/?p=mesa/drm.git;a=commitdiff;h=f2db76e2f206d2017f710eaddc4b33add4498898">http://gitweb.freedesktop.org/?p=mesa/drm.git;a=commitdiff;h=f2db76e2f206d2017f710eaddc4b33add4498898</a> > ><a href="http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=e0dc0d8f4a327d033bfb63d43f113d5f31d11b3c">http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=e0dc0d8f4a327d033bfb63d43f113d5f31d11b3c</a> > >Someone has to change the name but who? ></pre> > </div> > <div> > <br> > <span class="bz_comment"> > ------- <i>Comment > <a name="c2" href="http://bugs.freedesktop.org/show_bug.cgi?id=10576#c2"> > #2</a> From > <a href="mailto:thomas@tungstengraphics.com">Thomas Hellstr�m</a> > 2007-04-09 11:27:28 PST > </i> > <script type="text/javascript"><!-- > addReplyLink(2); //--></script>[<a href="#add_comment" onclick="replyToComment(2);">reply</a>] > ------- > </span> > > > ><pre id="comment_text_2">(In reply to <a href="http://bugs.freedesktop.org/show_bug.cgi?id=10576#c1">comment #1</a>) >> Links to drm and kernels git's that have introduced incompatibility: >> >> <a href="http://gitweb.freedesktop.org/?p=mesa/drm.git;a=commitdiff;h=f2db76e2f206d2017f710eaddc4b33add4498898">http://gitweb.freedesktop.org/?p=mesa/drm.git;a=commitdiff;h=f2db76e2f206d2017f710eaddc4b33add4498898</a> >> >> <a href="http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=e0dc0d8f4a327d033bfb63d43f113d5f31d11b3c">http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=e0dc0d8f4a327d033bfb63d43f113d5f31d11b3c</a> >> >> Someone has to change the name but who? >> > >vm_insert_pfn first appears in the kernel in the 2.6.21-rc series. >In drm_compat.c it is not included if the kernel version >= 2.6.21, when the >symbol DRM_FULL_MM_COMPAT is defined. > >The semantics of the two functions, although they are looking very different >are the same. The one in the mainstream kernel should be used if there is a >clash. > >I'm not sure why it appears in Ubuntu 2.6.20. I think you need to ask the >Ubuntu guys. > >/Thomas > > ></pre> > </div> > <div> > <br> > <span class="bz_comment"> > ------- <i>Comment > <a name="c3" href="http://bugs.freedesktop.org/show_bug.cgi?id=10576#c3"> > #3</a> From > <a href="mailto:chris-fdbugs@printf.net">Chris Ball</a> > 2007-04-27 15:34:47 PST > </i> > <script type="text/javascript"><!-- > addReplyLink(3); //--></script>[<a href="#add_comment" onclick="replyToComment(3);">reply</a>] > ------- > </span> > > > ><pre id="comment_text_3">(In reply to <a href="http://bugs.freedesktop.org/show_bug.cgi?id=10576#c2">comment #2</a>) >> I'm not sure why it appears in Ubuntu 2.6.20. I think you need to ask the >> Ubuntu guys. > >It's hardly uncommon for a distro to choose a kernel (2.6.20), and then pull >selectively from patches intended for a newer release without updating their >kernel version to describe itself as that newer release (which it isn't). > >What would you have the Ubuntu maintainers do instead? ></pre> > </div> > <div> > <br> > <span class="bz_comment"> > ------- <i>Comment > <a name="c4" href="http://bugs.freedesktop.org/show_bug.cgi?id=10576#c4"> > #4</a> From > <a href="mailto:thomas@tungstengraphics.com">Thomas Hellstr�m</a> > 2007-04-28 13:50:17 PST > </i> > <script type="text/javascript"><!-- > addReplyLink(4); //--></script>[<a href="#add_comment" onclick="replyToComment(4);">reply</a>] > ------- > </span> > > > ><pre id="comment_text_4">(In reply to <a href="http://bugs.freedesktop.org/show_bug.cgi?id=10576#c3">comment #3</a>) >> (In reply to <a href="http://bugs.freedesktop.org/show_bug.cgi?id=10576#c2">comment #2</a>) >> > I'm not sure why it appears in Ubuntu 2.6.20. I think you need to ask the >> > Ubuntu guys. >> It's hardly uncommon for a distro to choose a kernel (2.6.20), and then pull >> selectively from patches intended for a newer release without updating their >> kernel version to describe itself as that newer release (which it isn't). >> What would you have the Ubuntu maintainers do instead? > >Actually I think that's fine. I cant really figure out why they would want to >pull vm_insert_pfn, since AFAICT it is only used by DRM and cell, but anyway >they are free to do what they want. > >The more important question raised here is what are the DRM developers expected >to do about this? Should we maintain compatibility with all more or less >selectively patched kernels from all distros? > >Thomas ></pre> > </div> > <div> > <br> > <span class="bz_comment"> > ------- <i>Comment > <a name="c5" href="http://bugs.freedesktop.org/show_bug.cgi?id=10576#c5"> > #5</a> From > <a href="mailto:airlied@freedesktop.org">Dave Airlie</a> > 2007-04-28 18:00:13 PST > </i> > <script type="text/javascript"><!-- > addReplyLink(5); //--></script>[<a href="#add_comment" onclick="replyToComment(5);">reply</a>] > ------- > </span> > > > ><pre id="comment_text_5">We used to do this, but it takes a fair bit of effort... and I really couldn't >be bothered, I run ubuntu here and I just ifdef around it rather than try to >figure out what they did to their kernel.. ></pre> > </div> > ></form> > ><hr> ><i><font color="#777777">First</font></i> > <i><font color="#777777">Last</font></i> > <i><font color="#777777">Prev</font></i> > <i><font color="#777777">Next</font></i> > > <i><font color="#777777">No search results available</font></i> > > <a href="http://bugs.freedesktop.org/query.cgi">Search page</a> > <a href="http://bugs.freedesktop.org/enter_bug.cgi">Enter new bug</a> > ><br> ><div id="footer"> > <div class="intro"></div> > > > > ><div id="useful-links"> > <div id="links-actions"> > <div class="label">Actions:</div> > <div class="links"> > <a href="http://bugs.freedesktop.org/">Home</a> | > <a href="http://bugs.freedesktop.org/enter_bug.cgi">New</a> | > <a href="http://bugs.freedesktop.org/query.cgi">Search</a> | > > <form action="buglist.cgi" method="get" onsubmit="if (this.quicksearch.value == '') > { alert('Please enter one or more search terms first.'); > return false; } return true;"> > <input class="txt" name="quicksearch" type="text"> > <input class="btn" value="Find" type="submit"> > </form> | > > <a href="http://bugs.freedesktop.org/report.cgi">Reports</a> > > | <a href="http://bugs.freedesktop.org/request.cgi">Requests</a> > > > | <a href="http://bugs.freedesktop.org/createaccount.cgi">New Account</a> > | <a href="http://bugs.freedesktop.org/index.cgi?GoAheadAndLogIn=1">Log In</a> > </div> > </div> > > > > > > <div id="links-saved"> > <div class="label"> > </div> > <div class="links"> > > </div> > </div> > > > > > ></div> > > <div class="outro"></div> ></div> > ></body></html>
<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd"> <html><head><title>Bug 10576 - drm modules won't compile with 2.6.21-rc6 (vm_insert_pfn names clash)</title> <link rel="Top" href="http://bugs.freedesktop.org/"> <link rel="Show" title="Dependency Tree" href="http://bugs.freedesktop.org/showdependencytree.cgi?id=10576"> <link rel="Show" title="Dependency Graph" href="http://bugs.freedesktop.org/showdependencygraph.cgi?id=10576"> <link rel="Show" title="Bug Activity" href="http://bugs.freedesktop.org/show_activity.cgi?id=10576"> <link rel="Show" title="Printer-Friendly Version" href="http://bugs.freedesktop.org/show_bug.cgi?format=multiple&id=10576"> <script type="text/javascript"> <!-- function initHelp() {} // --> </script> <link href="drm_bug_files/global.css" rel="stylesheet" type="text/css"> <link href="drm_bug_files/global_002.css" rel="stylesheet" type="text/css"></head><body onload="" class="bugs-freedesktop-org bz_bug bz_status_RESOLVED bz_component_DRM_modules bz_bug_10576"> <div id="banner"> <div class="intro"></div> <p id="banner-name"> <span>This is Bugzilla</span> </p> <p id="banner-version"> <a href="http://www.bugzilla.org/"><span>Bugzilla</span></a> <span>Version 2.22.1</span> </p> <div class="outro"></div> </div> <div id="header"> <h1>Bugzilla Bug 10576</h1> <h2>drm modules won't compile with 2.6.21-rc6 (vm_insert_pfn names clash)</h2> <h3>Last modified: 2007-04-28 18:00:13 PST</h3> </div> <i><font color="#777777">First</font></i> <i><font color="#777777">Last</font></i> <i><font color="#777777">Prev</font></i> <i><font color="#777777">Next</font></i> <i><font color="#777777">No search results available</font></i> <a href="http://bugs.freedesktop.org/query.cgi">Search page</a> <a href="http://bugs.freedesktop.org/enter_bug.cgi">Enter new bug</a> <hr> <script type="text/javascript"> <!-- /* Outputs a link to call replyToComment(); used to reduce HTML output */ function addReplyLink(id) { /* XXX this should really be updated to use the DOM Core's * createElement, but finding a container isn't trivial. */ document.write('[<a href="#add_comment" onclick="replyToComment(' + id + ');">reply<' + '/a>]'); } /* Adds the reply text to the `comment' textarea */ function replyToComment(id) { /* pre id="comment_name_N" */ var text_elem = document.getElementById('comment_text_'+id); var text = getText(text_elem); /* make sure we split on all newlines -- IE or Moz use \r and \n * respectively. */ text = text.split(/\r|\n/); var replytext = ""; for (var i=0; i < text.length; i++) { replytext += "> " + text[i] + "\n"; } replytext = "(In reply to comment #" + id + ")\n" + replytext + "\n"; /* <textarea id="comment"> */ var textarea = document.getElementById('comment'); textarea.value += replytext; textarea.focus(); } if (typeof Node == 'undefined') { /* MSIE doesn't define Node, so provide a compatibility object */ window.Node = { TEXT_NODE: 3, ENTITY_REFERENCE_NODE: 5 }; } /* Concatenates all text from element's childNodes. This is used * instead of innerHTML because we want the actual text (and * innerText is non-standard). */ function getText(element) { var child, text = ""; for (var i=0; i < element.childNodes.length; i++) { child = element.childNodes[i]; var type = child.nodeType; if (type == Node.TEXT_NODE || type == Node.ENTITY_REFERENCE_NODE) { text += child.nodeValue; } else { /* recurse into nodes of other types */ text += getText(child); } } return text; } function updateCommentTagControl(checkbox, form) { if (checkbox.checked) { form.comment.className='bz_private'; } else { form.comment.className=''; } } //--> </script> <form name="changeform" method="post" action="process_bug.cgi"> <input name="delta_ts" value="2007-04-28 18:00:13" type="hidden"> <input name="longdesclength" value="6" type="hidden"> <input name="id" value="10576" type="hidden"> <table> <tbody><tr> <td valign="top"> <table cellpadding="1" cellspacing="1"> <tbody><tr> <td align="right"> <b>Bug#:</b> </td> <td> <a href="http://bugs.freedesktop.org/show_bug.cgi?id=10576">10576</a> </td> </tr> <tr> <td align="right"> <b>Alias:</b> </td> <td> <label for="alias" title="a name for the bug that can be used in place of its ID number, f.e. when adding it to a list of dependencies"> <input id="alias" name="alias" value="" size="20" maxlength="20"> </label> </td> </tr> <tr> <td align="right"> <b><u>P</u>roduct:</b> </td><td> <label for="product" accesskey="p"> <select name="product" id="product"> <option value="burn">burn </option> <option value="cairo">cairo </option> <option value="cairo-java">cairo-java </option> <option value="cairomm">cairomm </option> <option value="create">create </option> <option value="dbus">dbus </option> <option value="DejaVu">DejaVu </option> <option value="desktop-file-utils">desktop-file-utils </option> <option value="DRI" selected="selected">DRI </option> <option value="Farsight">Farsight </option> <option value="fontconfig">fontconfig </option> <option value="freedesktop.org">freedesktop.org </option> <option value="freedrtools">freedrtools </option> <option value="FriBidi">FriBidi </option> <option value="Galago">Galago </option> <option value="ghns">ghns </option> <option value="GTK-Qt Engine">GTK-Qt Engine </option> <option value="hal">hal </option> <option value="HarfBuzz">HarfBuzz </option> <option value="Hieroglyph">Hieroglyph </option> <option value="LDTP">LDTP </option> <option value="liboil">liboil </option> <option value="libopenraw">libopenraw </option> <option value="libpixman">libpixman </option> <option value="LTSP">LTSP </option> <option value="Mesa">Mesa </option> <option value="nice">nice </option> <option value="nickle">nickle </option> <option value="openclipart.org">openclipart.org </option> <option value="openfontlibrary">openfontlibrary </option> <option value="pkg-config">pkg-config </option> <option value="pm-utils">pm-utils </option> <option value="PolicyKit">PolicyKit </option> <option value="poppler">poppler </option> <option value="Portland">Portland </option> <option value="pycairo">pycairo </option> <option value="PyXDG">PyXDG </option> <option value="scim">scim </option> <option value="shared-mime-info">shared-mime-info </option> <option value="Spam">Spam </option> <option value="Specifications">Specifications </option> <option value="STSF">STSF </option> <option value="swfdec">swfdec </option> <option value="tango">tango </option> <option value="Telepathy">Telepathy </option> <option value="tinderbox">tinderbox </option> <option value="UIM">UIM </option> <option value="XCB">XCB </option> <option value="xdgmime">xdgmime </option> <option value="xkeyboard-config">xkeyboard-config </option> <option value="xorg">xorg </option> <option value="xprint">xprint </option> <option value="XStandards">XStandards </option> <option value="Xtests">Xtests </option> </select> </label> </td> </tr> <tr> <td align="right"> <b> <a href="http://bugs.freedesktop.org/describecomponents.cgi?product=DRI"> Co<u>m</u>ponent</a>: </b> </td><td> <label for="component" accesskey="m"> <select name="component" id="component"> <option value="DRM modules" selected="selected">DRM modules </option> <option value="General">General </option> <option value="libdrm">libdrm </option> <option value="libGL">libGL </option> <option value="libglx">libglx </option> </select> </label> </td> </tr> <tr> <td align="right"> <b> <a href="http://bugs.freedesktop.org/page.cgi?id=fields.html#status">Status</a>: </b> </td> <td>RESOLVED</td> </tr> <tr> <td align="right"> <b> <a href="http://bugs.freedesktop.org/page.cgi?id=fields.html#resolution">Resolution</a>: </b> </td> <td>NOTABUG </td> </tr> <tr> <td align="right"> <b> <a href="http://bugs.freedesktop.org/page.cgi?id=fields.html#assigned_to">Assigned To</a>: </b> </td> <td>Default DRI bug account <dri-devel@lists.sourceforge.net></td> </tr> </tbody></table> </td> <td valign="top"> <table cellpadding="1" cellspacing="1"> <tbody><tr> <td align="right"> <b><u>H</u>ardware:</b> </td><td> <label for="rep_platform" accesskey="h"> <select name="rep_platform" id="rep_platform"> <option value="All" selected="selected">All </option> <option value="x86 (IA32)">x86 (IA32) </option> <option value="x86-64 (AMD64)">x86-64 (AMD64) </option> <option value="PowerPC">PowerPC </option> <option value="IA64 (Itanium)">IA64 (Itanium) </option> <option value="SPARC">SPARC </option> <option value="ARM">ARM </option> <option value="Alpha">Alpha </option> <option value="PA-RISC (HP)">PA-RISC (HP) </option> <option value="SGI">SGI </option> <option value="Other">Other </option> </select> </label> </td> </tr> <tr> <td align="right"> <b><u>O</u>S:</b> </td><td> <label for="op_sys" accesskey="o"> <select name="op_sys" id="op_sys"> <option value="All" selected="selected">All </option> <option value="Linux (All)">Linux (All) </option> <option value="FreeBSD">FreeBSD </option> <option value="NetBSD">NetBSD </option> <option value="OpenBSD">OpenBSD </option> <option value="BSD (Others)">BSD (Others) </option> <option value="Mac OS X (All)">Mac OS X (All) </option> <option value="Solaris">Solaris </option> <option value="Windows (All)">Windows (All) </option> <option value="Cygwin">Cygwin </option> <option value="AIX">AIX </option> <option value="HP-UX">HP-UX </option> <option value="IRIX">IRIX </option> <option value="other">other </option> </select> </label> </td> </tr> <tr> <td align="right"> <b>Version:</b> </td><td> <label for="version" accesskey="o"> <select name="version" id="version"> <option value="DRI CVS" selected="selected">DRI CVS </option> <option value="unspecified">unspecified </option> <option value="XFree86 4.4.0">XFree86 4.4.0 </option> <option value="XFree86 CVS">XFree86 CVS </option> <option value="XOrg 6.7.0">XOrg 6.7.0 </option> <option value="XOrg CVS">XOrg CVS </option> </select> </label> </td> </tr> <tr> <td align="right"> <b><a href="http://bugs.freedesktop.org/page.cgi?id=fields.html#priority">Pr<u>i</u>ority</a>:</b> </td><td> <label for="priority" accesskey="i"> <select name="priority" id="priority"> <option value="highest" selected="selected">highest </option> <option value="high">high </option> <option value="medium">medium </option> <option value="low">low </option> <option value="lowest">lowest </option> </select> </label> </td> </tr> <tr> <td align="right"> <b><a href="http://bugs.freedesktop.org/page.cgi?id=fields.html#bug_severity">Severity</a>:</b> </td><td> <label for="bug_severity" accesskey="i"> <select name="bug_severity" id="bug_severity"> <option value="blocker">blocker </option> <option value="critical">critical </option> <option value="major">major </option> <option value="normal" selected="selected">normal </option> <option value="minor">minor </option> <option value="trivial">trivial </option> <option value="enhancement">enhancement </option> </select> </label> </td> </tr> </tbody></table> </td> <td valign="top"> <table cellpadding="1" cellspacing="1"> <tbody><tr> <td align="right"> <b>Reporter:</b> </td> <td> <a href="mailto:michalsznajder@gmail.com">MichaÅ Sznajder <michalsznajder@gmail.com></a> </td> </tr> <tr> <td align="right" valign="top"> <b><u>A</u>dd CC:</b> </td> <td><input name="newcc" value="" accesskey="a" size="30"> </td> </tr> <tr> <td align="right" valign="top"> <b>CC:</b> </td> <td valign="top"> <select name="cc" multiple="multiple" size="5"> <option value="chris-fdbugs@printf.net">chris-fdbugs@printf.net</option> <option value="michalsznajder@gmail.com">michalsznajder@gmail.com</option> </select> <br> <input name="removecc" type="checkbox">Remove selected CCs <br> </td> </tr> </tbody></table> </td> </tr> <tr> <td colspan="2"> <table cellpadding="1" cellspacing="1"> <tbody><tr> <td align="right"> <b><u>Q</u>A Contact:</b> </td> <td colspan="7"><input name="qa_contact" value="" accesskey="q" size="60"> </td> </tr> <tr> <td align="right"> <b> <u>U</u>RL: </b> </td> <td colspan="5"> <input name="bug_file_loc" accesskey="u" value="" size="60"> </td> </tr> <tr> <td align="right"> <b><u>S</u>ummary:</b> </td> <td colspan="5"> <input name="short_desc" accesskey="s" value="drm modules won't compile with 2.6.21-rc6 (vm_insert_pfn names clash)" size="60"> </td> </tr> <tr> <td align="right"> <b>Status <u>W</u>hiteboard:</b> </td> <td colspan="5"> <input name="status_whiteboard" accesskey="w" value="" size="60"> </td> </tr> <tr> <td align="right"> <b> <a href="http://bugs.freedesktop.org/describekeywords.cgi"><u>K</u>eywords</a>: </b> </td><td colspan="5"> <input name="keywords" accesskey="k" value="" size="60"> </td> </tr> </tbody></table> </td> <td valign="top"> <table cellpadding="1" cellspacing="1"> <tbody><tr> <td colspan="2" valign="top"> </td> </tr> </tbody></table> </td> </tr> </tbody></table> <br> <table border="1" cellpadding="4" cellspacing="0"> <tbody><tr> <th align="left" bgcolor="#cccccc">Attachment</th> <th align="left" bgcolor="#cccccc">Type</th> <th align="left" bgcolor="#cccccc">Creator</th> <th align="left" bgcolor="#cccccc">Created</th> <th align="left" bgcolor="#cccccc">Size</th> <th align="left" bgcolor="#cccccc">Flags</th> <th align="left" bgcolor="#cccccc">Actions</th> </tr> <tr> <td colspan="6"> <a href="http://bugs.freedesktop.org/attachment.cgi?bugid=10576&action=enter">Create a New Attachment</a> (proposed patch, testcase, etc.) </td> <td class="bz_disabled"> View All </td> </tr> </tbody></table> <br> <table> <tbody><tr><th align="right">Bug 10576 depends on:</th> <td> </td> <td> <input name="dependson" accesskey="i" value=""> </td> <td rowspan="2"> <a href="http://bugs.freedesktop.org/showdependencytree.cgi?id=10576">Show dependency tree</a> <br> <a href="http://bugs.freedesktop.org/showdependencygraph.cgi?id=10576">Show dependency graph</a> </td> </tr> <tr><th align="right">Bug 10576 <u>b</u>locks:</th> <td> </td> <td> <input name="blocked" accesskey="b" value=""> </td> </tr> </tbody></table> <br> <b>Additional <u>C</u>omments:</b> <br> <a name="add_comment"></a> <textarea name="comment" id="comment" rows="10" cols="80" accesskey="c"></textarea> <br> <label for="addselfcc"> <input id="addselfcc" name="addselfcc" type="checkbox"> Add to CC list </label> <br> <br> <input id="knob-leave" name="knob" value="none" checked="checked" type="radio"> <label for="knob-leave"> Leave as <b>RESOLVED NOTABUG</b> </label> <br> <input id="knob-reopen" name="knob" value="reopen" type="radio"> <label for="knob-reopen"> Reopen bug </label> <br> <input id="knob-verify" name="knob" value="verify" type="radio"> <label for="knob-verify"> Mark bug as <b>VERIFIED</b> </label> <br> <input id="knob-close" name="knob" value="close" type="radio"> <label for="knob-close"> Mark bug as <b>CLOSED</b> </label> <br> <input value="Commit" type="submit"> <input name="form_name" value="process_bug" type="hidden"> <p> <font size="+1"> <b> <a href="http://bugs.freedesktop.org/show_activity.cgi?id=10576">View Bug Activity</a> | <a href="http://bugs.freedesktop.org/show_bug.cgi?format=multiple&id=10576">Format For Printing</a> | <a href="http://bugs.freedesktop.org/show_bug.cgi?ctype=xml&id=10576">XML</a> | <a href="http://bugs.freedesktop.org/enter_bug.cgi?cloned_bug_id=10576">Clone This Bug</a> </b> </font> </p> <hr> <script type="text/javascript"> <!-- function updateCommentPrivacy(checkbox, id) { var text_elem = document.getElementById('comment_text_'+id); if (checkbox.checked) { text_elem.parentNode.className='bz_private'; } else { text_elem.parentNode.className=''; } } //--> </script> <div> <table> <tbody><tr> <td align="left"> <b><a name="c0" href="http://bugs.freedesktop.org/show_bug.cgi?id=10576#c0"> Description</a>:</b> <script type="text/javascript"><!-- addReplyLink(0); //--></script>[<a href="#add_comment" onclick="replyToComment(0);">reply</a>] </td> <td align="left" width="30%"> <b>Opened:</b> 2007-04-09 10:18 PST </td> </tr> </tbody></table> <pre id="comment_text_0">It looks like that latest (as of writing <a href="mailto:2.6.21-rc6@kernel.org">2.6.21-rc6@kernel.org</a>) kernel contains function named vm_insert_pfn in /mm/memory.c and /mm/mm.h (see <a href="http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=e0dc0d8f4a327d033bfb63d43f113d5f31d11b3c">http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=e0dc0d8f4a327d033bfb63d43f113d5f31d11b3c</a> for specific check-in). Unfortunately vm_insert_pfn is also used in drm_compat.c thus resulting in naming clash. At a first glance they both differ in code very much. The result of make is /home/michal/nouveau/drm/linux-core/drm_compat.c:190: error: static declaration of âvm_insert_pfnâ follows non-static declaration include/linux/mm.h:1126: error: previous declaration of âvm_insert_pfnâ was here The bug was found on Ubuntu Feisty with latest kernel packages installed (which apparently is 2.6.20. uname -r gives 2.6.20-14-generic) 2.6.20 from gentoo does not have this problem. </pre> </div> <div> <br> <span class="bz_comment"> ------- <i>Comment <a name="c1" href="http://bugs.freedesktop.org/show_bug.cgi?id=10576#c1"> #1</a> From <a href="mailto:michalsznajder@gmail.com">MichaÅ Sznajder</a> 2007-04-09 11:09:36 PST </i> <script type="text/javascript"><!-- addReplyLink(1); //--></script>[<a href="#add_comment" onclick="replyToComment(1);">reply</a>] ------- </span> <pre id="comment_text_1">Links to drm and kernels git's that have introduced incompatibility: <a href="http://gitweb.freedesktop.org/?p=mesa/drm.git;a=commitdiff;h=f2db76e2f206d2017f710eaddc4b33add4498898">http://gitweb.freedesktop.org/?p=mesa/drm.git;a=commitdiff;h=f2db76e2f206d2017f710eaddc4b33add4498898</a> <a href="http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=e0dc0d8f4a327d033bfb63d43f113d5f31d11b3c">http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=e0dc0d8f4a327d033bfb63d43f113d5f31d11b3c</a> Someone has to change the name but who? </pre> </div> <div> <br> <span class="bz_comment"> ------- <i>Comment <a name="c2" href="http://bugs.freedesktop.org/show_bug.cgi?id=10576#c2"> #2</a> From <a href="mailto:thomas@tungstengraphics.com">Thomas Hellstr�m</a> 2007-04-09 11:27:28 PST </i> <script type="text/javascript"><!-- addReplyLink(2); //--></script>[<a href="#add_comment" onclick="replyToComment(2);">reply</a>] ------- </span> <pre id="comment_text_2">(In reply to <a href="http://bugs.freedesktop.org/show_bug.cgi?id=10576#c1">comment #1</a>) > Links to drm and kernels git's that have introduced incompatibility: > > <a href="http://gitweb.freedesktop.org/?p=mesa/drm.git;a=commitdiff;h=f2db76e2f206d2017f710eaddc4b33add4498898">http://gitweb.freedesktop.org/?p=mesa/drm.git;a=commitdiff;h=f2db76e2f206d2017f710eaddc4b33add4498898</a> > > <a href="http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=e0dc0d8f4a327d033bfb63d43f113d5f31d11b3c">http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=e0dc0d8f4a327d033bfb63d43f113d5f31d11b3c</a> > > Someone has to change the name but who? > vm_insert_pfn first appears in the kernel in the 2.6.21-rc series. In drm_compat.c it is not included if the kernel version >= 2.6.21, when the symbol DRM_FULL_MM_COMPAT is defined. The semantics of the two functions, although they are looking very different are the same. The one in the mainstream kernel should be used if there is a clash. I'm not sure why it appears in Ubuntu 2.6.20. I think you need to ask the Ubuntu guys. /Thomas </pre> </div> <div> <br> <span class="bz_comment"> ------- <i>Comment <a name="c3" href="http://bugs.freedesktop.org/show_bug.cgi?id=10576#c3"> #3</a> From <a href="mailto:chris-fdbugs@printf.net">Chris Ball</a> 2007-04-27 15:34:47 PST </i> <script type="text/javascript"><!-- addReplyLink(3); //--></script>[<a href="#add_comment" onclick="replyToComment(3);">reply</a>] ------- </span> <pre id="comment_text_3">(In reply to <a href="http://bugs.freedesktop.org/show_bug.cgi?id=10576#c2">comment #2</a>) > I'm not sure why it appears in Ubuntu 2.6.20. I think you need to ask the > Ubuntu guys. It's hardly uncommon for a distro to choose a kernel (2.6.20), and then pull selectively from patches intended for a newer release without updating their kernel version to describe itself as that newer release (which it isn't). What would you have the Ubuntu maintainers do instead? </pre> </div> <div> <br> <span class="bz_comment"> ------- <i>Comment <a name="c4" href="http://bugs.freedesktop.org/show_bug.cgi?id=10576#c4"> #4</a> From <a href="mailto:thomas@tungstengraphics.com">Thomas Hellstr�m</a> 2007-04-28 13:50:17 PST </i> <script type="text/javascript"><!-- addReplyLink(4); //--></script>[<a href="#add_comment" onclick="replyToComment(4);">reply</a>] ------- </span> <pre id="comment_text_4">(In reply to <a href="http://bugs.freedesktop.org/show_bug.cgi?id=10576#c3">comment #3</a>) > (In reply to <a href="http://bugs.freedesktop.org/show_bug.cgi?id=10576#c2">comment #2</a>) > > I'm not sure why it appears in Ubuntu 2.6.20. I think you need to ask the > > Ubuntu guys. > It's hardly uncommon for a distro to choose a kernel (2.6.20), and then pull > selectively from patches intended for a newer release without updating their > kernel version to describe itself as that newer release (which it isn't). > What would you have the Ubuntu maintainers do instead? Actually I think that's fine. I cant really figure out why they would want to pull vm_insert_pfn, since AFAICT it is only used by DRM and cell, but anyway they are free to do what they want. The more important question raised here is what are the DRM developers expected to do about this? Should we maintain compatibility with all more or less selectively patched kernels from all distros? Thomas </pre> </div> <div> <br> <span class="bz_comment"> ------- <i>Comment <a name="c5" href="http://bugs.freedesktop.org/show_bug.cgi?id=10576#c5"> #5</a> From <a href="mailto:airlied@freedesktop.org">Dave Airlie</a> 2007-04-28 18:00:13 PST </i> <script type="text/javascript"><!-- addReplyLink(5); //--></script>[<a href="#add_comment" onclick="replyToComment(5);">reply</a>] ------- </span> <pre id="comment_text_5">We used to do this, but it takes a fair bit of effort... and I really couldn't be bothered, I run ubuntu here and I just ifdef around it rather than try to figure out what they did to their kernel.. </pre> </div> </form> <hr> <i><font color="#777777">First</font></i> <i><font color="#777777">Last</font></i> <i><font color="#777777">Prev</font></i> <i><font color="#777777">Next</font></i> <i><font color="#777777">No search results available</font></i> <a href="http://bugs.freedesktop.org/query.cgi">Search page</a> <a href="http://bugs.freedesktop.org/enter_bug.cgi">Enter new bug</a> <br> <div id="footer"> <div class="intro"></div> <div id="useful-links"> <div id="links-actions"> <div class="label">Actions:</div> <div class="links"> <a href="http://bugs.freedesktop.org/">Home</a> | <a href="http://bugs.freedesktop.org/enter_bug.cgi">New</a> | <a href="http://bugs.freedesktop.org/query.cgi">Search</a> | <form action="buglist.cgi" method="get" onsubmit="if (this.quicksearch.value == '') { alert('Please enter one or more search terms first.'); return false; } return true;"> <input class="txt" name="quicksearch" type="text"> <input class="btn" value="Find" type="submit"> </form> | <a href="http://bugs.freedesktop.org/report.cgi">Reports</a> | <a href="http://bugs.freedesktop.org/request.cgi">Requests</a> | <a href="http://bugs.freedesktop.org/createaccount.cgi">New Account</a> | <a href="http://bugs.freedesktop.org/index.cgi?GoAheadAndLogIn=1">Log In</a> </div> </div> <div id="links-saved"> <div class="label"> </div> <div class="links"> </div> </div> </div> <div class="outro"></div> </div> </body></html>
View Attachment As Raw
Actions:
View
Attachments on
bug 239050
: 154141