Attachment 155114 Details for Bug 239766 – maxcpus-ignore-offline-cpus.patch

maxcpus-ignore-offline-cpus.patch

maxcpus-ignore-offline-cpus.patch (text/plain), 4.93 KB, created by IBM Bug Proxy on 2007-05-21 16:50:46 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: IBM Bug Proxy

Created: 2007-05-21 16:50:46 UTC

Size: 4.93 KB

patch

obsolete

>From tglx@linutronix.de Sat May 19 07:22:50 2007
>Return-Path: <tglx@linutronix.de>
>Received: from imap.linux.ibm.com ([unix socket])
>	 by imap.linux.ibm.com (Cyrus v2.3.7-Invoca-RPM-2.3.7-7) with LMTPA;
>	 Sat, 19 May 2007 10:20:53 -0400
>X-Sieve: CMU Sieve 2.3
>Received: by imap.linux.ibm.com (Postfix, from userid 101)
>	id ABCF41910168; Sat, 19 May 2007 10:20:53 -0400 (EDT)
>X-Spam-TestScore: none
>X-Spam-TokenSummary: Bayes not run.
>X-Spam-Checker-Version: SpamAssassin 3.1.7 (2006-10-05) on imap.linux.ibm.com
>X-Spam-Level: 
>X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=disabled 
>	version=3.1.7
>X-Spam-Relay-Country: US US US ** US US DE DE
>Received: from smtp2.linux.ibm.com (smtp2.linux.ibm.com [9.37.253.134])
>	by imap.linux.ibm.com (Postfix) with ESMTP id 63A39191015A
>	for <dvhltc@imap.linux.ibm.com>; Sat, 19 May 2007 10:20:51 -0400 (EDT)
>Received: from localhost (localhost.localdomain [127.0.0.1])
>	by smtp2.linux.ibm.com (Postfix) with ESMTP id 56F3B8C00A
>	for <dvhltc@linux.ibm.com>; Sat, 19 May 2007 10:20:51 -0400 (EDT)
>X-Virus-Scanned: amavisd-new at linux.ibm.com
>Received: from BLDGATE.BOULDER.IBM.COM (bldgate.boulder.ibm.com [9.17.210.138])
>	by smtp2.linux.ibm.com (Postfix) with ESMTP id 1B7ED8C009
>	for <dvhltc@linux.ibm.com>; Sat, 19 May 2007 10:20:51 -0400 (EDT)
>Received:  by BLDGATE.BOULDER.IBM.COM (IBM VM SMTP Level 520) via spool with SMTP id 6018 ; Sat, 19 May 2007 08:17:10 MDT
>Received: by bldgate.vnet.ibm.com (xagent2 5.8.6) via xagsmtp3 with spool id
>	1533 for dvhltc@linux.vnet.ibm.com; Sat, 19 May 2007 08:17:10 -0600 (MDT)
>Received: from d03relay05.boulder.ibm.com [9.17.195.107] by
>	BLDGATE.BOULDER.IBM.COM (IBM VM SMTP Level 520) via TCP with ESMTP ; Sat, 19
>	May 2007 08:17:10 MDT
>Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com
>	[9.17.195.170]) by d03relay05.boulder.ibm.com (8.13.8/8.13.8/NCO v8.3) with
>	ESMTP id l4JEHAAB150280 for <dvhltc@us.ibm.com>; Sat, 19 May 2007 08:17:10
>	-0600
>Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by
>	d03av04.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id
>	l4JEHAl8019967 for <dvhltc@us.ibm.com>; Sat, 19 May 2007 08:17:10 -0600
>Received: from d03atspamtest02.boulder.ibm.com (d03atspamtest02
>	[9.17.195.254]) by d03av04.boulder.ibm.com (8.12.11.20060308/8.12.11) with
>	ESMTP id l4JEH9Le019954 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA
>	bits=256 verify=OK) for <dvhltc@us.ibm.com>; Sat, 19 May 2007 08:17:10 -0600
>Received: from e31.co.us.ibm.com ([9.17.249.41]) by
>	d03atspamtest02.boulder.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id
>	l4JEH8qa029238 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256
>	verify=OK) for <dvhltc@us.ibm.com>; Sat, 19 May 2007 08:17:09 -0600
>Received: from mail.tglx.de (www.osadl.org [213.239.205.134]) by
>	e31.co.us.ibm.com (8.13.8/8.13.8) with ESMTP id l4JEH7ZH009100 for
>	<dvhltc@us.ibm.com>; Sat, 19 May 2007 10:17:08 -0400
>Received: from [IPv6:::1] (debian [213.239.205.147]) by mail.tglx.de (Postfix)
>	with ESMTP id ECFA665C065; Sat, 19 May 2007 16:17:03 +0200 (CEST)
>Subject: [PATCH] Ignore bogus ACPI info for offline CPUs
>From: Thomas Gleixner <tglx@linutronix.de>
>To: LKML <linux-kernel@vger.kernel.org>
>Cc: Len Brown <lenb@kernel.org>,
> Darren Hart <dvhltc@us.ibm.com>,
> Ingo Molnar <mingo@elte.hu>,
> Andrew Morton <akpm@osdl.org>,
> Stable Team
> <stable@kernel.org>
>Content-Type: text/plain
>Date: Sat, 19 May 2007 16:22:50 +0200
>Message-Id: <1179584570.12981.123.camel@chaos>
>Mime-Version: 1.0
>X-Mailer: Evolution 2.8.3 (2.8.3-2.fc6) 
>Content-Transfer-Encoding: 7bit
>X-Xagent-From: tglx@linutronix.de
>X-Xagent-To: dvhltc@linux.vnet.ibm.com
>X-Xagent-Gateway: bldgate.vnet.ibm.com (XAGENTU at BLDGATE)
>X-UID: 26711
>X-Length: 4998
>Status: R
>X-Status: NC
>X-KMail-EncryptionState:  
>X-KMail-SignatureState:  
>X-KMail-MDN-Sent:  
>
>Booting a SMP kernel with maxcpus=1 on a SMP system leads to a hard
>hang, because ACPI ignores the maxcpus setting and sends timer broadcast
>info for the offline CPUs. This results in a stuck for ever call to
>smp_call_function_single() on an offline CPU.
>
>Ignore the bogus information and print a kernel error to remind ACPI
>folks to fix it.
>
>Affects 2.6.21 / 2.6.22-rc
>
>Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
>
>Index: linux-2.6.22-rc/kernel/time/tick-broadcast.c
>===================================================================
>--- linux-2.6.22-rc.orig/kernel/time/tick-broadcast.c
>+++ linux-2.6.22-rc/kernel/time/tick-broadcast.c
>@@ -244,11 +244,18 @@ void tick_broadcast_on_off(unsigned long
> {
> 	int cpu = get_cpu();
>
>-	if (cpu == *oncpu)
>-		tick_do_broadcast_on_off(&reason);
>-	else
>-		smp_call_function_single(*oncpu, tick_do_broadcast_on_off,
>-					 &reason, 1, 1);
>+	if (!cpu_isset(*oncpu, cpu_online_map)) {
>+		printk(KERN_ERR "tick-braodcast: ignoring broadcast for "
>+		       "offline CPU #%d\n", *oncpu);
>+	} else {
>+
>+		if (cpu == *oncpu)
>+			tick_do_broadcast_on_off(&reason);
>+		else
>+			smp_call_function_single(*oncpu,
>+						 tick_do_broadcast_on_off,
>+						 &reason, 1, 1);
>+	}
> 	put_cpu();
> }
>
>
>
>

Actions: View

Attachments on bug 239766: 155114