Attachment 155246 Details for Bug 240962 – Bugfix.

[patch] Bugfix.

strace-4.5.15-tkill.patch (text/plain), 1.20 KB, created by Jan Kratochvil on 2007-05-23 14:40:51 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jan Kratochvil

Created: 2007-05-23 14:40:51 UTC

Size: 1.20 KB

patch

obsolete

>2007-05-23  Jan Kratochvil  <jan.kratochvil@redhat.com>
>
>	* strace.c [LINUX] (tkill): New definition.
>	[LINUX] (detach): Use tkill(2) instead of kill(2).
>
>diff -u -rup strace-4.5.15-detach-zombie/strace.c strace-4.5.15/strace.c
>--- strace-4.5.15-detach-zombie/strace.c	2007-05-23 16:09:24.000000000 +0200
>+++ strace-4.5.15/strace.c	2007-05-23 16:32:55.000000000 +0200
>@@ -46,6 +46,11 @@
> #include <limits.h>
> #include <dirent.h>
> 
>+#ifdef LINUX
>+#include <sys/syscall.h>
>+#define tkill(tid, sig) syscall (SYS_tkill, (tid), (sig))
>+#endif
>+
> #if defined(IA64) && defined(LINUX)
> # include <asm/ptrace_offsets.h>
> #endif
>@@ -1323,11 +1328,14 @@ int sig;
> 		/* Shouldn't happen. */
> 		perror("detach: ptrace(PTRACE_DETACH, ...)");
> 	}
>-	else if (kill(tcp->pid, 0) < 0) {
>+	/* kill() may choose arbitrarily the target task of the process group
>+	   while we wait on a specific TID below.  PID process waits become TID
>+	   task specific waits for process under ptrace(2).  */
>+	else if (tkill(tcp->pid, 0) < 0) {
> 		if (errno != ESRCH)
> 			perror("detach: checking sanity");
> 	}
>-	else if (kill(tcp->pid, SIGSTOP) < 0) {
>+	else if (tkill(tcp->pid, SIGSTOP) < 0) {
> 		if (errno != ESRCH)
> 			perror("detach: stopping child");
> 	}

Actions: View | Diff

Attachments on bug 240962: 155244 | 155246 | 155329 | 155354