Attachment 1555290 Details for Bug 1694201 – patch to prevent falback to smb

[patch] patch to prevent falback to smb

cifs-rename-ebusy-no-fallback.patch (text/plain), 1.08 KB, created by Frank Sorenson on 2019-04-15 17:45:08 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Frank Sorenson

Created: 2019-04-15 17:45:08 UTC

Size: 1.08 KB

patch

obsolete

>From 31374ac3bdbac7012164171708762293cc9e44d3 Mon Sep 17 00:00:00 2001
>From: Frank Sorenson <sorenson@redhat.com>
>Date: Mon, 15 Apr 2019 12:32:37 -0500
>Subject: [PATCH] cifs: do not attempt cifs operation on smb2+ rename error
>
>A path-based rename returning EBUSY will incorrectly try opening
>the file with a cifs (NT Create AndX) operation on an smb2+ mount,
>which causes the server to force a session close.
>
>If the mount is smb2+, skip the fallback.
>
>Signed-off-by: Frank Sorenson <sorenson@redhat.com>
>---
> fs/cifs/inode.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/fs/cifs/inode.c b/fs/cifs/inode.c
>index 53fdb5df0d2e..538fd7d807e4 100644
>--- a/fs/cifs/inode.c
>+++ b/fs/cifs/inode.c
>@@ -1735,6 +1735,10 @@ cifs_do_rename(const unsigned int xid, struct dentry *from_dentry,
> 	if (rc == 0 || rc != -EBUSY)
> 		goto do_rename_exit;
> 
>+	/* Don't fall back to using SMB on SMB 2+ mount */
>+	if (server->vals->protocol_id != 0)
>+		goto do_rename_exit;
>+
> 	/* open-file renames don't work across directories */
> 	if (to_dentry->d_parent != from_dentry->d_parent)
> 		goto do_rename_exit;
>-- 
>2.14.4
>

Actions: View | Diff

Attachments on bug 1694201: 1549585 | 1555290