Attachment 155644 Details for Bug 241427 – Fixes x86_64 bug for referencer 1.0.3

[patch] Fixes x86_64 bug for referencer 1.0.3

referencer.patch (text/plain), 3.27 KB, created by Rick L Vinyard Jr on 2007-05-29 21:48:55 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Rick L Vinyard Jr

Created: 2007-05-29 21:48:55 UTC

Size: 3.27 KB

patch

obsolete

>diff -r -U 5 referencer-1.0.3.orig/src/BibData.C referencer-1.0.3/src/BibData.C
>--- referencer-1.0.3.orig/src/BibData.C	2007-04-28 15:29:15.000000000 -0600
>+++ referencer-1.0.3/src/BibData.C	2007-05-26 17:21:50.000000000 -0600
>@@ -398,11 +398,11 @@
> 		"<b><big>Retrieving metadata</big></b>\n\n"
> 		"Contacting citebase.org to retrieve metadata for '"
> 		+ extras_["eprint"] + "'\n";
> 
> 	Glib::ustring arxivid = extras_["eprint"];
>-	unsigned int index = arxivid.find ("v");
>+	int index = arxivid.find ("v");
> 	if (index != Glib::ustring::npos) {
> 		arxivid = arxivid.substr (0, index);
> 	}
> 
> 	arxivid = Glib::Markup::escape_text (arxivid);
>diff -r -U 5 referencer-1.0.3.orig/src/Document.C referencer-1.0.3/src/Document.C
>--- referencer-1.0.3.orig/src/Document.C	2007-04-28 15:29:15.000000000 -0600
>+++ referencer-1.0.3/src/Document.C	2007-05-26 17:08:02.000000000 -0600
>@@ -60,11 +60,11 @@
> 	// Ideally Chambers06
> 	// If not then pap104
> 	// If not then Unnamed-5
> 	Glib::ustring name;
> 
>-	unsigned int const maxlen = 14;
>+	Glib::ustring::size_type const maxlen = 14;
> 
> 	if (!bib_.getAuthors().empty ()) {
> 		Glib::ustring year = bib_.getYear ();
> 		if (year.size() == 4)
> 			year = year.substr (2,3);
>@@ -80,11 +80,11 @@
> 		name = authors + year;
> 	} else if (!filename_.empty ()) {
> 		Glib::ustring filename = Gnome::Vfs::unescape_string_for_display (
> 			Glib::path_get_basename (filename_));
> 
>-		unsigned int periodpos = filename.find_last_of (".");
>+		int periodpos = filename.find_last_of (".");
> 		if (periodpos != std::string::npos) {
> 			filename = filename.substr (0, periodpos);
> 		}
> 
> 		name = filename;
>@@ -484,11 +484,11 @@
> 	Glib::ustring shortname = olduri->extract_short_name ();
> 	std::cerr << "Shortname = " << shortname << "\n";
> 	Glib::ustring dirname = olduri->extract_dirname ();
> 	std::cerr << "Dirname = " << dirname << "\n";
> 
>-	unsigned int pos = shortname.rfind (".");
>+	int pos = shortname.rfind (".");
> 	Glib::ustring extension = "";
> 	if (pos != Glib::ustring::npos)
> 		extension = shortname.substr (pos, shortname.length() - 1);
> 
> 	Glib::ustring newfilename = getKey() + extension;
>diff -r -U 5 referencer-1.0.3.orig/src/Utility.C referencer-1.0.3/src/Utility.C
>--- referencer-1.0.3.orig/src/Utility.C	2007-04-28 15:29:15.000000000 -0600
>+++ referencer-1.0.3/src/Utility.C	2007-05-26 17:19:02.000000000 -0600
>@@ -228,12 +228,12 @@
> 
> 
> std::string escapeBibtexAccents (
> 	Glib::ustring target)
> {
>-	std::cerr << "escapeBibtexAccents '" << target << "'\n";
>-	for (unsigned int i = 0; i < target.length(); ++i) {
>+	//std::cerr << "escapeBibtexAccents '" << target << "'\n";
>+	for (Glib::ustring::size_type i = 0; i < target.length(); ++i) {
> 		gunichar letter = target[i];
> 		std::cerr << (char)letter << "\n";
> 		if (letter < 128) {
> 			// Rationale: although in general we pass through {,},\ etc to allow
> 			// the user to use his own latex-isms, the ampersand has no legitimate
>@@ -288,11 +288,11 @@
> 	Glib::ustring separator = Glib::build_filename ("-", "-");
> 	separator = separator.substr (1, separator.length() - 2);
> 
> 	std::vector<Glib::ustring> libparts;
> 
>-	unsigned int next;
>+	int next;
> 	while ((next = parent.find (separator)) != Glib::ustring::npos) {
> 		Glib::ustring chunk = parent.substr (0, next);
> 		libparts.push_back (chunk);
> 		parent = parent.substr (next + 1, parent.length() - 1);
> 	}

Actions: View | Diff

Attachments on bug 241427: 155644 | 155645