Attachment 155813 Details for Bug 241793 – xenconsoled logging (patch 2/2)

xenconsoled logging (patch 2/2)

xen-console-log-2.patch (text/x-patch), 1.03 KB, created by Richard W.M. Jones on 2007-05-31 13:19:30 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Richard W.M. Jones

Created: 2007-05-31 13:19:30 UTC

Size: 1.03 KB

patch

obsolete

>--- io.c.orig	2007-05-31 12:59:06.000000000 +0100
>+++ io.c	2007-05-31 13:07:11.000000000 +0100
>@@ -105,6 +105,16 @@
> 	intf->out_cons = cons;
> 	xc_evtchn_notify(dom->xce_handle, dom->local_port);
> 
>+	/* Get the data to the logfile as early as possible because if
>+	 * no one is listening on the console pty then it will fill up
>+	 * and handle_tty_write will stop being called.
>+	 */
>+	if (dom->log_fd != -1) {
>+		write (dom->log_fd,
>+			buffer->data + buffer->size - size,
>+			size);
>+	}
>+
> 	if (buffer->max_capacity &&
> 	    buffer->size > buffer->max_capacity) {
> 		/* Discard the middle of the data. */
>@@ -518,14 +528,6 @@
> {
> 	ssize_t len;
> 
>-	if (dom->log_fd != -1) {
>-		len = write(dom->log_fd, dom->buffer.data + dom->buffer.consumed,
>-			    dom->buffer.size - dom->buffer.consumed);
>-		if (len < 1)
>-			dolog(LOG_DEBUG, "Write to log failed on domain %d: %zd, %d\n",
>-			      dom->domid, len, errno);
>-	}
>-
> 	len = write(dom->tty_fd, dom->buffer.data + dom->buffer.consumed,
> 		    dom->buffer.size - dom->buffer.consumed);
>  	if (len < 1) {

Actions: View

Attachments on bug 241793: 155716 | 155717 | 155718 | 155723 | 155724 | 155725 | 155811 | 155812 | 155813 | 155816 | 155883