Attachment 1570167 Details for Bug 1711374 – Fix for giac <1.5.0.53

[patch] Fix for giac <1.5.0.53

giac-GLIBCXX_ASSERTIONS.patch (text/plain), 2.48 KB, created by Frederic Han on 2019-05-17 15:59:09 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Frederic Han

Created: 2019-05-17 15:59:09 UTC

Size: 2.48 KB

patch

obsolete

>Giac  built with -D_GLIBC_ASSERTIONS is broken. Fixed in giac 1.5.0.53
>
>Fixed upstream:
>https://github.com/geogebra/geogebra/commit/6849baded4ec4a93cc118552949e978791c9676d
>
>--- src/ifactor.cc.orig	2019-03-15 08:04:02.000000000 +0100
>+++ src/ifactor.cc	2019-04-19 13:44:49.000000000 +0200
>@@ -2517,7 +2517,7 @@
> 	    lp_map[k].clear();
> 	  if (lp_basis_pos){
> 	    for (int k=0;;){
>-	      basis_t * bit=&basis[lp_basis_pos], * bitend=&basis[0]+bs;
>+	      basis_t * bit=&basis[0]+lp_basis_pos, * bitend=&basis[0]+bs;
> 	      unsigned endpos=nslices*slicesize;
> 	      lp_tab_t * ptr=&lp_map[0]+k*nslices;
> 	      for (;bit!=bitend;++bit){
>@@ -2543,7 +2543,7 @@
> 	      // switch roots to next polynomial
> 	      int * bvpos=&bainv2[(bv-1)*bs],* bvposend=bvpos+bs;
> 	      bvpos += lp_basis_pos;
>-	      basis_t * basisptr=&basis[lp_basis_pos];
>+	      basis_t * basisptr=&basis[0]+lp_basis_pos;
> 	      if (be>0){
> 		for (;bvpos<bvposend;++basisptr,++bvpos){
> 		  register unsigned p=basisptr->p;
>@@ -2580,7 +2580,7 @@
> 	for (int k=0;k< nslices;++k)
> 	  lp_map[k].clear();
> 	if (lp_basis_pos){
>-	  basis_t * bit=&basis[lp_basis_pos], * bitend=&basis[0]+bs;
>+	  basis_t * bit=&basis[0]+lp_basis_pos, * bitend=&basis[0]+bs;
> 	  unsigned endpos=nslices*slicesize;
> 	  for (;bit!=bitend;++bit){
> 	    register ushort_t p=bit->p;
>--- src/vecteur.cc.orig	2019-03-15 15:51:10.000000000 +0100
>+++ src/vecteur.cc	2019-04-19 13:46:37.000000000 +0200
>@@ -7470,7 +7470,7 @@
>     res.clear();
>     if (m==0) {
>       res.resize(itend-it);
>-      int * jt=&res.front();
>+      int * jt=res.empty()?0:&res.front();
>       for (;it!=itend;++it,++jt){
> 	int t=it->type;
> 	if (t==0)
>--- src/quater.cc.orig	2019-02-06 14:28:04.000000000 +0100
>+++ src/quater.cc	2019-04-19 13:47:27.000000000 +0200
>@@ -739,7 +739,7 @@
> 	  vecteur2vector_int(*P._VECTptr,0,pmod);
> 	  mulext(amod,bmod,pmod,m,ab);
> 	  int absize=int(ab.size());
>-	  int * i=&ab.front(),*iend=i+absize;
>+	  int * i=ab.empty()?0:&ab.front(),*iend=i+absize;
> 	  for (;i<iend;++i){
> 	    int j=*i;
> 	    //j =smod(j,m);
>--- ../giac-1.5.0/src/series.cc	2019-03-12 09:21:10.000000000 +0100
>+++ src/series.cc	2019-04-20 09:36:08.969911691 +0200
>@@ -2940,7 +2940,7 @@
> #ifdef TIMEOUT
>       control_c();
> #endif
>-      if (ctrl_c || interrupted || is_undef(p.front().exponent)) 
>+      if (ctrl_c || interrupted || p.empty() || is_undef(p.front().exponent))//fred 
> 	return false;
>       if (!p.empty() && !is_undef(p.front().coeff) ){
> 	// substitution of ln(w) by +-g should not be useful anymore

Actions: View | Diff

Attachments on bug 1711374: 1570167 | 1570168