Attachment 158332 Details for Bug 246465 – Fix for minicom race conditions that can result in NULL dereference during shutdown

[patch] Fix for minicom race conditions that can result in NULL dereference during shutdown

minicom-2.2-signals.patch (text/plain), 1.00 KB, created by Lubomir Kundrak on 2007-07-02 15:08:21 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lubomir Kundrak

Created: 2007-07-02 15:08:21 UTC

Size: 1.00 KB

patch

obsolete

>This bug fixes signal handling race conditions which could result in a
>NULL pointer dereference.
>
>--- minicom-2.2.orig/src/minicom.c	2007-07-02 16:57:12.000000000 +0200
>+++ minicom-2.2/src/minicom.c	2007-07-02 17:03:09.000000000 +0200
>@@ -108,12 +108,14 @@ static void hangsig(int sig)
> static void shjump(int dummy /* __attribute__((unused)) */)
> {
>   dummy = dummy; /* avoid compiler warning, should be optimized away... */
>-  wleave();
>+  if (gmap)
>+    wleave();
>   signal(SIGTSTP, SIG_DFL);
>   fputs(_("Suspended. Type \"fg\" to resume.\n"),stdout);
>   kill(getpid(), SIGTSTP);
>   signal(SIGTSTP, shjump);
>-  wreturn();
>+  if (gmap)
>+    wreturn();
>   if (use_status)
>     show_status();
> }
>@@ -1516,6 +1518,16 @@ dirty_goto:
>     }
>   };
> 
>+  /* Unhook signal handlers */
>+  signal(SIGTERM, SIG_DFL);
>+  signal(SIGHUP, SIG_DFL);
>+#ifdef SIGTSTP
>+  signal(SIGTSTP, SIG_DFL);
>+#endif
>+#ifdef SIGWINCH
>+  signal(SIGWINCH, SIG_DFL);
>+#endif
>+
>   /* Reset parameters */
>   if (quit != NORESET)
>     m_restorestate(portfd);

Actions: View | Diff

Attachments on bug 246465: 158332