Attachment 158496 Details for Bug 243064 – Patch to fix at.c (adding jobs, signaling atd, atrm, at -c)

[patch] Patch to fix at.c (adding jobs, signaling atd, atrm, at -c)

at.c.patch (text/plain), 1.75 KB, created by Michael Staib on 2007-07-04 05:12:32 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Michael Staib

Created: 2007-07-04 05:12:32 UTC

Size: 1.75 KB

patch

obsolete

>--- /usr/src/redhat/SOURCES/at-3.1.10-patched/at.c	2007-07-03 22:39:26.000000000 -0400
>+++ at.c	2007-07-04 01:05:26.000000000 -0400
>@@ -323,18 +323,13 @@
> 	if ((fd2 = dup(fd)) < 0)
> 	    perr("Error in dup() of job file");
> 
>-        /*
>+        
> 	if (fchown(fd2, real_uid, real_gid) != 0)
>-	    perr("Cannot give away file");
>-        */
>+	    perr("Cannot give real_uid and real_gid the file");
>+        
> 
>     PRIV_END
> 
>-    /* We no longer need suid root; now we just need to be able to write
>-     * to the directory, if necessary.
>-     */
>-
>-    REDUCE_PRIV(daemon_uid, daemon_gid)
>     /* We've successfully created the file; let's set the flag so it 
>      * gets removed in case of an interrupt or error.
>      */
>@@ -492,7 +487,7 @@
>      */
> 
>     if (fchmod(fd2, S_IRUSR | S_IWUSR | S_IXUSR) < 0)
>-	perr("Cannot give away file");
>+	perr("Cannot change the mode of the file");
> 
>     close(fd2);
> 
>@@ -657,7 +652,7 @@
>                     We need the unprivileged uid here since the file is owned by the real
>                     (not effective) uid.
>                     */
>-                    setregid(real_gid, effective_gid);
>+		    PRIV_START
> 
> 		    if (queue == '=') {
> 			fprintf(stderr, "Warning: deleting running job\n");
>@@ -666,8 +661,8 @@
> 			perr("Cannot unlink %.500s", dirent->d_name);
> 			rc = EXIT_FAILURE;
> 		    }
>+		    PRIV_END
> 
>-                    setregid(effective_gid, real_gid);
> 		    done = 1;
> 
> 		    break;
>@@ -677,7 +672,7 @@
> 			FILE *fp;
> 			int ch;
> 
>-			setregid(real_gid, effective_gid);
>+			PRIV_START
> 			fp = fopen(dirent->d_name, "r");
> 
> 			if (fp) {
>@@ -690,7 +685,7 @@
> 			    perr("Cannot open %.500s", dirent->d_name);
> 			    rc = EXIT_FAILURE;
> 			}
>-			setregid(effective_gid, real_gid);
>+			PRIV_END
> 		    }
> 		    break;
>

Actions: View | Diff

Attachments on bug 243064: 156744 | 158496