Login
[x]
Log in using an account from:
Fedora Account System
Red Hat Associate
Red Hat Customer
Or login using a Red Hat Bugzilla account
Forgot Password
Login:
Hide Forgot
Create an Account
Red Hat Bugzilla – Attachment 158577 Details for
Bug 246819
files in /usr/share/mantis marked as documentation
[?]
New
Simple Search
Advanced Search
My Links
Browse
Requests
Reports
Current State
Search
Tabular reports
Graphical reports
Duplicates
Other Reports
User Changes
Plotly Reports
Bug Status
Bug Severity
Non-Defaults
|
Product Dashboard
Help
Page Help!
Bug Writing Guidelines
What's new
Browser Support Policy
5.0.4.rh83 Release notes
FAQ
Guides index
User guide
Web Services
Contact
Legal
This site requires JavaScript to be enabled to function correctly, please enable it.
[patch]
Stricter docdir checking
rpm-strict-docdir.patch (text/plain), 858 bytes, created by
Panu Matilainen
on 2007-07-05 10:23:03 UTC
(
hide
)
Description:
Stricter docdir checking
Filename:
MIME Type:
Creator:
Panu Matilainen
Created:
2007-07-05 10:23:03 UTC
Size:
858 bytes
patch
obsolete
>diff -r b19bb4373dd2 build/files.c >--- a/build/files.c Wed Jul 04 15:35:12 2007 +0300 >+++ b/build/files.c Thu Jul 05 13:18:28 2007 +0300 >@@ -1065,7 +1065,6 @@ static int compareFileListRecs(const voi > > /** > * Test if file is located in a %docdir. >- * @bug Use of strstr(3) might result in false positives. > * @param fl package file tree walk data > * @param fileName file path > * @return 1 if doc file, 0 if not >@@ -1073,9 +1072,13 @@ static int isDoc(FileList fl, const char > static int isDoc(FileList fl, const char * fileName) /*@*/ > { > int x = fl->docDirCount; >+ char docdir[PATH_MAX], *d; > > while (x--) { >- if (strstr(fileName, fl->docDirs[x]) == fileName) >+ d = stpcpy(docdir, fl->docDirs[x]); >+ if (*(d-1) != '/') >+ d = stpcpy(d, "/"); >+ if (strncmp(fileName, docdir, strlen(docdir)) == 0) > return 1; > } > return 0;
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=158577">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 246819
: 158577