Attachment 159102 Details for Bug 246273 – Patch for checkcert.c

[patch] Patch for checkcert.c

checkcert.patch (text/plain), 1.75 KB, created by Wan-Teh Chang on 2007-07-12 21:56:14 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Wan-Teh Chang

Created: 2007-07-12 21:56:14 UTC

Size: 1.75 KB

patch

obsolete

>Index: checkcert.c
>===================================================================
>RCS file: /cvsroot/mozilla/security/nss/cmd/checkcert/checkcert.c,v
>retrieving revision 1.4
>diff -u -u -r1.4 checkcert.c
>--- checkcert.c	25 Apr 2004 15:02:41 -0000	1.4
>+++ checkcert.c	12 Jul 2007 21:26:05 -0000
>@@ -36,12 +36,13 @@
> 
> #include "secutil.h"
> #include "plgetopt.h"
>+#include "nss.h"
> #include "cert.h"
> #include "secoid.h"
> #include "cryptohi.h"
> 
> /* maximum supported modulus length in bits (indicate problem if over this) */
>-#define MAX_MODULUS (1024)
>+#define MAX_MODULUS (2048)
> 
> 
> static void Usage(char *progName)
>@@ -328,6 +329,8 @@
>     PLOptState *optstate;
>     PLOptStatus status;
> 
>+    NSS_NoDB_Init(NULL);
>+
>     PORT_Memset(&md5WithRSAEncryption, 0, sizeof(md5WithRSAEncryption));
>     PORT_Memset(&md2WithRSAEncryption, 0, sizeof(md2WithRSAEncryption));
>     PORT_Memset(&sha1WithRSAEncryption, 0, sizeof(sha1WithRSAEncryption));
>@@ -514,8 +517,8 @@
> 
> 	if (!(isMD5RSA || isMD2RSA || isSHA1RSA)) {
> 	    printf("PROBLEM: Signature not PKCS1 MD5, MD2, or SHA1 + RSA.\n");
>-	} else if (!isMD5RSA) {
>-	    printf("WARNING: Signature not PKCS1 MD5 with RSA Encryption\n");
>+	} else if (!isSHA1RSA) {
>+	    printf("WARNING: Signature not PKCS1 SHA1 with RSA Encryption\n");
> 	}
> 
> 	if (SECOID_CompareAlgorithmID(&cert->signature,
>@@ -556,7 +559,6 @@
> 	if (verbose) {
> 	    printf("Decoded RSA Public Key ok.  Doing key checks.\n");
> 	}
>-	PORT_Assert(rsapubkey->keyType == rsaKey); /* XXX RSA */
> 	mlen = checkInteger(&rsapubkey->u.rsa.modulus, "Modulus", verbose);
> 	printf("INFO: Public Key modulus length in bits: %d\n", mlen);
> 	if (mlen > MAX_MODULUS) {
>@@ -635,6 +637,7 @@
> 	printf("INFO: Not checking signature.\n");
>     }
> 
>+    NSS_Shutdown();
>     return 0;    
> }
>

Actions: View | Diff

Attachments on bug 246273: 159102