Attachment 159417 Details for Bug 248449 – Proposed patch

[patch] Proposed patch

snapshot_inact.patch (text/plain), 979 bytes, created by Milan Broz on 2007-07-17 12:09:08 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Milan Broz

Created: 2007-07-17 12:09:08 UTC

Size: 979 bytes

patch

obsolete

>Index: tools/lvcreate.c
>===================================================================
>RCS file: /cvs/lvm2/LVM2/tools/lvcreate.c,v
>retrieving revision 1.137
>diff -u -p -r1.137 lvcreate.c
>--- tools/lvcreate.c	28 Jun 2007 17:33:44 -0000	1.137
>+++ tools/lvcreate.c	17 Jul 2007 12:06:04 -0000
>@@ -482,6 +482,7 @@ static int _lvcreate(struct cmd_context 
> 	struct alloc_handle *ah = NULL;
> 	char lv_name_buf[128];
> 	const char *lv_name;
>+	struct lvinfo info;
> 
> 	status |= lp->permission | VISIBLE_LV;
> 
>@@ -792,6 +793,15 @@ static int _lvcreate(struct cmd_context 
> 		if (!(lp->permission & LVM_WRITE))
> 			lv->status &= ~LVM_WRITE;
> 
>+		/* COW area must be deactivated if origin is not active */
>+		if (!lv_info(cmd, org, &info, 0)) {
>+			log_err("'%s' cannot read origin status.", org->name);
>+			return 0;
>+		}
>+
>+		if (!info.exists)
>+			deactivate_lv(cmd, lv);
>+
> 		/* cow LV remains active and becomes snapshot LV */
> 
> 		if (!vg_add_snapshot(vg->fid, NULL, org, lv, NULL,

Actions: View | Diff

Attachments on bug 248449: 159417