Attachment 159881 Details for Bug 249094 – Aggressively free domain pointer in libvirt

[patch] Aggressively free domain pointer in libvirt

virrt-manager-0.4.0-release-deleted-domain.patch (text/plain), 1.71 KB, created by Hugh Brock on 2007-07-24 19:45:00 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Hugh Brock

Created: 2007-07-24 19:45:00 UTC

Size: 1.71 KB

patch

obsolete

>diff -ruN virt-manager-0.4.0.orig/src/virtManager/connection.py virt-manager-0.4.0/src/virtManager/connection.py
>--- virt-manager-0.4.0.orig/src/virtManager/connection.py	2007-04-16 09:31:47.000000000 -0400
>+++ virt-manager-0.4.0/src/virtManager/connection.py	2007-07-24 15:34:26.000000000 -0400
>@@ -407,6 +407,7 @@
>                 curUUIDs[uuid] = vm
>             else:
>                 vm = self.vms[uuid]
>+                vm.release_handle()
>                 vm.set_handle(rawvm)
>                 curUUIDs[uuid] = vm
>                 #print "Mere state change " + str(vm)
>@@ -427,6 +428,7 @@
>         # Inform everyone what changed
>         for uuid in oldUUIDs:
>             self.emit("vm-removed", self.uri, uuid)
>+            oldUUIDs[uuid].release_handle()
> 
>         for uuid in newUUIDs:
>             self.emit("vm-added", self.uri, uuid)
>diff -ruN virt-manager-0.4.0.orig/src/virtManager/domain.py virt-manager-0.4.0/src/virtManager/domain.py
>--- virt-manager-0.4.0.orig/src/virtManager/domain.py	2007-07-24 15:30:55.000000000 -0400
>+++ virt-manager-0.4.0/src/virtManager/domain.py	2007-07-24 15:35:45.000000000 -0400
>@@ -51,6 +51,20 @@
>             self.xml = self.vm.XMLDesc(0)
>         return self.xml
> 
>+    def release_handle(self):
>+        # HACK: Force free the virtDomainPtr C object since we
>+        # can't rely on timely GC. Use try...except block to
>+        # protect in case internals of libvirt python change
>+        # in the future
>+        try:
>+            import libvirtmod
>+            if self.vm._o is not None:
>+                libvirtmod.virDomainFree(self.vm._o)
>+                self.vm._o = None
>+        except:
>+            pass
>+        self.vm = None
>+
>     def set_handle(self, vm):
>         self.vm = vm
>

Actions: View | Diff

Attachments on bug 249094: 159881