Attachment 161182 Details for Bug 251935 – Roland's fix from the upstream beta release binutils-2.17.50.0.18.

[patch] Roland's fix from the upstream beta release binutils-2.17.50.0.18.

binutils-buildid-objcopy.patch (text/plain), 1.89 KB, created by Jan Kratochvil on 2007-08-13 15:30:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jan Kratochvil

Created: 2007-08-13 15:30:28 UTC

Size: 1.89 KB

patch

obsolete

>2007-06-28  Roland McGrath  <roland@frob.com>
>
>	* objcopy.c (setup_section): Don't reset ELF section type to
>	SHT_NOBITS when it is SHT_NOTE.
>	* doc/binutils.texi (objcopy, strip): Mention under --only-keep-debug.
>
>--- binutils/objcopy.c	27 Jun 2007 11:54:09 -0000	1.114
>+++ binutils/objcopy.c	29 Jun 2007 00:34:14 -0000	1.115
>@@ -2212,6 +2212,9 @@ setup_section (bfd *ibfd, sec_ptr isecti
>   if (strip_symbols == STRIP_NONDEBUG
>       && obfd->xvec->flavour == bfd_target_elf_flavour
>       && (flags & SEC_ALLOC) != 0
>+      && elf_section_type (osection) != SHT_NOTE
>+      && (ibfd->xvec->flavour != bfd_target_elf_flavour
>+	  || elf_section_type (isection) != SHT_NOTE)
>       && (p == NULL || !p->set_flags))
>     elf_section_type (osection) = SHT_NOBITS;
> 
>--- binutils/doc/binutils.texi	19 Jun 2007 13:24:33 -0000	1.109
>+++ binutils/doc/binutils.texi	29 Jun 2007 00:34:14 -0000	1.110
>@@ -1481,7 +1481,7 @@ which would otherwise get stripped.
> @item --only-keep-debug
> Strip a file, removing contents of any sections that would not be
> stripped by @option{--strip-debug} and leaving the debugging sections
>-intact.
>+intact.  In ELF files, this preserves all note sections in the output.
> 
> The intention is that this option will be used in conjunction with
> @option{--add-gnu-debuglink} to create a two part executable.  One a
>@@ -2412,8 +2412,9 @@ When stripping a file, perhaps with @opt
> which would otherwise get stripped.
> 
> @item --only-keep-debug
>-Strip a file, removing any sections that would be stripped by
>-@option{--strip-debug} and leaving the debugging sections.
>+Strip a file, removing contents of any sections that would not be
>+stripped by @option{--strip-debug} and leaving the debugging sections
>+intact.  In ELF files, this preserves all note sections in the output.
> 
> The intention is that this option will be used in conjunction with
> @option{--add-gnu-debuglink} to create a two part executable.  One a

Actions: View | Diff

Attachments on bug 251935: 161182