Attachment 161770 Details for Bug 250913 – 0001-mac80211-store-channel-info-in-sta_bss_list.patch

[patch] 0001-mac80211-store-channel-info-in-sta_bss_list.patch

0001-mac80211-store-channel-info-in-sta_bss_list.patch (text/plain), 6.78 KB, created by John W. Linville on 2007-08-17 20:42:09 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: John W. Linville

Created: 2007-08-17 20:42:09 UTC

Size: 6.78 KB

patch

obsolete

>From 3355f033f018d62342337d43153307dd926c3fe9 Mon Sep 17 00:00:00 2001
>From: John W. Linville <linville@linville-tester.local>
>Date: Fri, 17 Aug 2007 16:23:56 -0400
>Subject: [PATCH] [PATCH] mac80211: store channel info in sta_bss_list
>
>Some AP equipment "in the wild" uses the same BSSID on multiple
>channels (particularly "a" vs. "b/g").  This changes the key of
>the sta_bss_list to include both the BSSID and the channel so as
>to prevent a BSSID on one channel from eclipsing the same BSSID on
>another channel.
>
>Signed-off-by: John W. Linville <linville@tuxdriver.com>
>---
> net/mac80211/ieee80211_sta.c |   35 ++++++++++++++++++++---------------
> 1 files changed, 20 insertions(+), 15 deletions(-)
>
>diff --git a/net/mac80211/ieee80211_sta.c b/net/mac80211/ieee80211_sta.c
>index b996332..b5edbcd 100644
>--- a/net/mac80211/ieee80211_sta.c
>+++ b/net/mac80211/ieee80211_sta.c
>@@ -64,7 +64,7 @@
> static void ieee80211_send_probe_req(struct net_device *dev, u8 *dst,
> 				     u8 *ssid, size_t ssid_len);
> static struct ieee80211_sta_bss *
>-ieee80211_rx_bss_get(struct net_device *dev, u8 *bssid);
>+ieee80211_rx_bss_get(struct net_device *dev, u8 *bssid, int channel);
> static void ieee80211_rx_bss_put(struct net_device *dev,
> 				 struct ieee80211_sta_bss *bss);
> static int ieee80211_sta_find_ibss(struct net_device *dev,
>@@ -446,6 +446,7 @@ static void ieee80211_sta_send_associnfo(struct net_device *dev,
> static void ieee80211_set_associated(struct net_device *dev,
> 				     struct ieee80211_if_sta *ifsta, int assoc)
> {
>+	struct ieee80211_local *local = wdev_priv(dev->ieee80211_ptr);
> 	union iwreq_data wrqu;
> 
> 	if (ifsta->associated == assoc)
>@@ -460,7 +461,8 @@ static void ieee80211_set_associated(struct net_device *dev,
> 		if (sdata->type != IEEE80211_IF_TYPE_STA)
> 			return;
> 
>-		bss = ieee80211_rx_bss_get(dev, ifsta->bssid);
>+		bss = ieee80211_rx_bss_get(dev, ifsta->bssid,
>+					   local->hw.conf.channel);
> 		if (bss) {
> 			if (bss->has_erp_value)
> 				ieee80211_handle_erp_ie(dev, bss->erp_value);
>@@ -603,7 +605,7 @@ static void ieee80211_send_assoc(struct net_device *dev,
> 		capab |= WLAN_CAPABILITY_SHORT_SLOT_TIME |
> 			WLAN_CAPABILITY_SHORT_PREAMBLE;
> 	}
>-	bss = ieee80211_rx_bss_get(dev, ifsta->bssid);
>+	bss = ieee80211_rx_bss_get(dev, ifsta->bssid, local->hw.conf.channel);
> 	if (bss) {
> 		if (bss->capability & WLAN_CAPABILITY_PRIVACY)
> 			capab |= WLAN_CAPABILITY_PRIVACY;
>@@ -1165,6 +1167,7 @@ void ieee80211_send_dls_teardown(struct net_device *dev,
> static int ieee80211_privacy_mismatch(struct net_device *dev,
> 				      struct ieee80211_if_sta *ifsta)
> {
>+	struct ieee80211_local *local = wdev_priv(dev->ieee80211_ptr);
> 	struct ieee80211_sta_bss *bss;
> 	int res = 0;
> 
>@@ -1172,7 +1175,7 @@ static int ieee80211_privacy_mismatch(struct net_device *dev,
> 	    ifsta->key_mgmt != IEEE80211_KEY_MGMT_NONE)
> 		return 0;
> 
>-	bss = ieee80211_rx_bss_get(dev, ifsta->bssid);
>+	bss = ieee80211_rx_bss_get(dev, ifsta->bssid, local->hw.conf.channel);
> 	if (!bss)
> 		return 0;
> 
>@@ -1682,7 +1685,8 @@ static void ieee80211_rx_mgmt_assoc_resp(struct net_device *dev,
> 	 * update our stored copy */
> 	if (elems.erp_info && elems.erp_info_len >= 1) {
> 		struct ieee80211_sta_bss *bss
>-			= ieee80211_rx_bss_get(dev, ifsta->bssid);
>+			= ieee80211_rx_bss_get(dev, ifsta->bssid,
>+					       local->hw.conf.channel);
> 		if (bss) {
> 			bss->erp_value = elems.erp_info[0];
> 			bss->has_erp_value = 1;
>@@ -1712,7 +1716,8 @@ static void ieee80211_rx_mgmt_assoc_resp(struct net_device *dev,
> 			       " AP\n", dev->name);
> 			return;
> 		}
>-		bss = ieee80211_rx_bss_get(dev, ifsta->bssid);
>+		bss = ieee80211_rx_bss_get(dev, ifsta->bssid,
>+					   local->hw.conf.channel);
> 		if (bss) {
> 			sta->last_rssi = bss->rssi;
> 			sta->last_signal = bss->signal;
>@@ -2060,7 +2065,7 @@ static void __ieee80211_rx_bss_hash_del(struct net_device *dev,
> 
> 
> static struct ieee80211_sta_bss *
>-ieee80211_rx_bss_add(struct net_device *dev, u8 *bssid)
>+ieee80211_rx_bss_add(struct net_device *dev, u8 *bssid, int channel)
> {
> 	struct ieee80211_local *local = wdev_priv(dev->ieee80211_ptr);
> 	struct ieee80211_sta_bss *bss;
>@@ -2071,6 +2076,7 @@ ieee80211_rx_bss_add(struct net_device *dev, u8 *bssid)
> 	atomic_inc(&bss->users);
> 	atomic_inc(&bss->users);
> 	memcpy(bss->bssid, bssid, ETH_ALEN);
>+	bss->channel = channel;
> 
> 	spin_lock_bh(&local->sta_bss_lock);
> 	/* TODO: order by RSSI? */
>@@ -2082,7 +2088,7 @@ ieee80211_rx_bss_add(struct net_device *dev, u8 *bssid)
> 
> 
> static struct ieee80211_sta_bss *
>-ieee80211_rx_bss_get(struct net_device *dev, u8 *bssid)
>+ieee80211_rx_bss_get(struct net_device *dev, u8 *bssid, int channel)
> {
> 	struct ieee80211_local *local = wdev_priv(dev->ieee80211_ptr);
> 	struct ieee80211_sta_bss *bss;
>@@ -2090,7 +2096,8 @@ ieee80211_rx_bss_get(struct net_device *dev, u8 *bssid)
> 	spin_lock_bh(&local->sta_bss_lock);
> 	bss = local->sta_bss_hash[STA_HASH(bssid)];
> 	while (bss) {
>-		if (memcmp(bss->bssid, bssid, ETH_ALEN) == 0) {
>+		if (memcmp(bss->bssid, bssid, ETH_ALEN) == 0 &&
>+		    bss->channel == channel) {
> 			atomic_inc(&bss->users);
> 			break;
> 		}
>@@ -2259,9 +2266,9 @@ static void ieee80211_rx_bss_info(struct net_device *dev,
> 	else
> 		channel = rx_status->channel;
> 
>-	bss = ieee80211_rx_bss_get(dev, mgmt->bssid);
>+	bss = ieee80211_rx_bss_get(dev, mgmt->bssid, channel);
> 	if (!bss) {
>-		bss = ieee80211_rx_bss_add(dev, mgmt->bssid);
>+		bss = ieee80211_rx_bss_add(dev, mgmt->bssid, channel);
> 		if (!bss)
> 			return;
> 	} else {
>@@ -2378,7 +2385,6 @@ static void ieee80211_rx_bss_info(struct net_device *dev,
> 	}
> 
> 	bss->hw_mode = rx_status->phymode;
>-	bss->channel = channel;
> 	bss->freq = rx_status->freq;
> 	if (channel != rx_status->channel &&
> 	    (bss->hw_mode == MODE_IEEE80211G ||
>@@ -3325,7 +3331,7 @@ static int ieee80211_sta_create_ibss(struct net_device *dev,
> 	printk(KERN_DEBUG "%s: Creating new IBSS network, BSSID " MAC_FMT "\n",
> 	       dev->name, MAC_ARG(bssid));
> 
>-	bss = ieee80211_rx_bss_add(dev, bssid);
>+	bss = ieee80211_rx_bss_add(dev, bssid, local->hw.conf.channel);
> 	if (!bss)
> 		return -ENOMEM;
> 
>@@ -3336,7 +3342,6 @@ static int ieee80211_sta_create_ibss(struct net_device *dev,
> 		local->hw.conf.beacon_int = 100;
> 	bss->beacon_int = local->hw.conf.beacon_int;
> 	bss->hw_mode = local->hw.conf.phymode;
>-	bss->channel = local->hw.conf.channel;
> 	bss->freq = local->hw.conf.freq;
> 	bss->last_update = jiffies;
> 	bss->capability = WLAN_CAPABILITY_IBSS;
>@@ -3396,7 +3401,7 @@ static int ieee80211_sta_find_ibss(struct net_device *dev,
> 	       MAC_FMT "\n", MAC_ARG(bssid), MAC_ARG(ifsta->bssid));
> #endif /* CONFIG_MAC80211_IBSS_DEBUG */
> 	if (found && memcmp(ifsta->bssid, bssid, ETH_ALEN) != 0 &&
>-	    (bss = ieee80211_rx_bss_get(dev, bssid))) {
>+	    (bss = ieee80211_rx_bss_get(dev, bssid, local->hw.conf.channel))) {
> 		printk(KERN_DEBUG "%s: Selected IBSS BSSID " MAC_FMT
> 		       " based on configured SSID\n",
> 		       dev->name, MAC_ARG(bssid));
>-- 
>1.5.2.2
>

Actions: View | Diff

Attachments on bug 250913: 161683 | 161736 | 161770 | 203631