Attachment 161776 Details for Bug 250266 – megaraid_sas IRQF_NODELAY temporary fix

[patch] megaraid_sas IRQF_NODELAY temporary fix

megasas_IRQF_NODELAY.patch (text/plain), 1.05 KB, created by Arnaldo Carvalho de Melo on 2007-08-18 00:10:08 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Arnaldo Carvalho de Melo

Created: 2007-08-18 00:10:08 UTC

Size: 1.05 KB

patch

obsolete

>--- linux-2.6.21.x86_64.orig/drivers/scsi/megaraid/megaraid_sas.c	2007-08-17 20:54:23.000000000 -0300
>+++ linux-2.6.21.x86_64/drivers/scsi/megaraid/megaraid_sas.c	2007-08-17 21:05:26.000000000 -0300
>@@ -2408,7 +2408,22 @@ megasas_probe_one(struct pci_dev *pdev, 
> 	/*
> 	 * Register IRQ
> 	 */
>-	if (request_irq(pdev->irq, megasas_isr, IRQF_SHARED, "megasas", instance)) {
>+	/*
>+	 * Use of IRQF_NODELAY in CONFIG_PREEMPT_RT is know to fix a timeout
>+	 * problem that ultimately makes the driver consider the adapter dead,
>+	 * setting instance->hw_crit_error.  It is safe because megasas_isr
>+	 * doesn't take any locks, just using tasklet_schedule to defer the
>+	 * interrupt handling to softirq time. This is indeed a big hammer
>+	 * "solution", but at least systems with this hardware will work as
>+	 * expected till we find the real fix.
>+	 */
>+	if (request_irq(pdev->irq, megasas_isr,
>+#ifdef CONFIG_PREEMPT_RT
>+			IRQF_NODELAY,
>+#else
>+			IRQF_SHARED,
>+#endif
>+			"megasas", instance)) {
> 		printk(KERN_DEBUG "megasas: Failed to register IRQ\n");
> 		goto fail_irq;
> 	}

Actions: View | Diff

Attachments on bug 250266: 160330 | 161776 | 204301 | 230321