Attachment 162005 Details for Bug 251999 – Patch to fix crash

[patch] Patch to fix crash

firefox-2.0.0.6-gtk2drawing.patch (text/plain), 1.06 KB, created by Meethune Bhowmick on 2007-08-21 20:32:42 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Meethune Bhowmick

Created: 2007-08-21 20:32:42 UTC

Size: 1.06 KB

patch

obsolete

>Index: mozilla/widget/src/gtk2/gtk2drawing.c
>===================================================================
>RCS file: /cvsroot/mozilla/widget/src/gtk2/gtk2drawing.c,v
>retrieving revision 1.27
>diff -pu -r1.27 mozilla/widget/src/gtk2/gtk2drawing.c
>--- mozilla/gfx/src/gtk/gtk2drawing.c
>+++ mozilla/gfx/src/gtk/gtk2drawing.c
>@@ -572,18 +572,19 @@ moz_gtk_option_menu_get_metrics(gboolean
>                          "focus_padding", focus_pad,
>                          NULL);
> 
>-    if (tmp_indicator_size)
>+    if (tmp_indicator_size) {
>         *indicator_size = *tmp_indicator_size;
>-    else
>+        gtk_requisition_free(tmp_indicator_size);
>+    } else {
>         *indicator_size = default_indicator_size;
>-    if (tmp_indicator_spacing)
>+    }
>+    if (tmp_indicator_spacing) {
>         *indicator_spacing = *tmp_indicator_spacing;
>-    else
>+        gtk_border_free(tmp_indicator_spacing); 
>+    } else {
>         *indicator_spacing = default_indicator_spacing;
>+    }
> 
>-    g_free(tmp_indicator_size);
>-    g_free(tmp_indicator_spacing);
>- 
>     return MOZ_GTK_SUCCESS;
> }
>

Actions: View | Diff

Attachments on bug 251999: 161203 | 161279 | 161993 | 162005