Attachment 1639559 Details for Bug 1769417 – fedora-review.txt

fedora-review.txt

review.txt (text/plain), 7.14 KB, created by Shawn Iwinski on 2019-11-25 17:46:09 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Shawn Iwinski

Created: 2019-11-25 17:46:09 UTC

Size: 7.14 KB

patch

obsolete

>Package Review
>==============
>
>Legend:
>[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
>[ ] = Manual review needed
>
>
>
>===== MUST items =====
>
>Generic:
>[x]: Package is licensed with an open-source compatible license and meets
>     other legal requirements as defined in the legal section of Packaging
>     Guidelines.
>[x]: License field in the package spec file matches the actual license.
>     Note: There is no build directory. Running licensecheck on vanilla
>     upstream sources. No licenses found. Please check the source files for
>     licenses manually.
>[x]: Package contains no bundled libraries without FPC exception.
>[x]: Changelog in prescribed format.
>[x]: Sources contain only permissible code or content.
>[-]: Package contains desktop file if it is a GUI application.
>[-]: Development files must be in a -devel package
>[x]: Package uses nothing in %doc for runtime.
>[x]: Package consistently uses macros (instead of hard-coded directory
>     names).
>[x]: Package is named according to the Package Naming Guidelines.
>[x]: Package does not generate any conflict.
>[x]: Package obeys FHS, except libexecdir and /usr/target.
>[-]: If the package is a rename of another package, proper Obsoletes and
>     Provides are present.
>[x]: Requires correct, justified where necessary.
>[x]: Spec file is legible and written in American English.
>[-]: Package contains systemd file(s) if in need.
>[x]: Package is not known to require an ExcludeArch tag.
>[-]: Large documentation must go in a -doc subpackage. Large could be size
>     (~1MB) or number of files.
>     Note: Documentation size is 10240 bytes in 3 files.
>[x]: Package complies to the Packaging Guidelines
>[x]: Package successfully compiles and builds into binary rpms on at least
>     one supported primary architecture.
>[x]: Package installs properly.
>[x]: Rpmlint is run on all rpms the build produces.
>     Note: There are rpmlint messages (see attachment).
>[x]: If (and only if) the source package includes the text of the
>     license(s) in its own file, then that file, containing the text of the
>     license(s) for the package is included in %license.
>[x]: Package requires other packages for directories it uses.
>[x]: Package must own all directories that it creates.
>[x]: Package does not own files or directories owned by other packages.
>[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
>[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
>     beginning of %install.
>[x]: Macros in Summary, %description expandable at SRPM build time.
>[x]: Dist tag is present.
>[x]: Package does not contain duplicates in %files.
>[x]: Permissions on files are set properly.
>[x]: Package must not depend on deprecated() packages.
>[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
>     work.
>[x]: Package is named using only allowed ASCII characters.
>[x]: Package does not use a name that already exists.
>[x]: Package is not relocatable.
>[x]: Sources used to build the package match the upstream source, as
>     provided in the spec URL.
>[x]: Spec file name must match the spec package %{name}, in the format
>     %{name}.spec.
>[x]: File names are valid UTF-8.
>[x]: Packages must not store files under /srv, /opt or /usr/local
>
>===== SHOULD items =====
>
>Generic:
>[-]: If the source package does not include license text(s) as a separate
>     file from upstream, the packager SHOULD query upstream to include it.
>[x]: Final provides and requires are sane (see attachments).
>[x]: Package functions as described.
>[x]: Latest version is packaged.
>[x]: Package does not include license text files separate from upstream.
>[-]: Sources are verified with gpgverify first in %prep if upstream
>     publishes signatures.
>     Note: gpgverify is not used.
>[-]: Description and summary sections in the package spec file contains
>     translations for supported Non-English languages, if available.
>[-]: Package should compile and build into binary rpms on all supported
>     architectures.
>[x]: %check is present and all tests pass.
>[x]: Packages should try to preserve timestamps of original installed
>     files.
>[x]: Reviewer should test that the package builds in mock.
>[x]: Buildroot is not present
>[x]: Package has no %clean section with rm -rf %{buildroot} (or
>     $RPM_BUILD_ROOT)
>[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
>[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
>[x]: Sources can be downloaded from URI in Source: tag
>[x]: SourceX is a working URL.
>[x]: Spec use %global instead of %define unless justified.
>
>===== EXTRA items =====
>
>Generic:
>[x]: Rpmlint is run on all installed packages.
>     Note: There are rpmlint messages (see attachment).
>[x]: Spec file according to URL is the same as in SRPM.
>
>
>Rpmlint
>-------
>Checking: php-psr-http-client-1.0.0-1.fc32.noarch.rpm
>          php-psr-http-client-1.0.0-1.fc32.src.rpm
>php-psr-http-client.noarch: W: spelling-error %description -l en_US autoload -> auto load, auto-load, tautology
>php-psr-http-client.src: W: spelling-error %description -l en_US usr -> use, us, user
>php-psr-http-client.src: W: spelling-error %description -l en_US autoload -> auto load, auto-load, tautology
>2 packages and 0 specfiles checked; 0 errors, 3 warnings.
>
>
>
>
>Rpmlint (installed packages)
>----------------------------
>perl: warning: Setting locale failed.
>perl: warning: Please check that your locale settings:
>	LANGUAGE = (unset),
>	LC_ALL = (unset),
>	LC_CTYPE = "C.UTF-8",
>	LANG = "en_US.UTF-8"
>    are supported and installed on your system.
>perl: warning: Falling back to the standard locale ("C").
>perl: warning: Setting locale failed.
>perl: warning: Please check that your locale settings:
>	LANGUAGE = (unset),
>	LC_ALL = (unset),
>	LC_CTYPE = "C.UTF-8",
>	LANG = "en_US.UTF-8"
>    are supported and installed on your system.
>perl: warning: Falling back to the standard locale ("C").
>php-psr-http-client.noarch: W: spelling-error %description -l en_US autoload -> auto load, auto-load, tautology
>php-psr-http-client.noarch: W: invalid-url URL: https://github.com/php-fig/http-client <urlopen error [Errno -2] Name or service not known>
>1 packages and 0 specfiles checked; 0 errors, 2 warnings.
>
>
>
>Source checksums
>----------------
>https://github.com/php-fig/http-client/archive/496a823ef742b632934724bf769560c2a5c7c44e/php-psr-http-client-1.0.0-496a823ef742b632934724bf769560c2a5c7c44e.tar.gz :
>  CHECKSUM(SHA256) this package     : 45ca159873137bfd255281811451aebe936a855e40571df6aef6a9b7713b2d6e
>  CHECKSUM(SHA256) upstream package : 45ca159873137bfd255281811451aebe936a855e40571df6aef6a9b7713b2d6e
>
>
>Requires
>--------
>php-psr-http-client (rpmlib, GLIBC filtered):
>    (php-composer(psr/http-message) >= 1.0 with php-composer(psr/http-message) < 2)
>    php(language)
>    php-composer(fedora/autoloader)
>
>
>
>Provides
>--------
>php-psr-http-client:
>    php-composer(psr/http-client)
>    php-psr-http-client
>
>
>
>Generated by fedora-review 0.7.3 (44b83c7) last change: 2019-09-18
>Command line :/usr/bin/fedora-review --mock-config fedora-rawhide-x86_64 --bug 1769417
>Buildroot used: fedora-rawhide-{{ target_arch }}
>Active plugins: Generic, Shell-api, PHP
>Disabled plugins: C/C++, R, Haskell, Java, Perl, SugarActivity, Ocaml, fonts, Python
>Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

Actions: View

Attachments on bug 1769417: 1639558 | 1639559