Attachment 1665630 Details for Bug 1806810 – review.txt

review.txt

review.txt (text/plain), 8.54 KB, created by Remi Collet on 2020-02-25 12:29:58 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Remi Collet

Created: 2020-02-25 12:29:58 UTC

Size: 8.54 KB

patch

obsolete

>Package Review
>==============
>
>Legend:
>[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
>[ ] = Manual review needed
>
>
>
>===== MUST items =====
>
>Generic:
>[x]: Package is licensed with an open-source compatible license and meets
>     other legal requirements as defined in the legal section of Packaging
>     Guidelines.
>[x]: License field in the package spec file matches the actual license.
>     Note: Checking patched sources after %prep for licenses. Licenses
>     found: "Unknown or generated". 10 files have unknown license. Detailed
>     output of licensecheck in /home/extras/SPECS/review/1806810-php-
>     webflo-drupal-finder/licensecheck.txt
>[x]: Package contains no bundled libraries without FPC exception.
>[x]: Changelog in prescribed format.
>[x]: Sources contain only permissible code or content.
>[-]: Package contains desktop file if it is a GUI application.
>[-]: Development files must be in a -devel package
>[x]: Package uses nothing in %doc for runtime.
>[x]: Package consistently uses macros (instead of hard-coded directory
>     names).
>[x]: Package is named according to the Package Naming Guidelines.
>[x]: Package does not generate any conflict.
>[x]: Package obeys FHS, except libexecdir and /usr/target.
>[-]: If the package is a rename of another package, proper Obsoletes and
>     Provides are present.
>[x]: Requires correct, justified where necessary.
>[x]: Spec file is legible and written in American English.
>[-]: Package contains systemd file(s) if in need.
>[x]: Package is not known to require an ExcludeArch tag.
>[x]: Large documentation must go in a -doc subpackage. Large could be size
>     (~1MB) or number of files.
>     Note: Documentation size is 10240 bytes in 2 files.
>[x]: Package complies to the Packaging Guidelines
>[x]: Package successfully compiles and builds into binary rpms on at least
>     one supported primary architecture.
>[x]: Package installs properly.
>[x]: Rpmlint is run on all rpms the build produces.
>     Note: There are rpmlint messages (see attachment).
>[x]: If (and only if) the source package includes the text of the
>     license(s) in its own file, then that file, containing the text of the
>     license(s) for the package is included in %license.
>[x]: Package requires other packages for directories it uses.
>[x]: Package must own all directories that it creates.
>[x]: Package does not own files or directories owned by other packages.
>[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
>[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
>     beginning of %install.
>[x]: Macros in Summary, %description expandable at SRPM build time.
>[x]: Dist tag is present.
>[x]: Package does not contain duplicates in %files.
>[x]: Permissions on files are set properly.
>[x]: Package must not depend on deprecated() packages.
>[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
>     work.
>[x]: Package is named using only allowed ASCII characters.
>[x]: Package does not use a name that already exists.
>[x]: Package is not relocatable.
>[x]: Sources used to build the package match the upstream source, as
>     provided in the spec URL.
>[x]: Spec file name must match the spec package %{name}, in the format
>     %{name}.spec.
>[x]: File names are valid UTF-8.
>[x]: Packages must not store files under /srv, /opt or /usr/local
>
>===== SHOULD items =====
>
>Generic:
>[x]: If the source package does not include license text(s) as a separate
>     file from upstream, the packager SHOULD query upstream to include it.
>[x]: Final provides and requires are sane (see attachments).
>[x]: Package functions as described.
>[x]: Latest version is packaged.
>[x]: Package does not include license text files separate from upstream.
>[x]: Patches link to upstream bugs/comments/lists or are otherwise
>     justified.
>[-]: Sources are verified with gpgverify first in %prep if upstream
>     publishes signatures.
>     Note: gpgverify is not used.
>[x]: Description and summary sections in the package spec file contains
>     translations for supported Non-English languages, if available.
>[x]: Package should compile and build into binary rpms on all supported
>     architectures.
>[x]: %check is present and all tests pass.
>[x]: Packages should try to preserve timestamps of original installed
>     files.
>[x]: Reviewer should test that the package builds in mock.
>[x]: Buildroot is not present
>[x]: Package has no %clean section with rm -rf %{buildroot} (or
>     $RPM_BUILD_ROOT)
>[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
>[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
>[x]: Sources can be downloaded from URI in Source: tag
>[x]: SourceX is a working URL.
>[x]: Spec use %global instead of %define unless justified.
>
>===== EXTRA items =====
>
>Generic:
>[x]: Rpmlint is run on all installed packages.
>     Note: There are rpmlint messages (see attachment).
>[x]: Spec file according to URL is the same as in SRPM.
>
>PHP:
>[x]: Run phpci static analyze on all php files.
>     Note:  Fatal error: Uncaught TypeError: Argument 2 passed to
>     Symfony\Component\Console\Output\StreamOutput::__construct() must be
>     of the type int, null given, called in
>     /usr/share/php/Bartlett/Reflect/Console/Application.php on line 228
>     and defined in
>     /usr/share/php/Symfony4/Component/Console/Output/StreamOutput.php:43
>     Stack trace: #0
>     /usr/share/php/Bartlett/Reflect/Console/Application.php(228):
>     Symfony\Component\Console\Output\StreamOutput->__construct(Resource id
>     #322, NULL, false) #1 /usr/bin/phpcompatinfo(22):
>     Bartlett\Reflect\Console\Application->run() #2 {main} thrown in
>     /usr/share/php/Symfony4/Component/Console/Output/StreamOutput.php on
>     line 43 phpCompatInfo version 5.2.1 DB version 2.10.0 built Jan 27
>     2020 16:18:23 CET static analyze results in
>     /home/extras/SPECS/review/1806810-php-webflo-drupal-finder/phpci.log
>
>
>Rpmlint
>-------
>Checking: php-webflo-drupal-finder-1.2.0-1.fc32.noarch.rpm
>          php-webflo-drupal-finder-1.2.0-1.fc32.src.rpm
>php-webflo-drupal-finder.noarch: W: spelling-error %description -l en_US Autoloader -> Auto loader, Auto-loader, Freeloader
>php-webflo-drupal-finder.noarch: W: spelling-error %description -l en_US autoload -> auto load, auto-load, tautology
>php-webflo-drupal-finder.src: W: spelling-error %description -l en_US Autoloader -> Auto loader, Auto-loader, Freeloader
>php-webflo-drupal-finder.src: W: spelling-error %description -l en_US usr -> use, us, user
>php-webflo-drupal-finder.src: W: spelling-error %description -l en_US autoload -> auto load, auto-load, tautology
>2 packages and 0 specfiles checked; 0 errors, 5 warnings.
>
>
>
>
>Rpmlint (installed packages)
>----------------------------
>perl: warning: Setting locale failed.
>perl: warning: Please check that your locale settings:
>	LANGUAGE = (unset),
>	LC_ALL = (unset),
>	LC_CTYPE = "C.UTF-8",
>	LANG = "fr_FR.UTF-8"
>    are supported and installed on your system.
>perl: warning: Falling back to the standard locale ("C").
>perl: warning: Setting locale failed.
>perl: warning: Please check that your locale settings:
>	LANGUAGE = (unset),
>	LC_ALL = (unset),
>	LC_CTYPE = "C.UTF-8",
>	LANG = "fr_FR.UTF-8"
>    are supported and installed on your system.
>perl: warning: Falling back to the standard locale ("C").
>php-webflo-drupal-finder.noarch: W: spelling-error %description -l en_US Autoloader -> Auto loader, Auto-loader, Freeloader
>php-webflo-drupal-finder.noarch: W: spelling-error %description -l en_US autoload -> auto load, auto-load, tautology
>php-webflo-drupal-finder.noarch: W: invalid-url URL: https://github.com/webflo/drupal-finder <urlopen error [Errno -2] Name or service not known>
>1 packages and 0 specfiles checked; 0 errors, 3 warnings.
>
>
>
>Source checksums
>----------------
>https://github.com/webflo/drupal-finder/archive/123e248e14ee8dd3fbe89fb5a733a6cf91f5820e/php-webflo-drupal-finder-1.2.0-123e248e14ee8dd3fbe89fb5a733a6cf91f5820e.tar.gz :
>  CHECKSUM(SHA256) this package     : 05ba6d56128df6d75418cdc97c3a4dcc5584a80a7b702c3fe1afef419372d969
>  CHECKSUM(SHA256) upstream package : 05ba6d56128df6d75418cdc97c3a4dcc5584a80a7b702c3fe1afef419372d969
>
>
>Requires
>--------
>php-webflo-drupal-finder (rpmlib, GLIBC filtered):
>    php(language)
>    php-composer(fedora/autoloader)
>    php-json
>
>
>
>Provides
>--------
>php-webflo-drupal-finder:
>    php-composer(webflo/drupal-finder)
>    php-webflo-drupal-finder
>
>
>
>Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16
>Command line :/usr/bin/fedora-review -b 1806810
>Buildroot used: fedora-rawhide-x86_64
>Active plugins: Shell-api, PHP, Generic
>Disabled plugins: Python, Java, R, C/C++, SugarActivity, Ocaml, Perl, Haskell, fonts
>Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

Actions: View

Attachments on bug 1806810: 1665630