Attachment 1694100 Details for Bug 1831158 – quick patch for this issue

[patch] quick patch for this issue

0013-lanplus-cipher-retry.patch (text/plain), 1.36 KB, created by Vaclav Dolezal on 2020-06-01 13:48:21 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Vaclav Dolezal

Created: 2020-06-01 13:48:21 UTC

Size: 1.36 KB

patch

obsolete

>From 08268f32a241d5dacfd8c95aee4ebbd59d0a078d Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?V=C3=A1clav=20Dole=C5=BEal?= <vdolezal@redhat.com>
>Date: Thu, 28 May 2020 13:32:31 +0200
>Subject: [PATCH] lanplus: don't retry pre-session Get cipher suites
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>Some BMCs are ignoring it, causing needless delay.
>
>Signed-off-by: VÃ¡clav DoleÅ¾al <vdolezal@redhat.com>
>---
> src/plugins/lanplus/lanplus.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
>diff --git a/src/plugins/lanplus/lanplus.c b/src/plugins/lanplus/lanplus.c
>index 3087348..c442c0e 100644
>--- a/src/plugins/lanplus/lanplus.c
>+++ b/src/plugins/lanplus/lanplus.c
>@@ -3459,9 +3459,13 @@ ipmi_find_best_cipher_suite(struct ipmi_intf *intf)
> 	};
> 	const size_t nr_preferred = ARRAY_SIZE(cipher_order_preferred);
> 	size_t ipref, i;
>+	int rc;
>+	int retry_old = intf->ssn_params.retry;
> 
>-	if (ipmi_get_channel_cipher_suites(intf, "ipmi", IPMI_LAN_CHANNEL_E,
>-	                                   suites, &nr_suites) < 0)
>+	ipmi_intf_session_set_retry(intf, 1);
>+	rc = ipmi_get_channel_cipher_suites(intf, "ipmi", IPMI_LAN_CHANNEL_E, suites, &nr_suites);
>+	ipmi_intf_session_set_retry(intf, retry_old);
>+	if (rc < 0)
> 	{
> 		/* default legacy behavior - cipher suite 3 if none is requested */
> 		return IPMI_LANPLUS_CIPHER_SUITE_3;
>-- 
>2.25.4
>

Actions: View | Diff

Attachments on bug 1831158: 1694100