Attachment 174081 Details for Bug 257281 – Patch fixing buffer overflow replacing sprintf with snprintf.

[patch] Patch fixing buffer overflow replacing sprintf with snprintf.

xisdnload-fix-segfault.patch (text/plain), 1.19 KB, created by Flavio Leitner on 2007-08-27 18:21:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Flavio Leitner

Created: 2007-08-27 18:21:23 UTC

Size: 1.19 KB

patch

obsolete

>Index: isdn4k-utils-CVS-2006-07-20/xisdnload/xisdnload.c
>===================================================================
>--- isdn4k-utils-CVS-2006-07-20.orig/xisdnload/xisdnload.c
>+++ isdn4k-utils-CVS-2006-07-20/xisdnload/xisdnload.c
>@@ -399,7 +399,7 @@ XtPointer call_data;	/* pointer to (doub
>       tm = localtime(&t);
>       sprintf(now, "%.2d:%.2d:%.2d", tm->tm_hour, tm->tm_min, tm->tm_sec);
>       sprintf(f, "%s%%s", label_format);
>-      sprintf(s, f, num,
>+      snprintf(s, 120, f, num,
> 	      secs_running / 60, secs_running % 60, cps,
> 	      bytes_total / 1024, history, now);
>       XtSetArg (args[0], XtNlabel, s);
>@@ -414,12 +414,12 @@ XtPointer call_data;	/* pointer to (doub
> 	  sprintf(now, "%.2d:%.2d:%.2d", tm->tm_hour, tm->tm_min, tm->tm_sec);
> 	  strcat(history, now);
> 	  strcat(history, " ");
>-	  sprintf(s, label_format, "offline",
>+	  snprintf(s, 120, label_format, "offline",
> 		  secs_running / 60, secs_running % 60,
> 		  (double)bytes_total / (double)secs_running,
> 		  bytes_total / 1024, history);
> 	} else {
>-	  sprintf(s, "uninitialized %s", history);
>+	  snprintf(s, 120, "uninitialized %s", history);
> 	}
> 	XtSetArg (args[0], XtNlabel, s);
> 	XtSetValues (label_wid, args, ONE);

Actions: View | Diff

Attachments on bug 257281: 174081