Attachment 1789780 Details for Bug 1917269 – Patch

[patch] Patch

0008-bgp-ttl-security.patch (text/plain), 1.56 KB, created by Michal Ruprich on 2021-06-10 08:51:33 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Michal Ruprich

Created: 2021-06-10 08:51:33 UTC

Size: 1.56 KB

patch

obsolete

>From 8a66632391db5f5181a4afef6aae41f48bee7fdb Mon Sep 17 00:00:00 2001
>From: Donald Sharp <sharpd@nvidia.com>
>Date: Fri, 15 Jan 2021 08:14:49 -0500
>Subject: [PATCH] bgpd: Allow peer-groups to have `ttl-security hops`
> configured
>
>The command `neighbor PGROUP ttl-security hops X` was being
>accepted but ignored.  Allow it to be stored.  I am still
>not sure that this is applied correctly, but that is another
>problem.
>
>Fixes: #7848
>Signed-off-by: Donald Sharp <sharpd@nvidia.com>
>---
> bgpd/bgpd.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
>diff --git a/bgpd/bgpd.c b/bgpd/bgpd.c
>index 9297ec4711c..4ebd3da0620 100644
>--- a/bgpd/bgpd.c
>+++ b/bgpd/bgpd.c
>@@ -7150,6 +7150,7 @@ int is_ebgp_multihop_configured(struct peer *peer)
> int peer_ttl_security_hops_set(struct peer *peer, int gtsm_hops)
> {
> 	struct peer_group *group;
>+	struct peer *gpeer;
> 	struct listnode *node, *nnode;
> 	int ret;
> 
>@@ -7186,9 +7187,10 @@ int peer_ttl_security_hops_set(struct peer *peer, int gtsm_hops)
> 				return ret;
> 		} else {
> 			group = peer->group;
>+			group->conf->gtsm_hops = gtsm_hops;
> 			for (ALL_LIST_ELEMENTS(group->peer, node, nnode,
>-					       peer)) {
>-				peer->gtsm_hops = group->conf->gtsm_hops;
>+					       gpeer)) {
>+				gpeer->gtsm_hops = group->conf->gtsm_hops;
> 
> 				/* Calling ebgp multihop also resets the
> 				 * session.
>@@ -7198,7 +7200,7 @@ int peer_ttl_security_hops_set(struct peer *peer, int gtsm_hops)
> 				 * value is
> 				 * irrelevant.
> 				 */
>-				peer_ebgp_multihop_set(peer, MAXTTL);
>+				peer_ebgp_multihop_set(gpeer, MAXTTL);
> 			}
> 		}
> 	} else {

Actions: View | Diff

Attachments on bug 1917269: 1789780