Attachment 179241 Details for Bug 263961 – Always add a reference when returning an AuEvent attribute value

[patch] Always add a reference when returning an AuEvent attribute value

audit-1.6-pyauparse.patch (text/plain), 1.33 KB, created by Miloslav Trmač on 2007-08-29 16:15:29 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Miloslav Trmač

Created: 2007-08-29 16:15:29 UTC

Size: 1.33 KB

patch

obsolete

>diff -ur /home/mitr/a/audit-1.6/bindings/python/auparse_python.c audit-1.6/bindings/python/auparse_python.c
>--- /home/mitr/a/audit-1.6/bindings/python/auparse_python.c	2007-05-30 22:37:40.000000000 +0200
>+++ audit-1.6/bindings/python/auparse_python.c	2007-08-29 18:03:35.000000000 +0200
>@@ -57,8 +57,8 @@
> {
>     if (self->sec == NULL) {
>         if ((self->sec = PyInt_FromLong(self->event.sec)) == NULL) return NULL;
>-        Py_INCREF(self->sec);
>     }
>+    Py_INCREF(self->sec);
>     return self->sec;
> }
> 
>@@ -67,8 +67,8 @@
> {
>     if (self->milli == NULL) {
>         if ((self->milli = PyInt_FromLong(self->event.milli)) == NULL) return NULL;
>-        Py_INCREF(self->milli);
>     }
>+    Py_INCREF(self->milli);
>     return self->milli;
> }
> 
>@@ -77,8 +77,8 @@
> {
>     if (self->serial == NULL) {
>         if ((self->serial = PyInt_FromLong(self->event.serial)) == NULL) return NULL;
>-        Py_INCREF(self->serial);
>     }
>+    Py_INCREF(self->serial);
>     return self->serial;
> }
> 
>@@ -88,7 +88,9 @@
>     if (self->event.host == NULL) {
>         Py_RETURN_NONE;
>     } else {
>-        if ((self->host = PyString_FromString(self->event.host)) == NULL) return NULL;
>+	if (self->host == NULL) {
>+	    if ((self->host = PyString_FromString(self->event.host)) == NULL) return NULL;
>+	}
>         Py_INCREF(self->host);
>         return self->host;
>     }

Actions: View | Diff

Attachments on bug 263961: 179241