Attachment 181601 Details for Bug 251978 – patch to hide device from the poll list during netpoll operations to avoid net_rx_action races

[patch] patch to hide device from the poll list during netpoll operations to avoid net_rx_action races

netpoll.patch (text/plain), 975 bytes, created by Neil Horman on 2007-08-30 18:54:38 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Neil Horman

Created: 2007-08-30 18:54:38 UTC

Size: 975 bytes

patch

obsolete

>diff -up linux-2.6.9/net/core/netpoll.c.orc linux-2.6.9/net/core/netpoll.c
>--- linux-2.6.9/net/core/netpoll.c.orc	2007-08-30 14:43:35.000000000 -0400
>+++ linux-2.6.9/net/core/netpoll.c	2007-08-30 14:52:06.000000000 -0400
>@@ -24,6 +24,7 @@
> #include <linux/reboot.h>
> #include <linux/rcupdate.h>
> #include <linux/workqueue.h>
>+#include <linux/list.h>
> #include <net/tcp.h>
> #include <net/udp.h>
> #include <asm/unaligned.h>
>@@ -133,6 +134,18 @@ void netpoll_poll_dev(struct net_device 
> 
> 	/* Process pending work on NIC */
> 	dev->poll_controller(dev);
>+	/*
>+	 * Check to see if we added ourselves to the poll 
>+	 * list from the poll controller.  If we did
>+	 * lets remove it again to avoid a race with net_rx_action
>+	 * here. yes, a bit of a hack but neat and self contained
>+	 */
>+	local_irq_disable();
>+	if (!list_empty(&dev->poll_list)) {
>+		list_del(&dev->poll_list);
>+		INIT_LIST_HEAD(&dev->poll_list);	
>+	}
>+	local_irq_enable();
> 	if (dev->poll)
> 		poll_napi(dev);
>

Actions: View | Diff

Attachments on bug 251978: 161198 | 181601 | 183141 | 183961 | 185531 | 185541 | 186681 | 187461 | 187831 | 189261 | 190311 | 190351 | 194551