Attachment 183321 Details for Bug 239727 – Adding a LogVolData class for the new options.

[patch] Adding a LogVolData class for the new options.

pykickstartMirroring.patch (text/plain), 4.70 KB, created by Joel Andres Granados on 2007-08-31 13:32:50 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Joel Andres Granados

Created: 2007-08-31 13:32:50 UTC

Size: 4.70 KB

patch

obsolete

>diff -ur --exclude=partition.py pykickstart-1.8/pykickstart/commands/logvol.py pykickstart-1.8-Mirroring/pykickstart/commands/logvol.py
>--- pykickstart-1.8/pykickstart/commands/logvol.py	2007-08-09 20:51:38.000000000 +0200
>+++ pykickstart-1.8-Mirroring/pykickstart/commands/logvol.py	2007-08-31 15:04:41.000000000 +0200
>@@ -89,6 +89,30 @@
> 
>         return retval + "\n"
> 
>+class F8_LogVolData(FC4_LogVolData):
>+    def __init__(self, bytesPerInode=4096, fsopts="", fstype="", grow=False,
>+                 maxSizeMB=0, name="", format=True, percent=0,
>+                 recommended=False, size=None, preexist=False, vgname="",
>+                 mountpoint="", mirrors=0, devs=[], nocorelog=True):
>+        FC4_LogVolData.__init__(self, bytesPerInode=bytesPerInode, fsopts=fsopts, fstype=fstype, grow=grow,
>+                        maxSizeMB=maxSizeMB, name=name, format=format, percent=percent, recommended=recommended,
>+                        size=size, preexist=preexist, vgname=vgname, mountpoint=mountpoint)
>+        self.mirrors = mirrors
>+        self.devs = devs
>+        self.nocorelog = nocorelog
>+
>+    def __str__(self):
>+        retval = FC4_LogVolData.__str__(self).strip()
>+
>+        if self.mirrors > 0:
>+            retval += " --mirrors=%d" % self.mirrors
>+        if self.nocorelog:
>+            retval += " --nocorelog"
>+        if self.devs > 0:
>+            retval += " --devs=%s"%",".join(self.devs)
>+
>+        return retval + "\n"
>+
> class FC3_LogVol(KickstartCommand):
>     def __init__(self, writePriority=132, lvList=None):
>         KickstartCommand.__init__(self, writePriority)
>@@ -183,3 +207,54 @@
>         self._setToObj(op, opts, lvd)
>         lvd.mountpoint=extra[0]
>         self.add(lvd)
>+
>+class F8_LogVol(FC4_LogVol):
>+    def __init__(self, writePriority=132, lvList=None):
>+        FC4_LogVol.__init__(self, writePriority, lvList)
>+
>+    def parse(self, args):
>+        def lv_cb (option, opt_str, value, parser):
>+            parser.values.format = False
>+            parser.values.preexist = True
>+
>+        def dev_cb (option, opt_str, value, parser):
>+            for d in value.split(','):
>+                parser.values.ensure_value(option.dest, []).append(d)
>+
>+        op = KSOptionParser(lineno=self.lineno)
>+        op.add_option("--bytes-per-inode", dest="bytesPerInode", action="store",
>+                      type="int", nargs=1)
>+        op.add_option("--fsoptions", dest="fsopts")
>+        op.add_option("--fstype", dest="fstype")
>+        op.add_option("--grow", dest="grow", action="store_true",
>+                      default=False)
>+        op.add_option("--maxsize", dest="maxSizeMB", action="store", type="int",
>+                      nargs=1)
>+        op.add_option("--name", dest="name", required=1)
>+        op.add_option("--noformat", action="callback", callback=lv_cb,
>+                      dest="format", default=True, nargs=0)
>+        op.add_option("--percent", dest="percent", action="store", type="int",
>+                      nargs=1)
>+        op.add_option("--recommended", dest="recommended", action="store_true",
>+                      default=False)
>+        op.add_option("--size", dest="size", action="store", type="int",
>+                      nargs=1)
>+        op.add_option("--useexisting", dest="preexist", action="store_true",
>+                      default=False)
>+        op.add_option("--vgname", dest="vgname", required=1)
>+        op.add_option("--mirrors", "-m", dest="mirrors", type="int", action="store",
>+                      nargs=1, default=0)
>+        op.add_option("--devs", dest="devs", type="string", action="callback",
>+                      callback=dev_cb, nargs=1, default=[])
>+        op.add_option("--nocorelog", dest="nocorelog",  action="store_true", default=False)
>+
>+        (opts, extra) = op.parse_args(args=args)
>+
>+        if len(extra) == 0:
>+            raise KickstartValueError, formatErrorMsg(self.lineno, msg=_("Mount point required for %s") % "logvol")
>+
>+        lvd = F8_LogVolData()
>+        self._setToObj(op, opts, lvd)
>+        lvd.mountpoint=extra[0]
>+        lvd.corelog = not lvd.nocorelog
>+        self.add(lvd)
>diff -ur --exclude=partition.py pykickstart-1.8/pykickstart/handlers/control.py pykickstart-1.8-Mirroring/pykickstart/handlers/control.py
>--- pykickstart-1.8/pykickstart/handlers/control.py	2007-08-09 20:51:38.000000000 +0200
>+++ pykickstart-1.8-Mirroring/pykickstart/handlers/control.py	2007-08-31 14:00:07.000000000 +0200
>@@ -321,7 +321,7 @@
>         "keyboard": keyboard.FC3_Keyboard,
>         "lang": lang.FC3_Lang,
>         "logging": logging.FC6_Logging,
>-        "logvol": logvol.FC4_LogVol,
>+        "logvol": logvol.F8_LogVol,
>         "mediacheck": mediacheck.FC4_MediaCheck,
>         "monitor": monitor.FC6_Monitor,
>         "multipath": multipath.FC6_MultiPath,

Actions: View | Diff

Attachments on bug 239727: 174121 | 174161 | 174181 | 175081 | 175101 | 183321 | 183341