Login
[x]
Log in using an account from:
Fedora Account System
Red Hat Associate
Red Hat Customer
Or login using a Red Hat Bugzilla account
Forgot Password
Login:
Hide Forgot
Create an Account
Red Hat Bugzilla – Attachment 187831 Details for
Bug 251978
kernel panic : kernel BUG at include/linux/netdevice.h:888!
[?]
New
Simple Search
Advanced Search
My Links
Browse
Requests
Reports
Current State
Search
Tabular reports
Graphical reports
Duplicates
Other Reports
User Changes
Plotly Reports
Bug Status
Bug Severity
Non-Defaults
|
Product Dashboard
Help
Page Help!
Bug Writing Guidelines
What's new
Browser Support Policy
5.0.4.rh83 Release notes
FAQ
Guides index
User guide
Web Services
Contact
Legal
This site requires JavaScript to be enabled to function correctly, please enable it.
[patch]
revised version of my alternate patch
netpoll.patch (text/plain), 2.83 KB, created by
Neil Horman
on 2007-09-05 18:14:10 UTC
(
hide
)
Description:
revised version of my alternate patch
Filename:
MIME Type:
Creator:
Neil Horman
Created:
2007-09-05 18:14:10 UTC
Size:
2.83 KB
patch
obsolete
>--- linux-2.6.9/include/linux/netdevice.h.orig 2007-09-05 07:27:45.000000000 -0400 >+++ linux-2.6.9/include/linux/netdevice.h 2007-09-05 07:48:41.000000000 -0400 >@@ -238,7 +238,8 @@ enum netdev_state_t > __LINK_STATE_SCHED, > __LINK_STATE_NOCARRIER, > __LINK_STATE_RX_SCHED, >- __LINK_STATE_LINKWATCH_PENDING >+ __LINK_STATE_LINKWATCH_PENDING, >+ __LINK_STATE_NETPOLL_SERVICED > }; > > >@@ -886,6 +887,8 @@ static inline void netif_rx_complete(str > { > unsigned long flags; > >+ if (test_bit(__LINK_STATE_NETPOLL_SERVICED, &dev->state)) >+ return; > local_irq_save(flags); > BUG_ON(!test_bit(__LINK_STATE_RX_SCHED, &dev->state)); > list_del(&dev->poll_list); >@@ -913,6 +916,8 @@ static inline void netif_poll_enable(str > */ > static inline void __netif_rx_complete(struct net_device *dev) > { >+ if ((test_bit(__LINK_STATE_NETPOLL_SERVICED, &dev->state)) >+ return; > BUG_ON(!test_bit(__LINK_STATE_RX_SCHED, &dev->state)); > list_del(&dev->poll_list); > smp_mb__before_clear_bit(); >--- linux-2.6.9/net/core/netpoll.c.orig 2007-09-05 07:28:44.000000000 -0400 >+++ linux-2.6.9/net/core/netpoll.c 2007-09-05 12:12:08.000000000 -0400 >@@ -94,9 +94,15 @@ static void poll_napi(struct net_device > return; > npinfo = ndw->npinfo; > >- if (test_bit(__LINK_STATE_RX_SCHED, &dev->state) && >- npinfo->poll_owner != smp_processor_id() && >+ if (npinfo->poll_owner != smp_processor_id() && > spin_trylock(&npinfo->poll_lock)) { >+ /* net_rx_action already got to us */ >+ if (!test_bit(__LINK_STATE_RX_SCHED, &dev->state)) >+ goto skip; >+ /* >+ * This gets cleared in net_rx_action >+ */ >+ set_bit(__LINK_STATE_NETPOLL_SERVICED, &dev->state); > npinfo->rx_flags |= NETPOLL_RX_DROP; > atomic_inc(&trapped); > >@@ -104,6 +110,7 @@ static void poll_napi(struct net_device > > atomic_dec(&trapped); > npinfo->rx_flags &= ~NETPOLL_RX_DROP; >+ skip: > spin_unlock(&npinfo->poll_lock); > } > } >--- linux-2.6.9/net/core/dev.c.orig 2007-09-05 07:34:57.000000000 -0400 >+++ linux-2.6.9/net/core/dev.c 2007-09-05 08:07:36.000000000 -0400 >@@ -1836,6 +1836,26 @@ static void net_rx_action(struct softirq > > have = netpoll_poll_lock(dev); > >+ if (test_and_clear_bit(__LINK_STATE_NETPOLL_SERVICED, &dev->state)) { >+ /* >+ * Seeing this bit set indicates that the netpoll code >+ * has handled this devices poll routine despite the fact >+ * that we have it on this cpu's poll_list. Lets do >+ * some fixup here to ensure that we don't have any >+ * inconsistent state. >+ */ >+ list_del(&dev->poll_list); >+ clear_bit(__LINK_STATE_RX_SCHED, &dev->state); >+ /* >+ * Check to see if any pending frames have come in >+ * while we were mucking about. If they have lets reschedule >+ * this device >+ */ >+ if (dev->quota > 0) >+ netif_rx_schedule(dev); >+ continue; >+ } >+ > if (dev->quota <= 0 || dev->poll(dev, &budget)) { > netpoll_poll_unlock(have); > local_irq_disable();
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 251978
:
161198
|
181601
|
183141
|
183961
|
185531
|
185541
|
186681
|
187461
|
187831
|
189261
|
190311
|
190351
|
194551