Attachment 1960415 Details for Bug 2190055 – Patch seemingly fixing the crash

[patch] Patch seemingly fixing the crash

0001-client-fix-crash-while-recalculating-layers.patch (text/plain), 1.29 KB, created by Jonathan Buch on 2023-04-27 14:47:06 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Buch

Created: 2023-04-27 14:47:06 UTC

Size: 1.29 KB

patch

obsolete

>From 1dea8514442ce7b51af6b535b3e65988ee1efa6d Mon Sep 17 00:00:00 2001
>From: Jonathan Buch <jbuch@synyx.de>
>Date: Thu, 27 Apr 2023 15:12:38 +0200
>Subject: [PATCH 1/3] client, fix crash while recalculating layers
>
>* list is modified while iterating which leads to bad data
>---
> openbox/client.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
>diff --git a/openbox/client.c b/openbox/client.c
>index 3ff278ae..be25681c 100644
>--- a/openbox/client.c
>+++ b/openbox/client.c
>@@ -2722,12 +2722,18 @@ void client_calc_layer(ObClient *self)
> 
>     /* now recalc any windows in the fullscreen layer which have not
>        had their layer recalced already */
>+    GList *to_recalc = NULL;
>     for (; it; it = g_list_next(it)) {
>         if (window_layer(it->data) < OB_STACKING_LAYER_FULLSCREEN) break;
>         else if (WINDOW_IS_CLIENT(it->data) &&
>                  !WINDOW_AS_CLIENT(it->data)->visited)
>-            client_calc_layer_internal(it->data);
>+            to_recalc = g_list_append(to_recalc, it->data);
>     }
>+    // Move recalcing to own loop to not modify the list while iterating
>+    for (GList *x = to_recalc; x; x = g_list_next(x)) {
>+        client_calc_layer_internal(x->data);
>+    }
>+    g_list_free (g_steal_pointer(&to_recalc));
> }
> 
> gboolean client_should_show(ObClient *self)
>-- 
>2.40.0
>

Actions: View | Diff

Attachments on bug 2190055: 1960415