Attachment 1973498 Details for Bug 2216877 – Patch - fix incorrect matching of cached wildcard key

[patch] Patch - fix incorrect matching of cached wildcard key

autofs-5.1.8-fix-incorrect-matching-of-cached-wildcard-key.patch (text/plain), 1.45 KB, created by Ian Kent on 2023-07-01 00:41:15 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Ian Kent

Created: 2023-07-01 00:41:15 UTC

Size: 1.45 KB

patch

obsolete

>autofs-5.1.8 - fix incorrect matching of cached wildcard key
>
>From: Ian Kent <raven@themaw.net>
>
>During the implementation of amd format map entry support the code
>to match a cached key was modified.
>
>Unfortunately there's a case were the key lookup behaves incorrectly.
>
>That case is when there are included maps in the map itself and one
>of the maps (usually the last) has a wildcard key entry. In this case
>the wildcard key may be found during lookup but the map it blongs to
>isn't checked so it can be incorrectly returned instead of a matching
>entry in a subsequent included map.
>
>Signed-off-by: Ian Kent <raven@themaw.net>
>---
> CHANGELOG        |    1 +
> lib/parse_subs.c |    5 ++++-
> 2 files changed, 5 insertions(+), 1 deletion(-)
>
>diff --git a/CHANGELOG b/CHANGELOG
>index afea78aa..a2b59eac 100644
>--- a/CHANGELOG
>+++ b/CHANGELOG
>@@ -91,6 +91,7 @@
> - add ioctlfd open helper.
> - make open files limit configurable.
> - fix some sss error return cases.
>+- fix incorrect matching of cached wildcard key.
> 
> 19/10/2021 autofs-5.1.8
> - add xdr_exports().
>diff --git a/lib/parse_subs.c b/lib/parse_subs.c
>index 0ee00d51..1f96fed6 100644
>--- a/lib/parse_subs.c
>+++ b/lib/parse_subs.c
>@@ -532,8 +532,11 @@ struct mapent *match_cached_key(struct autofs_point *ap,
> 			while ((me = cache_lookup_key_next(me)))
> 				if (me->source == source)
> 					break;
>-			if (!me)
>+			if (!me) {
> 				me = cache_lookup_distinct(mc, "*");
>+				if (me != source)
>+					goto done;
>+			}
> 		}
> 
> 		if (!me)

Actions: View | Diff

Attachments on bug 2216877: 1973498