Attachment 1975460 Details for Bug 2218141 – Hack to lowers the version dependency against openstacksdk from 1.0.0 to 0.101.0

[patch] Hack to lowers the version dependency against openstacksdk from 1.0.0 to 0.101.0

dirty-hack-to-reduce-version-requirements-for-openstacksdk.patch (text/plain), 2.06 KB, created by Jakob Meng on 2023-07-12 19:25:26 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jakob Meng

Created: 2023-07-12 19:25:26 UTC

Size: 2.06 KB

patch

obsolete

>From 0312d11fc6fef49825997e2566d1dbdaf83dcc2b Mon Sep 17 00:00:00 2001
>From: Jakob Meng <code@jakobmeng.de>
>Date: Wed, 12 Jul 2023 20:49:34 +0200
>Subject: [PATCH] Lower version requirements for openstacksdk to satisfy
> dependencies on Fedora 38
>
>Ansible OpenStack collection aka openstack.cloud has two release series,
>1.x.x which is compatible to openstacksdk<0.99.0 and 2.x.x which is
>compatible to openstacksdk>=1.0.0 [0]. Fedora 38 has openstacksdk
>0.101.0, which is why the 2.0.0 prerelease was uploaded. The prerelease
>was meant as a temporary workaround only, it is horrible broken in many
>places. Because we cannot simply bump openstacksdk to 1.0.0 in Fedora
>39, due to other packages depending on this exact version, this patch
>lowers the version requirements for openstacksdk to the version
>available in Fedora 38 which is 0.101.0. This hack is not perfect
>because some code actually requires openstacksdk 1.0.0, but still it
>is a huge improvement over the prerelease code which had half of the
>modules in a broken state [1]. Despite the version bump from 0.101.0
>to 1.0.0, the latter introduces minor changes only. Version 0.99.0 of
>openstacksdk brought the breaking changes actually.
>
>[0] https://opendev.org/openstack/ansible-collections-openstack/src/branch/master/docs/branching.md
>[1] https://bugzilla.redhat.com/show_bug.cgi?id=2218141
>
>Change-Id: Ic922dc4d6e4e7f9f14dde083e7616a11e94bf89d
>---
> plugins/module_utils/openstack.py | 2 +-
> requirements.txt                  | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/plugins/module_utils/openstack.py b/plugins/module_utils/openstack.py
>index 2f36512..c7b4cae 100644
>--- a/plugins/module_utils/openstack.py
>+++ b/plugins/module_utils/openstack.py
>@@ -51,7 +51,7 @@ OVERRIDES = {}
> 
> CUSTOM_VAR_PARAMS = ['min_ver', 'max_ver']
> 
>-MINIMUM_SDK_VERSION = '1.0.0'
>+MINIMUM_SDK_VERSION = '0.101.0'
> MAXIMUM_SDK_VERSION = None
> 
> 
>diff --git a/requirements.txt b/requirements.txt
>index 3d959de..9bb84ac 100644
>--- a/requirements.txt
>+++ b/requirements.txt
>@@ -1 +1 @@
>-openstacksdk>=1.0.0
>+openstacksdk>=0.101.0
>-- 
>2.39.2
>

Actions: View | Diff

Attachments on bug 2218141: 1975460