Attachment 1977361 Details for Bug 1975776 – proposed patch: vfio/pci: hide ROM BAR on SFC9220 10/40G Ethernet Controller PF

[patch] proposed patch: vfio/pci: hide ROM BAR on SFC9220 10/40G Ethernet Controller PF

0001-vfio-pci-hide-ROM-BAR-on-SFC9220-10-40G-Ethernet-Con.patch (text/plain), 1.79 KB, created by Laszlo Ersek on 2023-07-24 20:03:37 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Laszlo Ersek

Created: 2023-07-24 20:03:37 UTC

Size: 1.79 KB

patch

obsolete

>From e4bd4f3d8a2ea8177a94309180b73590daf8bbff Mon Sep 17 00:00:00 2001
>From: Laszlo Ersek <lersek@redhat.com>
>Date: Mon, 24 Jul 2023 21:13:54 +0200
>Subject: [PATCH] vfio/pci: hide ROM BAR on SFC9220 10/40G Ethernet Controller
> PF
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>The SFC9220 physical function's PCI option ROM seems to expose such BIOS
>and UEFI drivers that crash when executed in a virtual machine. Alex
>surmises that these drivers somehow try to access host-physical addresses
>rather than guest-phys ones.
>
>Don't expose the option ROM BAR to the VM by default. While this prevents
>netbooting the VM off the PF (using the card's on-board drivers anyway),
>at least the VM doesn't crash while executing the guest firmware.
>
>(In two years, we've not seen any customer interest in this bug,
>hence no incentive to investigate the faulty oprom drivers.)
>
>Cc: Alex Williamson <alex.williamson@redhat.com> (supporter:VFIO)
>Cc: "CÃ©dric Le Goater" <clg@redhat.com> (supporter:VFIO)
>Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1975776
>Signed-off-by: Laszlo Ersek <lersek@redhat.com>
>---
> hw/vfio/pci-quirks.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/hw/vfio/pci-quirks.c b/hw/vfio/pci-quirks.c
>index f4ff83680572..270eb16b91fa 100644
>--- a/hw/vfio/pci-quirks.c
>+++ b/hw/vfio/pci-quirks.c
>@@ -45,6 +45,10 @@ static const struct {
>     uint32_t device;
> } rom_denylist[] = {
>     { 0x14e4, 0x168e }, /* Broadcom BCM 57810 */
>+    { 0x1924, 0x0a03 }, /* Solarflare Communications
>+                         * SFC9220 10/40G Ethernet Controller
>+                         * https://bugzilla.redhat.com/show_bug.cgi?id=1975776
>+                         */
> };
> 
> bool vfio_opt_rom_in_denylist(VFIOPCIDevice *vdev)
>
>base-commit: 54390c5c409cf8d8314960bc9c8273198233f5e8

Actions: View | Diff

Attachments on bug 1975776: 1977361