Attachment 1983020 Details for Bug 2231148 – The .spec file difference from Copr build 6264267 to 6266495

[patch] The .spec file difference from Copr build 6264267 to 6266495

spec-from-6264267-to-6266495.diff (text/plain), 1.87 KB, created by Fedora Review Service on 2023-08-11 13:57:05 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Fedora Review Service

Created: 2023-08-11 13:57:05 UTC

Size: 1.87 KB

patch

obsolete

>--- https://copr.fedorainfracloud.org/coprs/build/6264267
>+++ https://copr.fedorainfracloud.org/coprs/build/6266495
>@@ -3,15 +3,23 @@
> Name:		nanosvg
> # This thing has no version so we'll use the last commit date
> Version:	20221221
>-Release:	1%{?dist}
>+Release:	2%{?dist}
> License:	Zlib
> # Technically, this is a fork, but the upstream is unmaintained and this one has some fixes
> URL:		https://github.com/fltk/nanosvg
> Source0:	https://github.com/fltk/nanosvg/archive/%{commit}.tar.gz
>+# https://github.com/memononen/nanosvg/pull/246
> Patch0:		nanosvg-sover.patch
>+# Idea taken from here, but their implementation didn't work
>+# https://github.com/memononen/nanosvg/pull/245
>+# using LIB_INSTALL_DIR seems to work better
> Patch1:		nanosvg-lib64.patch
>+# https://github.com/memononen/nanosvg/pull/216
>+Patch2:		nanosvg-build-examples.patch
> Summary:	Simple stupid SVG parser
> BuildRequires:	cmake, gcc
>+# Needed for example1
>+BuildRequires:	libglvnd-devel, glfw-devel >= 3
> 
> %description
> NanoSVG is a simple stupid single-header-file SVG parse. The output of the
>@@ -30,17 +38,25 @@
> %setup -q -n %{name}-%{commit}
> %patch -P0 -p1 -b .sover
> %patch -P1 -p1 -b .lib64
>+%patch -P2 -p1 -b .build-examples
> 
> %build
> %cmake
> %cmake_build
>+pushd example
>+%cmake
>+%cmake_build
>+popd
> 
> %install
> %cmake_install
>+# Note: We do not install the examples, they are not really useful outside of a testing context.
> 
>-# There are no tests. :P
>-# %%check
>-# %%ctest
>+# Use example2 as a smoke test
>+%check
>+pushd example
>+./%{__cmake_builddir}/example2
>+popd
> 
> %files
> %license LICENSE.txt
>@@ -55,6 +71,11 @@
> %{_libdir}/libnanosvgrast.so
> 
> %changelog
>+* Fri Aug 11 2023 Tom Callaway <spot@fedoraproject.org> - 20221221-2
>+- build examples
>+- add comments discussing upstream status of patches
>+- use example2 as a smoke test
>+
> * Thu Aug 10 2023 Tom Callaway <spot@fedoraproject.org> - 20221221-1
> - initial package
>

Actions: View | Diff

Attachments on bug 2231148: 1983020 | 1983040