Attachment 2063776 Details for Bug 2262803 – fedora-review.txt

fedora-review.txt

review.txt (text/plain), 9.24 KB, created by Shawn Iwinski on 2024-12-24 18:17:48 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Shawn Iwinski

Created: 2024-12-24 18:17:48 UTC

Size: 9.24 KB

patch

obsolete

>Package Review
>==============
>
>Legend:
>[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
>[ ] = Manual review needed
>
>
>
>===== MUST items =====
>
>Generic:
>[x]: Package is licensed with an open-source compatible license and meets
>     other legal requirements as defined in the legal section of Packaging
>     Guidelines.
>[x]: License field in the package spec file matches the actual license.
>     Note: Checking patched sources after %prep for licenses. Licenses
>     found: "Unknown or generated", "BSD 3-Clause License", "*No copyright*
>     BSD 3-Clause License". 21 files have unknown license.
>[x]: Package does not own files or directories owned by other packages.
>     Note: Dirs in package are owned also by:
>     /usr/share/php/SebastianBergmann(php-sebastian-complexity3, php-
>     phpunit-php-timer2, php-phpunit-php-timer5, php-sebastian-diff5, php-
>     sebastian-resource-operations2, php-sebastian-code-unit-reverse-
>     lookup, php-phpunit-php-token-stream4, php-sebastian-resource-
>     operations3, php-sebastian-cli-parser2, php-sebastian-code-unit, php-
>     sebastian-type4, php-sebastian-diff4, php-sebastian-lines-of-code,
>     php-sebastian-environment6, php-sebastian-object-reflector4, php-
>     sebastian-recursion-context4, php-sebastian-recursion-context5, php-
>     sebastian-code-unit-reverse-lookup3, php-sebastian-environment5, php-
>     sebastian-version4, php-phpunit-php-file-iterator2, php-sebastian-
>     object-reflector, php-sebastian-code-unit-reverse-lookup2, php-
>     phpunit-php-file-iterator3, php-sebastian-diff3, php-sebastian-code-
>     unit2, php-phpunit-php-invoker2, php-sebastian-recursion-context6,
>     php-phpunit-Version, php-phpunit-php-token-stream3, php-sebastian-
>     environment4, php-phpunit-php-timer6, php-phpunit-php-invoker4, php-
>     sebastian-type3, php-sebastian-complexity, php-sebastian-recursion-
>     context3, php-sebastian-type, php-sebastian-cli-parser, php-sebastian-
>     object-reflector2, php-sebastian-lines-of-code2, php-phpunit-git, php-
>     phpunit-php-timer3, php-sebastian-diff6, php-sebastian-version3, php-
>     phpunit-php-text-template2, php-sebastian-object-reflector3, php-
>     phpunit-php-invoker3, php-phpunit-php-file-iterator4, php-sebastian-
>     global-state2, php-sebastian-type5, php-phpunit-php-text-template3)
>[x]: Package contains no bundled libraries without FPC exception.
>[x]: Changelog in prescribed format.
>[x]: Sources contain only permissible code or content.
>[-]: Package contains desktop file if it is a GUI application.
>[-]: Development files must be in a -devel package
>[x]: Package uses nothing in %doc for runtime.
>[x]: Package consistently uses macros (instead of hard-coded directory
>     names).
>[x]: Package is named according to the Package Naming Guidelines.
>[x]: Package does not generate any conflict.
>[x]: Package obeys FHS, except libexecdir and /usr/target.
>[-]: If the package is a rename of another package, proper Obsoletes and
>     Provides are present.
>[x]: Requires correct, justified where necessary.
>[x]: Spec file is legible and written in American English.
>[-]: Package contains systemd file(s) if in need.
>[x]: Package is not known to require an ExcludeArch tag.
>[x]: Package complies to the Packaging Guidelines
>[x]: Package successfully compiles and builds into binary rpms on at least
>     one supported primary architecture.
>[x]: Package installs properly.
>[x]: Rpmlint is run on all rpms the build produces.
>     Note: There are rpmlint messages (see attachment).
>[x]: If (and only if) the source package includes the text of the
>     license(s) in its own file, then that file, containing the text of the
>     license(s) for the package is included in %license.
>[x]: The License field must be a valid SPDX expression.
>[x]: Package requires other packages for directories it uses.
>[x]: Package must own all directories that it creates.
>[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
>[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
>     beginning of %install.
>[x]: Macros in Summary, %description expandable at SRPM build time.
>[x]: Dist tag is present.
>[x]: Package does not contain duplicates in %files.
>[x]: Permissions on files are set properly.
>[x]: Package must not depend on deprecated() packages.
>[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
>     work.
>[x]: Package is named using only allowed ASCII characters.
>[x]: Package does not use a name that already exists.
>[x]: Package is not relocatable.
>[x]: Sources used to build the package match the upstream source, as
>     provided in the spec URL.
>[x]: Spec file name must match the spec package %{name}, in the format
>     %{name}.spec.
>[x]: File names are valid UTF-8.
>[x]: Large documentation must go in a -doc subpackage. Large could be size
>     (~1MB) or number of files.
>     Note: Documentation size is 5880 bytes in 4 files.
>[x]: Packages must not store files under /srv, /opt or /usr/local
>
>===== SHOULD items =====
>
>Generic:
>[-]: If the source package does not include license text(s) as a separate
>     file from upstream, the packager SHOULD query upstream to include it.
>[x]: Final provides and requires are sane (see attachments).
>[x]: Package functions as described.
>[x]: Latest version is packaged.
>[x]: Package does not include license text files separate from upstream.
>[-]: Sources are verified with gpgverify first in %prep if upstream
>     publishes signatures.
>     Note: gpgverify is not used.
>[-]: Package should compile and build into binary rpms on all supported
>     architectures.
>[x]: %check is present and all tests pass.
>[x]: Packages should try to preserve timestamps of original installed
>     files.
>[x]: Reviewer should test that the package builds in mock.
>[x]: Buildroot is not present
>[x]: Package has no %clean section with rm -rf %{buildroot} (or
>     $RPM_BUILD_ROOT)
>[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
>[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
>[x]: SourceX is a working URL.
>[x]: Spec use %global instead of %define unless justified.
>
>===== EXTRA items =====
>
>Generic:
>[x]: Rpmlint is run on all installed packages.
>     Note: There are rpmlint messages (see attachment).
>[x]: Spec file according to URL is the same as in SRPM.
>
>PHP:
>[x]: Run phpci static analyze on all php files.
>     Note: phpcompatinfo not found. Install php-bartlett-PHP-CompatInfo
>     package to get a more comprehensive php review.
>     See: url: undefined
>
>
>Rpmlint
>-------
>Checking: php-phpunit-php-text-template4-4.0.1-1.fc42.noarch.rpm
>          php-phpunit-php-text-template4-4.0.1-1.fc42.src.rpm
>============================ rpmlint session starts ============================
>rpmlint: 2.5.0
>configuration:
>    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
>    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
>    /etc/xdg/rpmlint/fedora.toml
>    /etc/xdg/rpmlint/scoring.toml
>    /etc/xdg/rpmlint/users-groups.toml
>    /etc/xdg/rpmlint/warn-on-functions.toml
>rpmlintrc: [PosixPath('/tmp/tmph2p_1ej3')]
>checks: 32, packages: 2
>
>php-phpunit-php-text-template4.noarch: E: spelling-error ('Autoloader', '%description -l en_US Autoloader -> Auto loader, Auto-loader, Freeloader')
>php-phpunit-php-text-template4.noarch: E: spelling-error ('autoload', '%description -l en_US autoload -> auto load, auto-load, tautology')
>php-phpunit-php-text-template4.src: E: spelling-error ('Autoloader', '%description -l en_US Autoloader -> Auto loader, Auto-loader, Freeloader')
>php-phpunit-php-text-template4.src: E: spelling-error ('usr', '%description -l en_US usr -> use, us, user')
>php-phpunit-php-text-template4.src: E: spelling-error ('autoload', '%description -l en_US autoload -> auto load, auto-load, tautology')
>php-phpunit-php-text-template4.spec: W: invalid-url Source0: php-phpunit-php-text-template4-4.0.1-3e0404d.tgz
> 2 packages and 0 specfiles checked; 5 errors, 1 warnings, 7 filtered, 5 badness; has taken 1.6 s 
>
>
>
>
>Rpmlint (installed packages)
>----------------------------
>============================ rpmlint session starts ============================
>rpmlint: 2.5.0
>configuration:
>    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
>    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
>    /etc/xdg/rpmlint/fedora.toml
>    /etc/xdg/rpmlint/scoring.toml
>    /etc/xdg/rpmlint/users-groups.toml
>    /etc/xdg/rpmlint/warn-on-functions.toml
>checks: 32, packages: 1
>
>php-phpunit-php-text-template4.noarch: E: spelling-error ('Autoloader', '%description -l en_US Autoloader -> Auto loader, Auto-loader, Freeloader')
>php-phpunit-php-text-template4.noarch: E: spelling-error ('autoload', '%description -l en_US autoload -> auto load, auto-load, tautology')
> 1 packages and 0 specfiles checked; 2 errors, 0 warnings, 3 filtered, 2 badness; has taken 0.6 s 
>
>
>
>Requires
>--------
>php-phpunit-php-text-template4 (rpmlib, GLIBC filtered):
>    php(language)
>    php-spl
>
>
>
>Provides
>--------
>php-phpunit-php-text-template4:
>    php-composer(phpunit/php-text-template)
>    php-phpunit-php-text-template4
>
>
>
>Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
>Command line :/usr/bin/fedora-review --mock-config fedora-rawhide-x86_64 --bug 2262803
>Buildroot used: fedora-rawhide-x86_64
>Active plugins: Generic, PHP, Shell-api
>Disabled plugins: Java, Haskell, Python, Ocaml, fonts, R, C/C++, Perl, SugarActivity
>Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH

Actions: View

Attachments on bug 2262803: 2038774 | 2063776