Attachment 230311 Details for Bug 336601 – fix va_start calls that don't call va_end

[patch] fix va_start calls that don't call va_end

bind-9.5-va_end.patch (text/plain), 1.92 KB, created by Peter Jones on 2007-10-17 19:32:10 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Peter Jones

Created: 2007-10-17 19:32:10 UTC

Size: 1.92 KB

patch

obsolete

>diff -urpN bind-9.5.0a6/bin/named/dbus_service.c.va_end bind-9.5.0a6/bin/named/dbus_service.c
>--- bind-9.5.0a6/bin/named/dbus_service.c.va_end	2007-10-17 14:55:10.000000000 -0400
>+++ bind-9.5.0a6/bin/named/dbus_service.c	2007-10-17 14:56:20.000000000 -0400
>@@ -200,6 +200,7 @@ dbus_svc_add_filter
> 	    }
> 	}
>     }
>+    va_end(va);
>     return( 1 );
> }
> 
>@@ -424,6 +425,7 @@ dbus_svc_message_append_args(DBusConnect
>     if( !dbus_message_append_args_valist( msg, firstType, va ) )
>     {
> 	if( cs->eh != 0L ) (*(cs->eh))("dbus_svc_send: dbus_message_append_args failed");
>+	va_end(va);
> 	return 0;	
>     }
>     va_end(va);
>@@ -488,6 +490,7 @@ dbus_svc_call
> 	va_end(va);
> 	return(0L);
>     }
>+    va_end(va);
>     return reply;
> }
> 
>diff -urpN bind-9.5.0a6/contrib/idn/idnkit-1.0-src/lib/tests/testutil.c.va_end bind-9.5.0a6/contrib/idn/idnkit-1.0-src/lib/tests/testutil.c
>--- bind-9.5.0a6/contrib/idn/idnkit-1.0-src/lib/tests/testutil.c.va_end	2007-10-17 14:55:10.000000000 -0400
>+++ bind-9.5.0a6/contrib/idn/idnkit-1.0-src/lib/tests/testutil.c	2007-10-17 14:57:25.000000000 -0400
>@@ -79,5 +79,6 @@ create_conf_file(const char *filename, u
> 		fputc('\n', file);
> 		
> 	fclose(file);
>+	va_end(ap);
> 	return 1;
> }
>diff -urpN bind-9.5.0a6/contrib/dbus/dbus_service.c.va_end bind-9.5.0a6/contrib/dbus/dbus_service.c
>--- bind-9.5.0a6/contrib/dbus/dbus_service.c.va_end	2007-10-17 14:55:10.000000000 -0400
>+++ bind-9.5.0a6/contrib/dbus/dbus_service.c	2007-10-17 15:00:21.000000000 -0400
>@@ -200,6 +200,7 @@ dbus_svc_add_filter
> 	    }
> 	}
>     }
>+    va_end(va);
>     return( 1 );
> }
> 
>@@ -424,6 +425,7 @@ dbus_svc_message_append_args(DBusConnect
>     if( !dbus_message_append_args_valist( msg, firstType, va ) )
>     {
> 	if( cs->eh != 0L ) (*(cs->eh))("dbus_svc_send: dbus_message_append_args failed");
>+	va_end(va);
> 	return 0;	
>     }
>     va_end(va);
>@@ -488,6 +490,7 @@ dbus_svc_call
> 	va_end(va);
> 	return(0L);
>     }
>+    va_end(va);
>     return reply;
> }
>

Actions: View | Diff

Attachments on bug 336601: 230311 | 233521