Login
[x]
Log in using an account from:
Fedora Account System
Red Hat Associate
Red Hat Customer
Or login using a Red Hat Bugzilla account
Forgot Password
Login:
Hide Forgot
Create an Account
Red Hat Bugzilla – Attachment 233701 Details for
Bug 344851
[firewire] juju stack lacks full support for ohci 1.0 controllers
[?]
New
Simple Search
Advanced Search
My Links
Browse
Requests
Reports
Current State
Search
Tabular reports
Graphical reports
Duplicates
Other Reports
User Changes
Plotly Reports
Bug Status
Bug Severity
Non-Defaults
|
Product Dashboard
Help
Page Help!
Bug Writing Guidelines
What's new
Browser Support Policy
5.0.4.rh83 Release notes
FAQ
Guides index
User guide
Web Services
Contact
Legal
This site requires JavaScript to be enabled to function correctly, please enable it.
[patch]
Stefan's patch to have firewire stack log something about not supporting 1.0 controllers
linux-2.6-firewire-log-unsupported-features.patch (text/plain), 1.72 KB, created by
Jarod Wilson
on 2007-10-22 02:35:38 UTC
(
hide
)
Description:
Stefan's patch to have firewire stack log something about not supporting 1.0 controllers
Filename:
MIME Type:
Creator:
Jarod Wilson
Created:
2007-10-22 02:35:38 UTC
Size:
1.72 KB
patch
obsolete
>Date: Sun, 21 Oct 2007 10:43:11 +0200 (CEST) >From: Stefan Richter <stefanr@s5r6.in-berlin.de> >Subject: firewire: fw-ohci: log a note about unsupported features > >because there seems to be more time needed to implement this. >Also, change related error return values to more appropriate ones. > >Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de> >--- > drivers/firewire/fw-ohci.c | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > >Index: linux/drivers/firewire/fw-ohci.c >=================================================================== >--- linux.orig/drivers/firewire/fw-ohci.c >+++ linux/drivers/firewire/fw-ohci.c >@@ -1472,7 +1472,7 @@ ohci_allocate_iso_context(struct fw_card > /* FIXME: We need a fallback for pre 1.1 OHCI. */ > if (callback == handle_ir_dualbuffer_packet && > ohci->version < OHCI_VERSION_1_1) >- return ERR_PTR(-EINVAL); >+ return ERR_PTR(-ENOSYS); > > spin_lock_irqsave(&ohci->lock, flags); > index = ffs(*mask) - 1; >@@ -1791,7 +1791,7 @@ ohci_queue_iso(struct fw_iso_context *ba > buffer, payload); > else > /* FIXME: Implement fallback for OHCI 1.0 controllers. */ >- return -EINVAL; >+ return -ENOSYS; > } > > static const struct fw_card_driver ohci_driver = { >@@ -1911,7 +1911,12 @@ pci_probe(struct pci_dev *dev, const str > ohci->version = reg_read(ohci, OHCI1394_Version) & 0x00ff00ff; > fw_notify("Added fw-ohci device %s, OHCI version %x.%x\n", > dev->dev.bus_id, ohci->version >> 16, ohci->version & 0xff); >- >+ if (ohci->version < OHCI_VERSION_1_1) { >+ fw_notify(" Isochronous I/O is not yet implemented for " >+ "OHCI 1.0 chips.\n"); >+ fw_notify(" Cameras, audio devices etc. won't work on " >+ "this controller with this driver version.\n"); >+ } > return 0; > > fail_self_id:
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 344851
:
233701
|
257711
|
274231
|
274241
|
275941
|
275971