Attachment 233931 Details for Bug 208726 – Some unclosed fds

[patch] Some unclosed fds

diff (text/plain), 2.93 KB, created by Joel Andres Granados on 2007-10-22 08:04:51 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Joel Andres Granados

Created: 2007-10-22 08:04:51 UTC

Size: 2.93 KB

patch

obsolete

>Index: isys/filtertest.c
>===================================================================
>RCS file: /usr/local/CVS/anaconda/isys/filtertest.c,v
>retrieving revision 1.3
>diff -u -r1.3 filtertest.c
>--- isys/filtertest.c	7 Dec 2001 19:25:29 -0000	1.3
>+++ isys/filtertest.c	22 Oct 2007 07:49:56 -0000
>@@ -38,5 +38,7 @@
> 
>     gzip_close(out);
> 
>+    gunzip_close();
>+
>     return rc;
> }
>Index: loader2/loader.c
>===================================================================
>RCS file: /usr/local/CVS/anaconda/loader2/loader.c,v
>retrieving revision 1.268
>diff -u -r1.268 loader.c
>--- loader2/loader.c	12 Oct 2007 20:05:48 -0000	1.268
>+++ loader2/loader.c	22 Oct 2007 07:49:56 -0000
>@@ -219,6 +219,7 @@
>     }
> 
>     if(!productArch) productArch = strdup("unknown architecture");
>+    fclose(f);
> }
> 
> char * getProductName(void) {
>@@ -1984,6 +1985,7 @@
>             pid = atoi(buf);
>         }
>         kill(pid, SIGUSR1);
>+        fclose(f);
> #endif
>         stop_fw_loader(&loaderData);
>         return rc;
>Index: loader2/method.c
>===================================================================
>RCS file: /usr/local/CVS/anaconda/loader2/method.c,v
>retrieving revision 1.47
>diff -u -r1.47 method.c
>--- loader2/method.c	6 Aug 2007 21:36:52 -0000	1.47
>+++ loader2/method.c	22 Oct 2007 07:49:56 -0000
>@@ -476,6 +476,7 @@
>                 return 0;
>             }
>         }
>+        gunzip_close(fd);
>         rc = chdir(cwd);
>     }
> 
>Index: loader2/modstubs.c
>===================================================================
>RCS file: /usr/local/CVS/anaconda/loader2/modstubs.c,v
>retrieving revision 1.15
>diff -u -r1.15 modstubs.c
>--- loader2/modstubs.c	14 Aug 2007 19:23:41 -0000	1.15
>+++ loader2/modstubs.c	22 Oct 2007 07:49:56 -0000
>@@ -75,6 +75,7 @@
>         
>         *rmObj = 1;
>         file = finalName;
>+        gunzip_close(fd);
>     }
> 
>     return file;
>@@ -150,6 +151,7 @@
>     rc = init_module(modbuf, sb.st_size, options);
>     if (rc != 0)
>         logMessage(WARNING, "failed to insert module (%d)", errno);
>+    close(fd);
>     return rc;
> }
> 
>Index: loader2/modules.c
>===================================================================
>RCS file: /usr/local/CVS/anaconda/loader2/modules.c,v
>retrieving revision 1.66
>diff -u -r1.66 modules.c
>--- loader2/modules.c	1 Oct 2007 19:29:42 -0000	1.66
>+++ loader2/modules.c	22 Oct 2007 07:49:57 -0000
>@@ -71,6 +71,7 @@
>         chptr = strchr(chptr, '\n');
>         if (chptr) chptr++;
>     }
>+    close(fd);
> 
>     return count;
> }
>Index: utils/snarffont.c
>===================================================================
>RCS file: /usr/local/CVS/anaconda/utils/snarffont.c,v
>retrieving revision 1.6
>diff -u -r1.6 snarffont.c
>--- utils/snarffont.c	13 Jun 2005 19:09:24 -0000	1.6
>+++ utils/snarffont.c	22 Oct 2007 07:49:57 -0000
>@@ -46,5 +46,6 @@
>     i = write(1, map, sizeof(map));
>     i = write(1, &d.entry_ct, sizeof(d.entry_ct));
>     i = write(1, descs, d.entry_ct * sizeof(descs[0]));
>+    close(fd);
>     return 0;
> }

Actions: View | Diff

Attachments on bug 208726: 232571 | 232581 | 232621 | 233931 | 234241