Attachment 234001 Details for Bug 204015 – patch to sort IP addresses numerically

[patch] patch to sort IP addresses numerically

ip-compare.patch (text/plain), 1.22 KB, created by Radek Brich on 2007-10-22 09:56:45 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Radek Brich

Created: 2007-10-22 09:56:45 UTC

Size: 1.22 KB

patch

obsolete

>--- system-config-netboot.py	16 Oct 2007 08:58:02 -0000	1.51
>+++ system-config-netboot.py	19 Oct 2007 14:18:46 -0000
>@@ -566,12 +566,26 @@
> 
>     def on_tree_view_selection_changed (self,selection):
>         pass
>-    
>+
>+    def compareIP(self, treemodel, iter1, iter2, user_data):
>+        """Compare IP addresses numerically"""
>+        val1 = treemodel.get_value(iter1, user_data)
>+        val2 = treemodel.get_value(iter2, user_data)
>+        ip1 = [int(x) for x in val1.split(".")]
>+        ip2 = [int(x) for x in val2.split(".")]
>+        if ip1 == ip2:
>+            return 0
>+        elif ip1 < ip2:
>+            return -1
>+        else:
>+            return 1
>+
>     def setupList(self):
>         """Populates bootfileTreeview with the bootfile names"""
>         self.bootTree = self.xml.get_widget("bootfileTreeview")
>         model = gtk.ListStore (gtk.gdk.Pixbuf, gobject.TYPE_STRING,gobject.TYPE_STRING, gobject.TYPE_STRING,gobject.TYPE_PYOBJECT)
>         model.set_sort_column_id(1, gtk.SORT_ASCENDING)        
>+        model.set_sort_func(3, self.compareIP, 3)
>         self.bootTree.set_model (model)
>         column = gtk.TreeViewColumn (None, gtk.CellRendererPixbuf(), pixbuf=COLUMN_PIXBUF)
>         self.bootTree.append_column (column)

Actions: View | Diff

Attachments on bug 204015: 234001