Attachment 235621 Details for Bug 311901 – 0001-mac80211-no-missing-key-complaint-if-frame-may-no.patch

[patch] 0001-mac80211-no-missing-key-complaint-if-frame-may-no.patch

0001-mac80211-no-missing-key-complaint-if-frame-may-no.patch (text/plain), 1.80 KB, created by John W. Linville on 2007-10-23 21:48:35 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: John W. Linville

Created: 2007-10-23 21:48:35 UTC

Size: 1.80 KB

patch

obsolete

>From 37c01a4d4b8a166eaedc8cd61898c7e15acc958c Mon Sep 17 00:00:00 2001
>From: John W. Linville <linville@tuxdriver.com>
>Date: Tue, 23 Oct 2007 17:25:53 -0400
>Subject: [RFC] mac80211: no missing key complaint if frame may not be for us
>
>Some APs implement support for multiple SSIDs using a single BSSID.
>Each SSID might implement a different protection scheme (or none
>at all).
>
>If we are associated with an unprotected SSID on an AP operating as
>described above, we might receive multicast frames that are actually
>intended for another SSID.  If that SSID is protected, those frames
>currently cause us to log a KERN_DEBUG message: "RX protected frame
>but have no key".  This can cause a lot of traffic in the logs.
>
>Rather than complain if we receive a protected frame for which we
>have no key, then let's just keep quiet unless we are in something
>other than managed mode or unless the frame is unicast.
>
>Signed-off-by: John W. Linville <linville@tuxdriver.com>
>---
> net/mac80211/rx.c |    8 +++++++-
> 1 files changed, 7 insertions(+), 1 deletions(-)
>
>diff --git a/net/mac80211/rx.c b/net/mac80211/rx.c
>index 064924c..1cc67ef 100644
>--- a/net/mac80211/rx.c
>+++ b/net/mac80211/rx.c
>@@ -509,7 +509,13 @@ ieee80211_rx_h_decrypt(struct ieee80211_txrx_data *rx)
> 		rx->key->tx_rx_count++;
> 		/* TODO: add threshold stuff again */
> 	} else {
>-		if (net_ratelimit())
>+		/* if there are multiple SSIDs on this BSSID, the frame may
>+		   not be for us anyway; so, check that either the frame is
>+		   unicast or that we are not in managed mode before
>+		   complaining about a missing key */
>+		if ((!is_multicast_ether_addr(hdr->addr1) ||
>+		     rx->sdata->type != IEEE80211_IF_TYPE_STA) &&
>+		    net_ratelimit())
> 			printk(KERN_DEBUG "%s: RX protected frame,"
> 			       " but have no key\n", rx->dev->name);
> 		return TXRX_DROP;
>-- 
>1.5.2.4
>

Actions: View | Diff

Attachments on bug 311901: 234141 | 235621 | 235631 | 235711