Attachment 240291 Details for Bug 355141 – patch 2

[patch] patch 2

0012-BZ-355141-fs-smbfs-request.c-turn-NULL-dereference.patch (text/plain), 1007 bytes, created by Jeff Layton on 2007-10-27 11:48:27 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jeff Layton

Created: 2007-10-27 11:48:27 UTC

Size: 1007 bytes

patch

obsolete

>From a733f0954925d4009bc227073ea02221e80ad690 Mon Sep 17 00:00:00 2001
>From: Jeff Layton <jlayton@redhat.com>
>Date: Sat, 27 Oct 2007 07:04:48 -0400
>Subject: [PATCH] BZ#355141: fs/smbfs/request.c: turn NULL dereference into BUG()
>
>In a case documented as
>
>  We should never be called with any of these states
>
>BUG() in a case that would later result in a NULL pointer dereference.
>
>Signed-off-by: Adrian Bunk <bunk@stusta.de>
>Signed-off-by: Andrew Morton <akpm@osdl.org>
>Signed-off-by: Linus Torvalds <torvalds@osdl.org>
>---
> fs/smbfs/request.c |    3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
>diff --git a/fs/smbfs/request.c b/fs/smbfs/request.c
>index ca1155e..45ccc20 100644
>--- a/fs/smbfs/request.c
>+++ b/fs/smbfs/request.c
>@@ -789,8 +789,7 @@ int smb_request_recv(struct smb_sb_info *server)
> 		/* We should never be called with any of these states */
> 	case SMB_RECV_END:
> 	case SMB_RECV_REQUEST:
>-		server->rstate = SMB_RECV_END;
>-		break;
>+		BUG();
> 	}
> 
> 	if (result < 0) {
>-- 
>1.5.2.1
>

Actions: View | Diff

Attachments on bug 355141: 240281 | 240291 | 240301 | 240311 | 240321 | 240331 | 240341 | 271431