Attachment 240311 Details for Bug 355141 – patch 4

[patch] patch 4

0014-BZ-355141-smbfs-names_cache-memory-leak.patch (text/plain), 1.24 KB, created by Jeff Layton on 2007-10-27 11:49:09 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jeff Layton

Created: 2007-10-27 11:49:09 UTC

Size: 1.24 KB

patch

obsolete

>From e543573c3dc45fbdf9ff7d25015aa30d1e30f990 Mon Sep 17 00:00:00 2001
>From: Jeff Layton <jlayton@redhat.com>
>Date: Sat, 27 Oct 2007 07:05:41 -0400
>Subject: [PATCH] BZ#355141: smbfs: 'names_cache' memory leak
>
>Data allocated with "__getname()" should always be free'd with "__putname()"
>because of the AUDITSYSCALL code.
>
>Signed-off-by: Davi Arnaut <davi.arnaut@gmail.com>
>Cc: Urban Widmark <urban@teststation.com>
>Signed-off-by: Andrew Morton <akpm@osdl.org>
>Signed-off-by: Linus Torvalds <torvalds@osdl.org>
>---
> fs/smbfs/symlink.c |    4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/fs/smbfs/symlink.c b/fs/smbfs/symlink.c
>index 8b069e0..5eec624 100644
>--- a/fs/smbfs/symlink.c
>+++ b/fs/smbfs/symlink.c
>@@ -45,7 +45,7 @@ static int smb_follow_link(struct dentry *dentry, struct nameidata *nd)
> 		int len = smb_proc_read_link(server_from_dentry(dentry),
> 						dentry, link, PATH_MAX - 1);
> 		if (len < 0) {
>-			putname(link);
>+			__putname(link);
> 			link = ERR_PTR(len);
> 		} else {
> 			link[len] = 0;
>@@ -59,7 +59,7 @@ static void smb_put_link(struct dentry *dentry, struct nameidata *nd)
> {
> 	char *s = nd_get_link(nd);
> 	if (!IS_ERR(s))
>-		putname(s);
>+		__putname(s);
> }
> 
> struct inode_operations smb_link_inode_operations =
>-- 
>1.5.2.1
>

Actions: View | Diff

Attachments on bug 355141: 240281 | 240291 | 240301 | 240311 | 240321 | 240331 | 240341 | 271431