Attachment 242691 Details for Bug 313281 – Patch

[patch] Patch

bug_313281.patch (text/plain), 1010 bytes, created by Jim Hayward on 2007-10-30 04:08:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jim Hayward

Created: 2007-10-30 04:08:23 UTC

Size: 1010 bytes

patch

obsolete

>diff -ur gparted-0.3.3-old/src/GParted_Core.cc gparted-0.3.3/src/GParted_Core.cc
>--- gparted-0.3.3-old/src/GParted_Core.cc	2006-12-05 11:39:31.000000000 -0800
>+++ gparted-0.3.3/src/GParted_Core.cc	2007-10-29 20:46:20.000000000 -0700
>@@ -487,12 +487,15 @@
> 		while ( getline( proc_partitions, line ) )
> 			if ( sscanf( line .c_str(), "%*d %*d %*d %255s", c_str ) == 1 )
> 			{
>+				char *real_path = NULL;
>+				
> 				line = "/dev/" ; 
> 				line += c_str ;
> 				
> 				//FIXME: it seems realpath is very unsafe to use (manpage)...
>+				real_path = realpath( line .c_str(), NULL ) ;
> 				if ( file_test( line, Glib::FILE_TEST_EXISTS ) &&
>-				     realpath( line .c_str(), c_str ) &&
>+				     real_path &&
> 				     line != c_str )
> 				{
> 					//because we can make no assumption about which path libparted will detect
>@@ -500,6 +503,8 @@
> 					alternate_paths[ c_str ] = line ;
> 					alternate_paths[ line ] = c_str ;
> 				}
>+				if ( real_path )
>+				  free( real_path ) ;
> 			}
> 
> 		proc_partitions .close() ;

Actions: View | Diff

Attachments on bug 313281: 242691