Attachment 248661 Details for Bug 367661 – Revert hunk of linux-2.6.9-ppc64-rpacc.patch to use (correct) logical CPU ID

[patch] Revert hunk of linux-2.6.9-ppc64-rpacc.patch to use (correct) logical CPU ID

cpu-stuck.patch (text/plain), 1.15 KB, created by IBM Bug Proxy on 2007-11-05 22:45:52 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: IBM Bug Proxy

Created: 2007-11-05 22:45:52 UTC

Size: 1.15 KB

patch

obsolete

>pseries_secondary_smp_init() expects to recieve logical CPUIDs, this patch
>part of linux-2.6.9-ppc64-rpacc.patch mistakenly passes the hardware IDS.
>Revert that hunk to put things right.
>
>Without this patch machines where phys_id != logical_id will (at best) fail to 
>bring up all CPUS
>
>Signed-off-by: Tony Breeds <tony@bakeyournoodle.com>
>---
>
> arch/ppc64/kernel/prom_init.c |    4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>Index: working/arch/ppc64/kernel/prom_init.c
>===================================================================
>--- working.orig/arch/ppc64/kernel/prom_init.c
>+++ working/arch/ppc64/kernel/prom_init.c
>@@ -1238,12 +1238,12 @@ static void __init prom_hold_cpus(void)
> 			/* Primary Thread of non-boot cpu */
> 			prom_printf("%x : starting cpu hw idx %x... ", cpuid, reg);
> 			call_prom("start-cpu", 3, 0, node,
>-				   secondary_hold, reg);
>+				  secondary_hold, cpuid);
> 
> 			for ( i = 0 ; (i < 100000000) && 
> 			      (*acknowledge == ((unsigned long)-1)); i++ ) ;
> 
>-			if (*acknowledge == reg) {
>+			if (*acknowledge == cpuid) {
> 				prom_printf("done\n");
> 				/* We have to get every CPU out of OF,
> 				 * even if we never start it. */

Actions: View | Diff

Attachments on bug 367661: 248661