Attachment 249461 Details for Bug 368591 – Fix for dvips -z long href title stack overflow from Debian

Fix for dvips -z long href title stack overflow from Debian

dvips-overflow.patch (text/x-patch), 2.68 KB, created by Lubomir Kundrak on 2007-11-06 17:45:26 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lubomir Kundrak

Created: 2007-11-06 17:45:26 UTC

Size: 2.68 KB

patch

obsolete

>--- hps.c.old	2006-01-17 22:41:51.000000000 +0100
>+++ hps.c	2007-10-19 18:22:47.000000000 +0200
>@@ -441,19 +441,32 @@
> 
> void stamp_hps P1C(Hps_link *, pl)
> {
>-  char tmpbuf[200] ;
>+  char * tmpbuf;
>   if (pl == NULL) {
>     error("Null pointer, oh no!") ;
>     return ;
>-  } else {
>-    /* print out the proper pdfm with local page info only 
>-     *  target info will be in the target dictionary */
>-    (void)sprintf(tmpbuf, 
>-		  " (%s) [[%.0f %.0f %.0f %.0f] [%i %i %i [%i %i]] [%.0f %.0f %.0f]] pdfm ", pl->title, pl->rect.llx, pl->rect.lly, pl->rect.urx, pl->rect.ury,
>-		  pl->border[0], pl->border[1], pl->border[2], pl->border[3],pl->border[4],
>-		  pl->color[0], pl->color[1], pl->color[2]) ;
>-    cmdout(tmpbuf) ; 
>-  }
>+  } 
>+  if(pl->title == NULL) {
>+    error("Null pointer, oh no!") ;
>+    return ;
>+  } 
>+
>+  tmpbuf = (char *) malloc(strlen(pl->title)+200);
>+  if(tmpbuf == NULL) {
>+    error("out of memory, oh no!") ;
>+    return ;
>+  } 
>+
>+  /* print out the proper pdfm with local page info only 
>+   *  target info will be in the target dictionary */
>+  (void)sprintf(tmpbuf, 
>+		" (%s) [[%.0f %.0f %.0f %.0f] [%i %i %i [%i %i]] [%.0f %.0f %.0f]] pdfm ", 
>+		pl->title, pl->rect.llx, pl->rect.lly, pl->rect.urx, pl->rect.ury,
>+		pl->border[0], pl->border[1], pl->border[2], pl->border[3],pl->border[4],
>+		pl->color[0], pl->color[1], pl->color[2]) ;
>+  cmdout(tmpbuf) ; 
>+  free(tmpbuf);
>+  
>   
> }
> 
>@@ -462,18 +475,31 @@
>  */
> void stamp_external P2C(char *, s, Hps_link *, pl) 
> {
>-  char tmpbuf[200];
>+  char *tmpbuf;
>   if (pl == NULL) {
>     error("Null pointer, oh no!") ;
>     return ;
>-  } else {
>-    /* print out the proper pdfm with local page info only 
>-     *  target info will be in the target dictionary */
>-    (void)sprintf(tmpbuf," [[%.0f %.0f %.0f %.0f] [%i %i %i [%i %i]] [%.0f %.0f %.0f]] (%s) pdfm ", pl->rect.llx, pl->rect.lly, pl->rect.urx, pl->rect.ury,
>-		  pl->border[0], pl->border[1], pl->border[2], pl->border[3],pl->border[4],
>-		  pl->color[0], pl->color[1], pl->color[2], s) ;
>-    cmdout(tmpbuf) ;
>-  }
>+  } 
>+
>+  if (s == NULL) {
>+    error("Null pointer, oh no!") ;
>+    return ;
>+  } 
>+
>+  tmpbuf = (char *) malloc(strlen(s) + 200);
>+  if(tmpbuf == NULL) {
>+    error("out of memory, oh no!") ;
>+    return ;
>+  } 
>+
>+  /* print out the proper pdfm with local page info only 
>+   *  target info will be in the target dictionary */
>+  (void)sprintf(tmpbuf," [[%.0f %.0f %.0f %.0f] [%i %i %i [%i %i]] [%.0f %.0f %.0f]] (%s) pdfm ",
>+		pl->rect.llx, pl->rect.lly, pl->rect.urx, pl->rect.ury,
>+		pl->border[0], pl->border[1], pl->border[2], pl->border[3],pl->border[4],
>+		pl->color[0], pl->color[1], pl->color[2], s) ;
>+  cmdout(tmpbuf) ;
>+  free(tmpbuf);
> }
> 
> void finish_hps P1H(void) {

Actions: View

Attachments on bug 368591: 249461